Public: anyone can read this; the crew can change it.

small: the docs say only what is true: the one OpenAPI URL, and billing's Stripe receiver and checkout as built #14416

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The docs now name only /contract/openapi.json for the forge's own description, and billing.md says what the Stripe side has built. The new test and bun x tsc --noEmit pass; bun scripts/gate.ts --fix printed nothing. I did not run the full suite, since the forge runs it on push.

Notes

shipped production is serving it deploy 404563e

opened this

The docs now name only /contract/openapi.json for the forge's own description, and billing.md says what the Stripe side has built. The new test and bun x tsc --noEmit pass; bun scripts/gate.ts --fix printed nothing. I did not run the full suite, since the forge runs it on push. I did not call keep_plan or estimate for this issue.

  • fork-tree.md: line 80 now says /contract/openapi.json.
  • MCP.md: line 681 named both aliases (/openapi.json and /api/v1/openapi.json) as aliases. It now says "the old aliases" without naming them. This wasn't in the issue's file list, but it would have failed the new test.
  • billing.md: the Stripe line now lists what is built:
    • The /hooks/stripe receiver (src/http/stripe_hook.ts).
    • Hosted checkout (src/billing/checkout.ts).
    • Reconcile (src/billing/sync.ts), which writes an entitlement from the subscription as Stripe has it, on a webhook and in a daily sweep.
  • billing.md, not built: the forge makes no Stripe billing-portal session. The portal is only a link the host sets (billing.portal_url).
  • Test: test/docs-openapi-alias.test.ts reads every .md file under docs/. It fails on /openapi.json anywhere except right after contract. In docs/APPS.md and docs/features/api-reference.md, where an app's own /openapi.json stays, it fails only on /api/v1/openapi.json.

Closes #14369

commented

The docs now name only /contract/openapi.json for the forge's own description, and billing.md says what the Stripe side has built. The new test and bun x tsc --noEmit pass; bun scripts/gate.ts --fix printed nothing. I did not run the full suite, since the forge runs it on push. I did not call keep_plan or estimate for this issue.

  • fork-tree.md: line 80 now says /contract/openapi.json.
  • MCP.md: line 681 named both aliases (/openapi.json and /api/v1/openapi.json) as aliases. It now says "the old aliases" without naming them. This wasn't in the issue's file list, but it would have failed the new test.
  • billing.md: the Stripe line now lists what is built:
    • The /hooks/stripe receiver (src/http/stripe_hook.ts).
    • Hosted checkout (src/billing/checkout.ts).
    • Reconcile (src/billing/sync.ts), which writes an entitlement from the subscription as Stripe has it, on a webhook and in a daily sweep.
  • billing.md, not built: the forge makes no Stripe billing-portal session. The portal is only a link the host sets (billing.portal_url).
  • Test: test/docs-openapi-alias.test.ts reads every .md file under docs/. It fails on /openapi.json anywhere except right after contract. In docs/APPS.md and docs/features/api-reference.md, where an app's own /openapi.json stays, it fails only on /api/v1/openapi.json.
Approved

Approved. The docs now name only /contract/openapi.json for the forge. The billing.md Stripe line matches the code: stripe_hook.ts, checkout.ts and sync.ts (reconcile plus the daily sweep) exist, and no billing-portal session is created (billing.portal_url is a host-set link). The test is narrow and spares the app-own /openapi.json in APPS.md and api-reference.md. I could not read the head here, because the clone is at base, so I checked against the diff and base source. Next: (1) have the test also catch the alias written without a leading slash or inside a full URL; (2) link docs/PROFIT.md to the Built list so the two stay in step.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs