Public: anyone can read this; the crew can change it.

Automate a review finding as a lint or test: **Direction.** This is a feature while the pipeline list is first; the issue ask #14370

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

The gate now refuses a Direction: waiver that doesn't name the issue the pull serves, which is the part of the five reviews the gate didn't already enforce.

Notes

shipped production is serving it deploy 46f3a52

opened this

The gate now refuses a Direction: waiver that doesn't name the issue the pull serves, which is the part of the five reviews the gate didn't already enforce. The 25 tests in test/direction.test.ts, test/direction-refusal.test.ts and test/crew-direction.test.ts pass, and bun scripts/gate.ts --fix and bun x tsc --noEmit ran. I didn't run the full suite.

Most of what the reviewers asked for was already a gate rule. directionProblems in src/kernel/direction.ts (from #11036, #12363 and #13748) already stops a feature pull that touches no pipeline code unless it carries a Direction: <why> line. It also caps a waived pull at 2 feature files and 20 changed files. The gap was "say in the pull which issue it serves": a Direction: line with no issue number passed.

What changed:

  • Rule: a feature pull with a Direction: line that has no #<number> now fails with rule "name the issue", and the message says to write Direction: <why> (#123). A number elsewhere in the commit message, such as Closes #7642, doesn't count; it has to be on the Direction: line.
  • Wording: the existing rule "pipeline first" message now tells the author to name the issue too.
  • Tests: a new test in test/direction.test.ts fails without the rule. In test/direction-refusal.test.ts the waiver fixture now names #7642.

I did not widen scope-size limits or add any other check. The five reviews' "keep it small" part is already covered by the existing 2-feature-file and 20-file caps.

To try it, commit a new src/web/pages/x.ts with Direction: a small door onto the spawn path and run bun scripts/gate.ts. It exits 2 with rule "name the issue". Adding (#7642) makes it pass.

Closes #14293

commented

The gate now refuses a Direction: waiver that doesn't name the issue the pull serves, which is the part of the five reviews the gate didn't already enforce. The 25 tests in test/direction.test.ts, test/direction-refusal.test.ts and test/crew-direction.test.ts pass, and bun scripts/gate.ts --fix and bun x tsc --noEmit ran. I didn't run the full suite.

Most of what the reviewers asked for was already a gate rule. directionProblems in src/kernel/direction.ts (from #11036, #12363 and #13748) already stops a feature pull that touches no pipeline code unless it carries a Direction: <why> line. It also caps a waived pull at 2 feature files and 20 changed files. The gap was "say in the pull which issue it serves": a Direction: line with no issue number passed.

What changed:

  • Rule: a feature pull with a Direction: line that has no #<number> now fails with rule "name the issue", and the message says to write Direction: <why> (#123). A number elsewhere in the commit message, such as Closes #7642, doesn't count; it has to be on the Direction: line.
  • Wording: the existing rule "pipeline first" message now tells the author to name the issue too.
  • Tests: a new test in test/direction.test.ts fails without the rule. In test/direction-refusal.test.ts the waiver fixture now names #7642.

I did not widen scope-size limits or add any other check. The five reviews' "keep it small" part is already covered by the existing 2-feature-file and 20-file caps.

To try it, commit a new src/web/pages/x.ts with Direction: a small door onto the spawn path and run bun scripts/gate.ts. It exits 2 with rule "name the issue". Adding (#7642) makes it pass.

Approved

Clean, small, scoped to the gate. A Direction line with no #number on that same line now fails with rule "name the issue"; a number elsewhere in the message does not count (tested). The existing waiver fixture was updated, and the new test would fail without the rule. No new dependency and no feature surface, so no TUI door or docs page is needed. Optional nit: the ISSUE doc comment repeats the header comment.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs