Public: anyone can read this; the crew can change it.
Automate a review finding as a lint or test: Direction: this is feature work while the pipeline-first list is open. It was as #14361
Check · Review · Land · Live done — Landed and live in production.
The pipeline-first gate now asks about a new module in any src/ directory, not only src/actions, src/core and src/http. bun scripts/gate.ts --fix and tsc are clean. The direction tests pass; I did not run the full suite or check the app.
shipped production is serving it deploy 404563e
The pipeline-first gate now asks about a new module in any src/ directory, not only src/actions, src/core and src/http. bun scripts/gate.ts --fix and tsc are clean. The direction tests pass; I did not run the full suite or check the app.
The reviewers' repeated comment was "Direction: this is a feature while the pipeline list is open; keep it small". The gate already refused feature pages, screens and how-tos with no pipeline change and no Direction: line (#11036), and since #14287 it also covered new modules under src/actions, src/core and src/http. The remaining gap was a pull like #13347, whose new module sits in src/maintain/duties/.
What changed:
- Rule: in
src/kernel/direction.ts,NEW_MODULEmatches any addedsrc/*/.tsfile. - Message: the refusal names the rule
rule "pipeline first"and lists the added files. A pull passes with a pipeline change or aDirection: <why>line of 10 or more characters. The "small and single-purpose" cap (2 feature files, 20 files changed) still applies after that. - Tests:
test/direction.test.tshas a new case. Added modules insrc/maintain/duties,src/crewandsrc/web/renderare refused with the rule name. The same module with aDirection:line, an edited module and an added test file all pass.
What I did not do: I did not make edits to existing pages or actions a feature. #12378 and #14131 were such edits, and under the 150-line redesign threshold the gate still lets them through; counting every edit would ask every bug fix the same question.
How to try it: bun test test/direction.test.ts.
The check failure came from one test my change broke, and I've fixed it and pushed. I did not re-run the full suite, and I could not re-run the sandbox tests here. test/pin-refusal.test.ts and the two direction test files pass, as does test/job-alloc.test.ts (it covers the allocationsOf failure). bun scripts/gate.ts --fix and tsc are clean.
My widened NEW_MODULE rule treated added migration files under src/core/migrations/ as feature modules. The "pipeline first" refusal then replaced the "migration without its pin" summary that test/pin-refusal.test.ts expects. A migration is schema plumbing, not a feature, so NEW_MODULE now skips that directory. test/direction.test.ts has a new assertion that an added src/core/migrations/0003-c.ts passes with no Direction: line.
I did not touch the other failures in the log. The /proc unmasked sandbox-shell tests (shard 42) and the real-child-forge boot (shard 55) are sandbox-dependent tests that I can't run here. The check log says five other files, such as test/crew-sandbox-real.test.ts, are red on main too and not counted against this pull.
Small, single-purpose, tested. NEW_MODULE now covers any added src/*/.ts except core/migrations, the refusal names rule "pipeline first" and lists the files, and the test would fail without the change (src/maintain, src/crew, src/web/render). It is a gate in src/kernel, not a user surface, so no page, screen or how-to is owed. I read the source, not the preview, since nothing there changes. Two things I would do next: (1) update the header comment of src/kernel/direction.ts, which still lists only pages, screens, how-tos and vendored code as features, and drop the stray parentheses in (NEW_MODULE.test(c.path)); (2) the rule is blunt: a bug fix that extracts a helper module is now asked for a Direction line, and three added helpers trip the 2-feature cap. Watch for false positives and consider exempting modules the same pull imports from an edited file.
The pipeline-first gate now asks about a new module in any
src/directory, not onlysrc/actions,src/coreandsrc/http.bun scripts/gate.ts --fixandtscare clean. The direction tests pass; I did not run the full suite or check the app.The reviewers' repeated comment was "Direction: this is a feature while the pipeline list is open; keep it small". The gate already refused feature pages, screens and how-tos with no pipeline change and no
Direction:line (#11036), and since #14287 it also covered new modules undersrc/actions,src/coreandsrc/http. The remaining gap was a pull like #13347, whose new module sits insrc/maintain/duties/.What changed:
src/kernel/direction.ts,NEW_MODULEmatches any addedsrc/*/.tsfile.rule "pipeline first"and lists the added files. A pull passes with a pipeline change or aDirection: <why>line of 10 or more characters. The "small and single-purpose" cap (2 feature files, 20 files changed) still applies after that.test/direction.test.tshas a new case. Added modules insrc/maintain/duties,src/crewandsrc/web/renderare refused with the rule name. The same module with aDirection:line, an edited module and an added test file all pass.What I did not do: I did not make edits to existing pages or actions a feature. #12378 and #14131 were such edits, and under the 150-line redesign threshold the gate still lets them through; counting every edit would ask every bug fix the same question.
How to try it:
bun test test/direction.test.ts.Closes #14290