Public: anyone can read this; the crew can change it.

The nightly release was held: tests failed on ec25086ac #14360

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

This fixes the two tests that held the nightly release. Both had gone red on main from two earlier changes. I ran test/design-lint.test.ts, test/attention.test.ts and the explore tests (323 pass, 0 fail), plus tsc --noEmit and scripts/gate.ts --fix, all clean.

Notes

shipped production is serving it deploy 4ec2c16

opened this

This fixes the two tests that held the nightly release. Both had gone red on main from two earlier changes. I ran test/design-lint.test.ts, test/attention.test.ts and the explore tests (323 pass, 0 fail), plus tsc --noEmit and scripts/gate.ts --fix, all clean. I did not run the full suite, so the forge's check on this push is the first full run.

  • Layout debt: the docs index added padding: 0 16px 10px in src/web/style/components.ts, which is off the spacing scale. It is now 0 16px 8px, so the count of named spacing debt in that file is back to 68. The line is 2px tighter under each docs index entry.
  • Baseline: I also ran bun scripts/design-lint.ts --update. That dropped a stale space_client.ts fixed-box entry from docs/design/baseline.json, since the debt there is already paid.
  • Explore first-view budget: the explore subtitle had grown to 43 words against a budget of 42. It now reads "Public apps and their builders, ranked by use, forks, deployments and recency." I trimmed the copy rather than raise the budget in docs/design/attention-budget.json.

I left the budgets and rules themselves unchanged.

To try it, open /explore and /docs on the preview; the explore subtitle is the visible change. The nightly tick at 10:30 UTC should release once this merges.

🤖 Generated with Claude Code

Closes #14347

2 earlier comments
commented

I merged main into the branch and pushed it. The only conflict was src/web/style/components.ts.

Both sides had changed the .docs-index > li padding to get it back on the spacing scale. Mine was 0 16px 8px; main's was 0 16px 12px. I kept main's 12px, so the docs index keeps its original spacing and the 2px tightening from my first push is gone.

After the merge, tsc --noEmit is clean. test/design-lint.test.ts, test/attention.test.ts and the explore tests pass (323 pass, 0 fail). I did not run the full suite.

scripts/gate.ts warned that the src/web/studio/explore.ts change adds no test. I added a No test: line to a new empty commit, because the existing attention-budget test already fails without the shortened explore subtitle. The same commit has a Looks: /explore line.

The rest of the pull is as before: the explore subtitle is one word shorter ("Public apps and their builders, ranked by use, forks, deployments and recency."). The stale space_client.ts entry is gone from docs/design/baseline.json.

🤖 Generated with Claude Code

commented

<!-- look-pages 92a8c4c03d47 --> Look pages for 92a8c4c, from the gate:

  • look pages (named): this pull changes src/web/studio/explore.ts; a commit names /explore
commented

Nothing in that comment asks for a change. It is the gate's note on which pages it will picture for this push: /explore, because a commit names it (Looks: /explore) and the pull touches src/web/studio/explore.ts. That is the page I meant. I made no changes and did not push.

Approved

Approved. The preview /explore serves the shortened subtitle (one sentence, plain words, no layout change; it is shorter so it wraps less on a 360px phone). The baseline entry removal is a ratchet tightening and the pull is green. Next: (1) make the subtitle/attention-budget limit an explicit number in the test message so the next copy edit does not re-break the nightly; (2) when a design baseline entry goes stale, have design-lint name it in its failure so no one has to hunt.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs