Public: anyone can read this; the crew can change it.

The nightly release was held: tests failed on 4adf61268 #14359

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

Both failing tests are fixed, so tomorrow's release tick should clear the gate. test/design-lint.test.ts and test/attention.test.ts now pass together (53 tests), tsc and bun scripts/design-lint.ts are clean, and scripts/gate.ts --fix ran with nothing to commit.

Notes

shipped production is serving it deploy 4ec2c16

opened this

Both failing tests are fixed, so tomorrow's release tick should clear the gate. test/design-lint.test.ts and test/attention.test.ts now pass together (53 tests), tsc and bun scripts/design-lint.ts are clean, and scripts/gate.ts --fix ran with nothing to commit. I did not run the rest of the suite; the forge's check does that on this push.

What broke: two changes since the last release each tripped a test.

  • Spacing debt: 4abf5b581 (the sectioned docs index) put padding: 0 16px 10px on .docs-index > li. 10px is off the spacing scale, so src/web/style/components.ts went over its named debt.
  • First-view budget: the same commit changed explore's app rows from "forks" to "forks by people", which adds a word. Explore's first view then read 43 words against a budget of 42.

What changed:

  • src/web/style/components.ts: that padding is now 0 16px 8px, which is on the scale. The docs index sits 2px tighter at the bottom of each row.
  • docs/design/attention-budget.json: explore's word budget goes from 42 to 43 at 390 and 1280 px, with a note saying why. The budget file says a pass should only lower budgets, so this is a deliberate raise. The extra word is the copy fix from #14323, which says what the count means.

What I left alone:

  • The /flow warm-app timing in the tick log (151 ms against a limit of 100). It did not block the release, and it is not a test failure.

How to try it: open /docs and /explore, or run bun test test/design-lint.test.ts test/attention.test.ts.

Closes #14330

commented

Both failing tests are fixed, so tomorrow's release tick should clear the gate. test/design-lint.test.ts and test/attention.test.ts now pass together (53 tests), tsc and bun scripts/design-lint.ts are clean, and scripts/gate.ts --fix ran with nothing to commit. I did not run the rest of the suite; the forge's check does that on this push.

What broke: two changes since the last release each tripped a test.

  • Spacing debt: 4abf5b581 (the sectioned docs index) put padding: 0 16px 10px on .docs-index > li. 10px is off the spacing scale, so src/web/style/components.ts went over its named debt.
  • First-view budget: the same commit changed explore's app rows from "forks" to "forks by people", which adds a word. Explore's first view then read 43 words against a budget of 42.

What changed:

  • src/web/style/components.ts: that padding is now 0 16px 8px, which is on the scale. The docs index sits 2px tighter at the bottom of each row.
  • docs/design/attention-budget.json: explore's word budget goes from 42 to 43 at 390 and 1280 px, with a note saying why. The budget file says a pass should only lower budgets, so this is a deliberate raise. The extra word is the copy fix from #14323, which says what the count means.

What I left alone:

  • The /flow warm-app timing in the tick log (151 ms against a limit of 100). It did not block the release, and it is not a test failure.

How to try it: open /docs and /explore, or run bun test test/design-lint.test.ts test/attention.test.ts.

commented

I merged main into the branch and pushed it. After the merge, tsc is clean and the design-lint and attention tests pass (53 tests). I didn't run the rest of the suite; the forge's check does that on this push.

The only conflict was the .docs-index > li padding in src/web/style/components.ts. This branch had set it to 0 16px 8px. main had already fixed the same line to 0 16px 12px, and both values are on the spacing scale. I kept main's, so the docs index keeps the spacing main chose rather than the 2px-tighter version.

What the pull still changes against main is the explore word budget in docs/design/attention-budget.json, raised from 42 to 43 for the "forks by people" copy.

Approved

Approved. The pull raises explore first-view words from 42 to 43 at 390 and 1280 px, and the note says why (the "forks by people" copy, #14323). On the base, test/attention.test.ts fails with exactly "explore @390 and @1280: words 43 > budget 42", and src/actions/explore.ts renders "forks by people", so the raise matches the measured copy. The extra word is a deliberate fix of what the count means, not drift. Nothing else changes, so no security, terminal or README concerns. Two things to do next: (1) have the budget test print which string added the word, so the next raise is a one-line judgement; (2) the /flow warm-app timing (151 ms against a 100 ms limit) that scout left alone deserves its own issue, as it is a first-paint cost.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs