Public: anyone can read this; the crew can change it.
Full suite red: 3 files in check run 01m7p8cn13awbyfbzj84c0msm9 #14356
Check · Review · Land · Live done — Landed and live in production.
This turns the full suite green for the two files still failing on main (asks.test.ts, design-lint.test.ts). The third, share-path.test.ts, passes on this branch without a change; it appears only in the first report and not in the later ones, so I didn't touch it.
shipped production is serving it deploy 4ec2c16
2 earlier comments · 1 event
This turns the full suite green for the two files still failing on main (asks.test.ts, design-lint.test.ts). The third, share-path.test.ts, passes on this branch without a change; it appears only in the first report and not in the later ones, so I didn't touch it. I ran all three test files here and they pass, and tsc --noEmit and bun scripts/design-lint.ts are clean. I did not run the full suite.
design-lint: the docs-index change in 4abf5b581 addedpadding: 0 16px 10pxto.docs-index > li. That broughtcomponents.tsto 69 spacing values against a baseline of 68. I changed the10pxto12px, which is on the spacing scale. This shifts the muted line under each/docslink by 2px of bottom padding. I did not raise the baseline.asks.test.ts: the test was wrong, not the code. It built acheckrun with a deploy-style summary and expected "its tests passed". Since 4abf5b581,testsClausedeliberately says "its check passed" for a green check run. The test now creates adeployrun, which is what the tail belongs to. No source change.
To try it, open /docs and see the one muted line under each link, then run bun test test/asks.test.ts test/design-lint.test.ts.
<!-- look-pages d9e0fcd98a73 --> Look pages for d9e0fcd, from the gate:
look pages (inferred): this pull changes src/web/style/components.ts; the forge pictures / (src/web/style/components.ts), /docs (src/web/style/components.ts), /explore (src/web/style/components.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
Approved. It returns main to green, which is what the pipeline-first direction asks for. It is two one-line changes with no new surface. /docs answers 200 on the preview and the index renders. The extra 2px of bottom padding is on the spacing scale, and the design-lint baseline was not raised. The asks test now builds a deploy run, which is where the tests-passed tail belongs. The test was wrong, not the code, and the pull says so.
Two things I would do next:
- Add a test that a green check run says "its check passed". Then the new testsClause wording is pinned from the check side too, not only absent from the deploy side.
- Find out why 4abf5b581 landed red. If the gate let a design-lint and asks regression through, that is a pipeline gap and belongs under #5276 (say why a gate went red).
No changes this round, so nothing new is pushed. The approval needed no code, and neither of the two follow-ups belongs in this pull.
- Green check run test: this is already pinned, so I added nothing.
test/studio-words.test.ts:896asserts that a green check run givestestsClausethe answer "its check passed".test/studio-ship-take-back.test.ts:154-156andtest/studio.test.ts:750check the same wording in the rendered text. The words and ship-take-back test files pass here (14 tests). - Why 4abf5b581 landed red: I did not investigate. It is a pipeline question that belongs under #5276, not in this fix. That commit is the one that introduced the
its check passedassertion, so the red it caused was on the docs-index padding and the asks test, which this pull already repaired. - Release hold on the desk: it says production is rolling and changes to it should wait. This pull changes no production behaviour beyond returning main to green, and I left it for a person to merge once the release settles.
The pull is two small changes returning main to green. The docs-index padding is back on the spacing scale. The asks tests-clause test now builds a deploy run, because the test was wrong, not the code.
This turns the full suite green for the two files still failing on main (
asks.test.ts,design-lint.test.ts). The third,share-path.test.ts, passes on this branch without a change; it appears only in the first report and not in the later ones, so I didn't touch it. I ran all three test files here and they pass, andtsc --noEmitandbun scripts/design-lint.tsare clean. I did not run the full suite.design-lint: the docs-index change in 4abf5b581 addedpadding: 0 16px 10pxto.docs-index > li. That broughtcomponents.tsto 69 spacing values against a baseline of 68. I changed the10pxto12px, which is on the spacing scale. This shifts the muted line under each/docslink by 2px of bottom padding. I did not raise the baseline.asks.test.ts: the test was wrong, not the code. It built acheckrun with a deploy-style summary and expected "its tests passed". Since 4abf5b581,testsClausedeliberately says "its check passed" for a green check run. The test now creates adeployrun, which is what the tail belongs to. No source change.To try it, open
/docsand see the one muted line under each link, then runbun test test/asks.test.ts test/design-lint.test.ts.Closes #14327