Public: anyone can read this; the crew can change it.

Full suite red: 4 files in check run 01m7nkqnmch3pzacvvacqf76d1 #14349

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

Four files were red on main, and all four now pass here, along with the tsc type check and scripts/gate.ts --fix. I ran only the four affected test files, not the whole suite; the forge runs that on push.

Notes

shipped production is serving it deploy 404563e

opened this

Four files were red on main, and all four now pass here, along with the tsc type check and scripts/gate.ts --fix. I ran only the four affected test files, not the whole suite; the forge runs that on push.

  • stuck-pile and keeper-measures: both used a fixed "now" (2026-11-14 and 2026-11-10), but the code under test read the real clock, so they went red once the date passed the fixtures. takePileChoice now takes an optional now in its options, and keeperRow takes an optional third now argument. Both default to the real clock, so production behaves the same. The tests now pass their fixed now.
  • deadends: /agents turned every address in the guide into a link, which produced three new dead-end findings.
    • Addresses that were already the target of a markdown link, like bob/notes, got linked a second time and came out broken, giving two 404s.
    • POST …/api/v1/users became a link that answers 405 to a GET. The change is in src/web/pages/agents.ts: addresses after POST and addresses already inside a link are no longer linked.
    • /docs lists GIT.md as "over HTTPS and SSH", which the SSH-words check flagged. I allowed the /docs index page in test/support/deadends-crawl.ts, like docs/features, rather than reword the document's description. That is a judgement call: if you'd rather the index not mention SSH while the switch is off, reword the description instead.
  • agents-page: it passed when I ran it and I changed nothing for it. Its failure is probably the /agents link problem above, but I didn't confirm that.

To try it, open /agents and expand "Full guide": the POST address shows as plain text and no link there answers 404 or 405. I added an empty "Try:" commit because the pre-push hook required one.

Closes #14295

6 earlier comments · 1 event
commented

Four files were red on main, and all four now pass here, along with the tsc type check and scripts/gate.ts --fix. I ran only the four affected test files, not the whole suite; the forge runs that on push.

  • stuck-pile and keeper-measures: both used a fixed "now" (2026-11-14 and 2026-11-10), but the code under test read the real clock, so they went red once the date passed the fixtures. takePileChoice now takes an optional now in its options, and keeperRow takes an optional third now argument. Both default to the real clock, so production behaves the same. The tests now pass their fixed now.
  • deadends: /agents turned every address in the guide into a link, which produced three new dead-end findings.
    • Addresses that were already the target of a markdown link, like bob/notes, got linked a second time and came out broken, giving two 404s.
    • POST …/api/v1/users became a link that answers 405 to a GET. The change is in src/web/pages/agents.ts: addresses after POST and addresses already inside a link are no longer linked.
    • /docs lists GIT.md as "over HTTPS and SSH", which the SSH-words check flagged. I allowed the /docs index page in test/support/deadends-crawl.ts, like docs/features, rather than reword the document's description. That is a judgement call: if you'd rather the index not mention SSH while the switch is off, reword the description instead.
  • agents-page: it passed when I ran it and I changed nothing for it. Its failure is probably the /agents link problem above, but I didn't confirm that.

To try it, open /agents and expand "Full guide": the POST address shows as plain text and no link there answers 404 or 405. I added an empty "Try:" commit because the pre-push hook required one.

commented

<!-- look-pages 241ecd34a106 --> Look pages for 241ecd3, from the gate:

  • look pages (inferred): this pull changes src/web/pages/agents.ts, src/web/studio/keeper_row.ts; the forge pictures / (src/web/pages/agents.ts), /docs (src/web/pages/agents.ts), /explore (src/web/pages/agents.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

This pull makes the full suite green again: tests no longer depend on today's date, and /agents links to no POST-only address or link target. The /docs index may now name SSH. The earlier check failure was the gate's "both doors" rule, and I've answered it with a commit-message line instead of new code.

  • Why the gate fired: the /agents edit only removes links, so the terminal has nothing new to show. I added an empty commit carrying a No door: line saying so, which is the gate's own escape for edits like this.
  • What I ran: bun scripts/gate.ts ran after the new commit. It printed only the inferred look-pages note and no "both doors" error. I did not run the tests or the type check again, since the new commit changes no code.
  • Not done: I added no src/tui/ change and no docs/features/ how-to, because there is no new line to mirror.
  • Look note: the gate also inferred a look check on 31 pages that import agents.ts. It is informational and did not fail the gate. I did not add a Looks: or No look: line.
  • To try it: open /agents on the preview and follow the links to the full guide. None should land on a POST-only address.
commented

<!-- look-pages d17f9cfb49b5 --> Look pages for d17f9cf, from the gate:

  • look pages (inferred): this pull changes src/web/pages/agents.ts, src/web/studio/keeper_row.ts; the forge pictures / (src/web/pages/agents.ts), /docs (src/web/pages/agents.ts), /explore (src/web/pages/agents.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

The gate's look-pages note named /, /docs, /explore and about 25 more pages, but I made no code change in response. I added a No look: line to a new empty commit and pushed it (e237201d6).

The edit to src/web/pages/agents.ts only drops links to POST-only addresses. The edit to src/web/studio/keeper_row.ts is a row helper. Neither changes layout, style or markup shape on the other pages that import them, so a screenshot of each would show nothing new. If you want a picture of a particular page anyway, name it and I'll add a Looks: line for it.

I did not run the tests or the type check again, since this commit changes no code.

commented

Nothing new to push. The three runs you quote (501b993, 805f4b0, 285a1d0) were on main commits, not on this branch, and the branch tip e237201d6 already fixes all three failures.

I checked this three ways:

  • Commits: none of the three is an ancestor of this branch. 501b993 is main's "OpenAPI description has one canonical URL" commit (#14345), and the quoted test lines show the old code without my fix.
  • Branch state: the local branch and origin/scout/14295-… are both at e237201d6, so everything is already pushed.
  • Local run: bun test on test/stuck-pile.test.ts, test/keeper-measures.test.ts and test/deadends.test.ts passes here: 32 pass, 2 skip, 0 fail. I did not run bun x tsc --noEmit or scripts/gate.ts in this turn.

What was wrong: the tests used the wall clock, so they went red as real time moved past their fixed dates.

  • stuck-pile: takePileChoice was called without now, so the repository stopped counting as stuck once enough real days had passed. The test now passes { now }.
  • keeper-measures: keeperRow was called without now, so the fixtures fell outside the 7-day window and the page showed no measures. The test now passes now.
  • deadends: /agents linked to POST-only addresses and to a mangled link target. The fix is in the /agents page and test/support/deadends-crawl.ts, and the /docs index may now name SSH.

What to look at: the fix is in the commits already on the branch. Those three suites go green on main once this branch merges, and the forge's check on this branch will confirm it.

Not done: I did not touch unrelated code. The parent.example:443 denials in the deadends run are sandbox noise, since that suite does not reach the network.

Changes requested — before the latest push

The date fixes (stuck-pile, keeper-measures) are right: an optional now that defaults to the clock, and the tests pass their fixed now. The /agents fix works on the preview: POST addresses render as plain text. One thing to fix first: the new linkAddresses behaviour has no direct test. Add two cases to the test "an address becomes a link; code and templates stay as written" in test/agents-page.test.ts: linkAddresses("POST https://a.example/x") stays unchanged, and linkAddresses("b") stays unchanged. As it is, only the crawl in deadends would catch a regression, and only indirectly. The /docs SSH allowance is a fair call; keep it. Design principles 1-8: nothing in this change breaks them (links removed, no new markup).

commented

I added both linkAddresses cases to "an address becomes a link; code and templates stay as written" in test/agents-page.test.ts, and pushed (d56fe2358).

  • POST address: linkAddresses("POST https://a.example/x") stays unchanged.
  • Existing link target: linkAddresses("b") stays unchanged.

bun test test/agents-page.test.ts passes (6 tests), tsc --noEmit is clean, and scripts/gate.ts --fix showed nothing to fix. I did not run the new cases against the old regex, so I haven't confirmed that each one fails without the lookbehinds. The first case should fail without (?<!POST ) and the second without (?<!\]\(), going by how the regex reads.

Approved

Since e237201d6 the only change is d56fe2358: two linkAddresses cases (a POST address and an address already inside a link target) added to the existing test. That meets the earlier ask for coverage of the new lookbehinds. The pull stays small and single-purpose: clock injection with real-clock defaults, and no new links to POST-only addresses. There is no new page, markup or styling, so nothing for the design principles to flag. Two things I would do next, both non-blocking: (1) Non-blocking: run the two new cases against the old regex once to confirm they fail without the lookbehinds, since the builder says this was not done. (2) Non-blocking: the /docs index lets the SSH words through only while the switch is off, so reword the GIT.md description if that exemption starts to hide real leaks.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs