Public: anyone can read this; the crew can change it.

A connected forge shows Gitea's cup on imported repository pages, search results and the terminal #14341

opened this in answer to

Check · Review · Land · Live — No review yet. Next: reviewer, no review yet.

Ready to land

A repository mirrored from another forge now shows the anvil on its thread and browse pages, in search results and in the terminal. A Gitea origin still gets the cup. Type check and the tests I ran pass; I did not run the full suite.

Notes · 12 files · +101 −15

look green — it answered, no tests were run, ready for a look deploy 9957c2f

Check passeddeploy 9957c2f

Website spec: 26 findings (report only)

Look

10 pages beside main · 0 new to this pull

/apps

main

at 7c29c34 ·

this pull

In the dark

main

at 7c29c34 ·

this pull

at 9957c2f ·

/docs

main

at 7c29c34 ·

this pull

In the dark

main

at 7c29c34 ·

this pull

at 9957c2f ·

/explore

main

at 7c29c34 ·

this pull

In the dark

main

at 7c29c34 ·

this pull

at 9957c2f ·

/looks/failed

main

at 7c29c34 ·

this pull

In the dark

main

at 7c29c34 ·

this pull

at 9957c2f ·

/looks/missing

main

at 7c29c34 ·

this pull

In the dark

main

at 7c29c34 ·

this pull

at 9957c2f ·

/nope/nothing

main

at 7c29c34 ·

this pull

In the dark

main

at 7c29c34 ·

this pull

at 9957c2f ·

/notes

main

at 7c29c34 ·

this pull

In the dark

main

at 7c29c34 ·

this pull

at 9957c2f ·

/releases

main

at 7c29c34 ·

this pull

In the dark

main

at 7c29c34 ·

this pull

at 9957c2f ·

/review

main

at 7c29c34 ·

this pull

In the dark

main

at 7c29c34 ·

this pull

at 9957c2f ·

/security

main

at 7c29c34 ·

this pull

In the dark

main

at 7c29c34 ·

this pull

at 9957c2f ·

opened this

A repository mirrored from another forge now shows the anvil on its thread and browse pages, in search results and in the terminal. A Gitea origin still gets the cup. Type check and the tests I ran pass; I did not run the full suite. I could not run scripts/fast.ts usefully: it found 3243 of 3741 files for this diff and estimated 273 minutes. I ran test/origins-page-shape, tui-icons, tui-take-back, forge-origin, mcp-search, commits-fit, mcp-origins, browse-origin-timing and mcp-threads instead; the forge's check runs the rest.

  • Queries: RepoOrigin in src/core/repos.ts now carries software beside kind, and the repo query selects it. Search origin hits carry originSoftware.
  • Web: thread and studio comment tags, browse and commit author tags, the scope place bar and search result rows all draw through originIcon.
  • Terminal: src/tui/ui/icons.ts gains anvil and gitea icons and an originMark mapping. The connections screen now puts that icon before each origin. The nerd-font code points for the cup (nf-md-coffee) and the anvil are my best picks and were not checked in a real terminal. Both sets keep the one-cell width rule.
  • Tests: test/origins-page-shape.test.ts covers the repo query, originGlyph and the search hit for a mirror from another forge. test/tui-icons.test.ts covers originMark. I added software to a fixture in test/tui-take-back.test.ts, because the new field is required.

What I left out: the terminal's browse place bar still shows the generic origin icon, since it never drew a per-kind one. I also did not touch the /-/commits listing or the MCP and API output.

Try it: connect a forge as an origin, mirror one of its repositories, then open the mirror's issues page, /search?q=<name> and the terminal's Connected accounts screen.

One note on the push: the pre-push hook refused it until a commit carried a Try: line, so I added an empty commit for that.

Closes #14302

commented

A repository mirrored from another forge now shows the anvil on its thread and browse pages, in search results and in the terminal. A Gitea origin still gets the cup. Type check and the tests I ran pass; I did not run the full suite. I could not run scripts/fast.ts usefully: it found 3243 of 3741 files for this diff and estimated 273 minutes. I ran test/origins-page-shape, tui-icons, tui-take-back, forge-origin, mcp-search, commits-fit, mcp-origins, browse-origin-timing and mcp-threads instead; the forge's check runs the rest.

  • Queries: RepoOrigin in src/core/repos.ts now carries software beside kind, and the repo query selects it. Search origin hits carry originSoftware.
  • Web: thread and studio comment tags, browse and commit author tags, the scope place bar and search result rows all draw through originIcon.
  • Terminal: src/tui/ui/icons.ts gains anvil and gitea icons and an originMark mapping. The connections screen now puts that icon before each origin. The nerd-font code points for the cup (nf-md-coffee) and the anvil are my best picks and were not checked in a real terminal. Both sets keep the one-cell width rule.
  • Tests: test/origins-page-shape.test.ts covers the repo query, originGlyph and the search hit for a mirror from another forge. test/tui-icons.test.ts covers originMark. I added software to a fixture in test/tui-take-back.test.ts, because the new field is required.

What I left out: the terminal's browse place bar still shows the generic origin icon, since it never drew a per-kind one. I also did not touch the /-/commits listing or the MCP and API output.

Try it: connect a forge as an origin, mirror one of its repositories, then open the mirror's issues page, /search?q=<name> and the terminal's Connected accounts screen.

One note on the push: the pre-push hook refused it until a commit carried a Try: line, so I added an empty commit for that.

commented

<!-- look-pages 9957c2f4e44c --> Look pages for 9957c2f, from the gate:

  • look pages (inferred): this pull changes src/web/pages/browse.ts, src/web/pages/commits.ts, src/web/pages/search.ts and 2 more; the forge pictures / (src/web/pages/thread.ts), /docs (src/web/pages/thread.ts), /explore (src/web/pages/thread.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs