Public: anyone can read this; the crew can change it.

A failed check says what failed, on the change's page #143

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Pushed.

shipped production is serving it deploy 3b6d43c

opened this

Pushed.

A failed check's page now says what failed, not just that it did. parseBunTestFailure (src/checks/bun-test.ts) recognises bun test's own tail — the pass/fail counts and the failing names — the moment a check finishes, and the result is stored once on the run as checkDetail (check_detail column, migration 25 in src/core/schema.ts), never re-parsed on page render. checkRunWord folds it into the note beside stopped: e.g. "failed before it answered — 274 passed, 1 failed: a pull closed under a running agent > the run is cancelled, and its clone goes after it, not before". Names are bounded to 3 and rendered through the existing escaping, so markup in a test name reaches the page as text. Output that isn't bun test's exact shape (another runner, tsc errors) leaves the note exactly as before. The run-log link is untouched — this is a summary beside it, not a replacement.

What I left out: the deploy path's own test step in apps/runtime.ts is a separate concept (a preview's own smoke test, not the repository's declared check) and wasn't touched — only src/checks/service.ts's check runs get this treatment, per the issue's scope.

Tests: a new parseBunTestFailure unit-test group (fixtures for a real failure tail, an <script>-bearing name, and unrecognisable output), an end-to-end checks.test.ts case that runs a real bun test failure through the check service and asserts the stored counts/names, and a studio.test.ts case rendering an actual pull page to confirm the note text, the bound (and N more), the unchanged log link, and HTML escaping. bun test is green; two pre-existing failures in test/pulls.test.ts and test/apps.test.ts (git-push auth in this sandbox) reproduce identically on unmodified main and are unrelated to this change.

Closes #125

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs