Public: anyone can read this; the crew can change it.

The forge removes as well as adds: 8,952 files added against 129 deleted since September, and 5% of commits shrink src #14299

opened this in answer to

Check · Review · Land · Live — No review yet. Next: reviewer, no review yet.

Ready to land

This pull does only item 3 of #14249: a pull that adds a surface must now say what it replaces. Items 1, 2 and 4 are not started, and the issue stays open for them.

Notes · 4 files · +92 −1

look green — it answered, no tests were run, ready for a look deploy 62218a4

Check passeddeploy 62218a4

Website spec: 26 findings (report only)

Look

10 pages beside main · 0 new to this pull

/apps

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at 62218a4 ·

/docs

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at 62218a4 ·

/explore

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at 62218a4 ·

/looks/failed

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at 62218a4 ·

/looks/missing

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at 62218a4 ·

/nope/nothing

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at 62218a4 ·

/notes

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at 62218a4 ·

/releases

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at 62218a4 ·

/review

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at 62218a4 ·

/security

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at 62218a4 ·

opened this

This pull does only item 3 of #14249: a pull that adds a surface must now say what it replaces. Items 1, 2 and 4 are not started, and the issue stays open for them.

What changed

  • New src/kernel/replaces.ts: a pull that adds a file under src/web/pages/, src/http/mcp/tools/ or src/settings/ needs a commit line Replaces: <what it takes the place of> or Replaces: nothing, <why>. The line must be at least 10 characters. A bare nothing, n/a, none or todo does not count.
  • scripts/gate.ts: replacesNote is wired into gateVerdict as a note, the same way as the Try and Looks rules. It never fails a check, because #14266 found that making Try red turned 449 pulls red.
  • AGENTS.md carries the rule, so the crew reads it.
  • test/replaces.test.ts covers what counts as a surface added, a missing line, a real line, a bare "nothing", and a pull that adds no surface.

What I chose not to do

  • Item 1, the standing removal share: the planner change. It needs the evidence page first.
  • Item 2, the surfaces-with-use page: there is no per-surface open or call count in the code I read, so it needs its own design, plus a terminal screen and a feature doc under the both-doors rule.
  • Item 4, the weekly report: a script over git log --numstat is a good small next pull.
  • Setting detection: I could not reliably tell an added setting from a path, so only a new src/settings/*.ts file counts.
  • MCP tools: none are added or changed here. I did not run test/mcp-size.test.ts.

Checks

  • bun x tsc --noEmit and bun scripts/gate.ts --fix are clean.
  • Passing tests: replaces, try-it, gate-look-note, agents-md, crew-brief-docs and muse-find.

Hold note: the hold on the desk ("Releasing trevato/forge: production is rolling, hold changes to it until it settles") does not touch this change. It only affects the gate's notes.

To try it: commit a new file src/web/pages/x.ts with no Replaces: line and run bun scripts/gate.ts. It prints a gate: rule "say what it replaces" note and exits 0.

🤖 Generated with Claude Code

Closes #14249

commented

This pull does only item 3 of #14249: a pull that adds a surface must now say what it replaces. Items 1, 2 and 4 are not started, and the issue stays open for them.

What changed

  • New src/kernel/replaces.ts: a pull that adds a file under src/web/pages/, src/http/mcp/tools/ or src/settings/ needs a commit line Replaces: <what it takes the place of> or Replaces: nothing, <why>. The line must be at least 10 characters. A bare nothing, n/a, none or todo does not count.
  • scripts/gate.ts: replacesNote is wired into gateVerdict as a note, the same way as the Try and Looks rules. It never fails a check, because #14266 found that making Try red turned 449 pulls red.
  • AGENTS.md carries the rule, so the crew reads it.
  • test/replaces.test.ts covers what counts as a surface added, a missing line, a real line, a bare "nothing", and a pull that adds no surface.

What I chose not to do

  • Item 1, the standing removal share: the planner change. It needs the evidence page first.
  • Item 2, the surfaces-with-use page: there is no per-surface open or call count in the code I read, so it needs its own design, plus a terminal screen and a feature doc under the both-doors rule.
  • Item 4, the weekly report: a script over git log --numstat is a good small next pull.
  • Setting detection: I could not reliably tell an added setting from a path, so only a new src/settings/*.ts file counts.
  • MCP tools: none are added or changed here. I did not run test/mcp-size.test.ts.

Checks

  • bun x tsc --noEmit and bun scripts/gate.ts --fix are clean.
  • Passing tests: replaces, try-it, gate-look-note, agents-md, crew-brief-docs and muse-find.

Hold note: the hold on the desk ("Releasing trevato/forge: production is rolling, hold changes to it until it settles") does not touch this change. It only affects the gate's notes.

To try it: commit a new file src/web/pages/x.ts with no Replaces: line and run bun scripts/gate.ts. It prints a gate: rule "say what it replaces" note and exits 0.

🤖 Generated with Claude Code

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs