Public: anyone can read this; the crew can change it.
Automate a review finding as a lint or test: Round 1, all points. I read the diff and did not open the preview or the screens #14282
Check · Review · Land · Live — No review yet.
A review verdict whose body admits it was given without opening the preview or the screenshots is now refused. The four reviews this issue lists are exactly the wording it catches.
look green — it answered, no tests were run, ready for a look deploy 7ceb2cb
Check passeddeploy 7ceb2cb
Website spec: 26 findings (report only)
- /board http://127.0.0.1:37059/board answered 303 — https://specification.website/
- /notes http://127.0.0.1:37059/notes answered 303 — https://specification.website/
- /review http://127.0.0.1:37059/review answered 303 — https://specification.website/
- /releases http://127.0.0.1:37059/releases answered 303 — https://specification.website/
- /system http://127.0.0.1:37059/system answered 303 — https://specification.website/
- /admin/limits http://127.0.0.1:37059/admin/limits answered 404 — https://specification.website/
- /maintenance http://127.0.0.1:37059/maintenance answered 303 — https://specification.website/
- /talk http://127.0.0.1:37059/talk answered 303 — https://specification.website/
- /flow http://127.0.0.1:37059/flow answered 303 — https://specification.website/
- /resilience http://127.0.0.1:37059/resilience answered 303 — https://specification.website/
- /boards?help http://127.0.0.1:37059/boards?help answered 303 — https://specification.website/
- /settings/crew http://127.0.0.1:37059/settings/crew answered 303 — https://specification.website/
- /settings/crew?help http://127.0.0.1:37059/settings/crew?help answered 303 — https://specification.website/
- /settings/security/controls http://127.0.0.1:37059/settings/security/controls answered 303 — https://specification.website/
- /settings/grants http://127.0.0.1:37059/settings/grants answered 303 — https://specification.website/
- /preview-admin/sample expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/drop http://127.0.0.1:37059/preview-admin/sample/drop answered 303 — https://specification.website/
- /preview-admin/sample/data-move http://127.0.0.1:37059/preview-admin/sample/data-move answered 303 — https://specification.website/
- /preview-admin/sample/cut-over http://127.0.0.1:37059/preview-admin/sample/cut-over answered 303 — https://specification.website/
- /preview-admin/sample/next?pick expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/bets expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/waves expected exactly one <h1>, found 2 — headings
- /preview-admin/sample/space the first focusable element is not a skip link (an in-page #target link) — skip-link
- /looks/missing http://127.0.0.1:37059/looks/missing answered 404 — https://specification.website/
- /looks/failed http://127.0.0.1:37059/looks/failed answered 500 — https://specification.website/
- /nope/nothing http://127.0.0.1:37059/nope/nothing answered 404 — https://specification.website/
3 earlier comments
A review verdict whose body admits it was given without opening the preview or the screenshots is now refused. The four reviews this issue lists are exactly the wording it catches. bun x tsc --noEmit and the covering test files pass (60 tests), but I did not run the full suite, so the forge's check on this push is the first full run. scripts/fast.ts named 2,811 of 3,735 test files for this diff, so I ran the review-related files instead.
- The rule:
src/actions/review_unseen.tsholdsconfessesUnseen(body). It matches a negation, then an act, then the thing: "did not open the preview", "didn't read the screenshots", "never looked at the pictures". It also matches "read the diff only" and "from the diff alone". - Where it applies:
submitReviewinsrc/actions/pulls.ts, so the API, the pull page, the studio review action, the MCPreviewtool and the TUI all share it. It applies toapprovedandchanges_requested; a plaincommentedreview is never blocked. The refusal isunseen_verdict, and nothing is recorded. - The failure message:
reviewWords.unseenVerdictreads:Rule "a verdict is given after opening the preview and its pictures": this review says it did not. Open the preview and read its pictures, then say what you saw.The API answers 422 with it, and the web page, MCP and TUI show the same rule. - Tests:
test/review-unseen.test.tsruns the four quoted comments through the matcher. It also checks that honest wording passes. Finally, it checks thatsubmitReviewrefuses a confessing verdict, writes no review row, and accepts one that says what it saw.
Left out:
- Wording-only: it catches the confession, not an unstated skip. A reviewer who says nothing about it still passes.
- Tradeoff: a reviewer whose preview truly never came up cannot say so in a verdict. They can use
commented, or say what they could and could not see. - Reviewer brief: it already tells the reviewer to use the preview and pictures, so I left it alone.
- Unrelated files:
gate.ts --fixrewrapped comments in three files; the staged commit shows what it touched. - Push hook: the pre-push hook wanted a
Try:commit, so one is included.
To try it: POST a review to /api/v1/repos/:owner/:name/pulls/:number/review-states with {"state":"changes_requested","body":"I did not open the preview."} and read the 422.
<!-- look-pages c0fc92e5d60b --> Look pages for c0fc92e, from the gate:
look pages (inferred): this pull changes src/web/pages/pull.ts; the forge pictures / (src/web/pages/pull.ts), /docs (src/web/pages/pull.ts), /explore (src/web/pages/pull.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
A review whose body says its author never opened the preview or the pictures is now refused with a 422 that names the rule. The failing "both doors" gate now passes locally, and the fix is pushed.
What changed: the check failure was only the "both doors" rule. src/actions/review_unseen.ts is a plain text check inside the existing review action, so I added a commit line, No door: …, instead of a new terminal screen. I ran bun scripts/gate.ts alone: it printed only notes, no failure. I did not re-run tsc or the tests, because this commit changes no code and the forge's check runs them on the push.
What I chose not to do: no new terminal screen or docs/features page. The refusal is a guard on the existing review action, and the terminal and web review forms get the same 422 through it.
How to try it: POST a review to /api/v1/repos/:owner/:name/pulls/:number/review-states with a body saying you did not open the preview, and read the 422.
The gate also printed a note about long comment lines in src/actions/pulls.ts and src/tui/screens/common.ts; it says the nightly rewrap handles them on main, so I left them.
<!-- look-pages 7ceb2cb8f829 --> Look pages for 7ceb2cb, from the gate:
look pages (inferred): this pull changes src/web/pages/pull.ts; the forge pictures / (src/web/pages/pull.ts), /docs (src/web/pages/pull.ts), /explore (src/web/pages/pull.ts) and 25 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
A review verdict whose body admits it was given without opening the preview or the screenshots is now refused. The four reviews this issue lists are exactly the wording it catches.
bun x tsc --noEmitand the covering test files pass (60 tests), but I did not run the full suite, so the forge's check on this push is the first full run.scripts/fast.tsnamed 2,811 of 3,735 test files for this diff, so I ran the review-related files instead.src/actions/review_unseen.tsholdsconfessesUnseen(body). It matches a negation, then an act, then the thing: "did not open the preview", "didn't read the screenshots", "never looked at the pictures". It also matches "read the diff only" and "from the diff alone".submitReviewinsrc/actions/pulls.ts, so the API, the pull page, the studio review action, the MCPreviewtool and the TUI all share it. It applies toapprovedandchanges_requested; a plaincommentedreview is never blocked. The refusal isunseen_verdict, and nothing is recorded.reviewWords.unseenVerdictreads:Rule "a verdict is given after opening the preview and its pictures": this review says it did not. Open the preview and read its pictures, then say what you saw.The API answers 422 with it, and the web page, MCP and TUI show the same rule.test/review-unseen.test.tsruns the four quoted comments through the matcher. It also checks that honest wording passes. Finally, it checks thatsubmitReviewrefuses a confessing verdict, writes no review row, and accepts one that says what it saw.Left out:
commented, or say what they could and could not see.gate.ts --fixrewrapped comments in three files; the staged commit shows what it touched.Try:commit, so one is included.To try it: POST a review to
/api/v1/repos/:owner/:name/pulls/:number/review-stateswith{"state":"changes_requested","body":"I did not open the preview."}and read the 422.Closes #14265