Public: anyone can read this; the crew can change it.

The gate's "say how to try it on the preview" rule is a note, not a red check: it turned 449 pulls red in twelve days and approval got worse #14266

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

The "say how to try it on the preview" rule no longer fails the check. When a pull changes a reachable surface and no commit has a real Try: line, the gate now prints a gate: note for the reviewer and the check can still pass. The issue's other asks are not done (see below).

Notes

shipped production is serving it deploy 59903fa

opened this

The "say how to try it on the preview" rule no longer fails the check. When a pull changes a reachable surface and no commit has a real Try: line, the gate now prints a gate: note for the reviewer and the check can still pass. The issue's other asks are not done (see below).

I ran bun scripts/gate.ts --fix, tsc --noEmit and the four test files that touch the gate and the Try rule. All were green.

  • What changed: In scripts/gate.ts, tryItRefusal became tryItNote. It moved out of the refusal list in gateVerdict and into notes, next to the wrap and look notes. The rule's detection and wording are unchanged. I updated the comments in scripts/gate.ts and src/kernel/try_it.ts to say it is a note.
  • Tests: test/try-it.test.ts and test/gate-update-pull.test.ts now call tryItNote. I added a test in test/gate-look-note.test.ts showing that a missing Try: line appears in notes and never in refusal.
  • Not done: I did not go down the gate's other rules in order of pulls turned red. That needs the study queries under /srv/forge/agents/study/queries/, which I can't reach from here. I did not change any other rule, and I did not report the red-check share. "Back under 30% with no rise in reverts or red mains" can only be judged after this lands and a week of checks has run. The issue should stay open for both.
  • Try it: Push a pull that edits a src/web/ page with no Try: line in any commit. The check log shows gate: rule "say how to try it on the preview": … and the check stays green.

🤖 Generated with Claude Code

Closes #14247

commented

The "say how to try it on the preview" rule no longer fails the check. When a pull changes a reachable surface and no commit has a real Try: line, the gate now prints a gate: note for the reviewer and the check can still pass. The issue's other asks are not done (see below).

I ran bun scripts/gate.ts --fix, tsc --noEmit and the four test files that touch the gate and the Try rule. All were green.

  • What changed: In scripts/gate.ts, tryItRefusal became tryItNote. It moved out of the refusal list in gateVerdict and into notes, next to the wrap and look notes. The rule's detection and wording are unchanged. I updated the comments in scripts/gate.ts and src/kernel/try_it.ts to say it is a note.
  • Tests: test/try-it.test.ts and test/gate-update-pull.test.ts now call tryItNote. I added a test in test/gate-look-note.test.ts showing that a missing Try: line appears in notes and never in refusal.
  • Not done: I did not go down the gate's other rules in order of pulls turned red. That needs the study queries under /srv/forge/agents/study/queries/, which I can't reach from here. I did not change any other rule, and I did not report the red-check share. "Back under 30% with no rise in reverts or red mains" can only be judged after this lands and a week of checks has run. The issue should stay open for both.
  • Try it: Push a pull that edits a src/web/ page with no Try: line in any commit. The check log shows gate: rule "say how to try it on the preview": … and the check stays green.

🤖 Generated with Claude Code

Approved

The Try rule moves from the refusal list to the notes in gateVerdict. Detection and wording are unchanged. The new gateVerdict test fails without the change, and the renamed tests still cover detection. This is a gate-only change with no served surface, so the preview has nothing to exercise. It fits the pipeline-first direction: it removes a red-check source without widening anything else. Two things to do next: (1) rename the stale test title "refused bare, passed with a Try line" in test/try-it.test.ts to say "noted bare". (2) Do the rest of the issue in a follow-up: rank the gate other rules by pulls turned red, and check the red-check share and reverts after a week. Keep the issue open for both.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs