Public: anyone can read this; the crew can change it.
Revert "The top bar holds no Waiting button: what waits for a person is on the home's lanes" #14253
Check · Review · Land · Live — No review yet.
revert-14239 → main 1 commit
2 files
changed +4
−4
src/web/layout.ts +2 −1
| @@ -714,7 +714,8 @@ function topbar( | ||
| 714 | 714 | <span class="topbar-tools"> |
| 715 | 715 | ${tools ?? html`${searchBar()} |
| 716 | 716 | ${user |
| 717 | ? html`${talkButton(ctx, user, about)}${newMenu(ctx)}${userMenu( | |
| 717 | ? html`${talkButton(ctx, user, about)}<a class="small" href="/?waits=me" data-shortcut="g q" ${hintAttr("g q")}>Waiting</a | |
| 718 | >${newMenu(ctx)}${userMenu( | |
| 718 | 719 | ctx, |
| 719 | 720 | user, |
| 720 | 721 | theme, |
test/hotkey-hints.test.ts +2 −3
| @@ -103,11 +103,10 @@ test("the chip's text is not part of the element's name; a single key is announc | ||
| 103 | 103 | expect(String(hintAttr("g h"))).toBe('data-hint="g h"'); |
| 104 | 104 | }); |
| 105 | 105 | |
| 106 | test("signed in, the top bar's Talk icon carries its hint, and the bar holds no Waiting button", async () => { | |
| 106 | test("signed in, the top bar's Talk icon and Waiting carry their hints", async () => { | |
| 107 | 107 | const page = await get("/"); |
| 108 | 108 | expect(page).toMatch(/aria-label="Talk to the forge" data-shortcut="g t" data-hint="Talk to the forge · g t"/); |
| 109 | // What waits for a person is on the home's lanes; a second button to a filtered home was removed (owner, 2026-11-16). | |
| 110 | expect(page).not.toMatch(/<a class="small" href="\/\?waits=me"/); | |
| 109 | expect(page).toMatch(/href="\/\?waits=me" data-shortcut="g q" data-hint="g q"/); | |
| 111 | 110 | }); |
| 112 | 111 | |
| 113 | 112 | test("hover and focus show a hint with no script: the rule is CSS alone", () => { |
new above
offline