Public: anyone can read this; the crew can change it.

Revert "The top bar holds no Waiting button: what waits for a person is on the home's lanes" #14253

opened this

Check · Review · Land · Live — No review yet. Next: reviewer, no review yet.

Ready to land

revert-14239 → main 1 commit

Review

Sign in to review this change.
2 files changed +4 −4
src/web/layout.ts +2 −1
@@ -714,7 +714,8 @@ function topbar(
714714 <span class="topbar-tools">
715715 ${tools ?? html`${searchBar()}
716716 ${user
717 ? html`${talkButton(ctx, user, about)}${newMenu(ctx)}${userMenu(
717 ? html`${talkButton(ctx, user, about)}<a class="small" href="/?waits=me" data-shortcut="g q" ${hintAttr("g q")}>Waiting</a
718 >${newMenu(ctx)}${userMenu(
718719 ctx,
719720 user,
720721 theme,
test/hotkey-hints.test.ts +2 −3
@@ -103,11 +103,10 @@ test("the chip's text is not part of the element's name; a single key is announc
103103 expect(String(hintAttr("g h"))).toBe('data-hint="g h"');
104104 });
105105
106 test("signed in, the top bar's Talk icon carries its hint, and the bar holds no Waiting button", async () => {
106 test("signed in, the top bar's Talk icon and Waiting carry their hints", async () => {
107107 const page = await get("/");
108108 expect(page).toMatch(/aria-label="Talk to the forge" data-shortcut="g t" data-hint="Talk to the forge · g t"/);
109 // What waits for a person is on the home's lanes; a second button to a filtered home was removed (owner, 2026-11-16).
110 expect(page).not.toMatch(/<a class="small" href="\/\?waits=me"/);
109 expect(page).toMatch(/href="\/\?waits=me" data-shortcut="g q" data-hint="g q"/);
111110 });
112111
113112 test("hover and focus show a hint with no script: the rule is CSS alone", () => {

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs