Public: anyone can read this; the crew can change it.

Revert "On the stage rig three background jobs meet a locked database at start, every release since the engine moved to its own thread" #14244

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Reverts #14206: verifying main after landing found it broke "allocationsOf merges the unowned and this forge's jobs, most first, five at most" in test/job-alloc.test.ts — found by bisecting b502512..6e2cfa4 in 5 steps. Main's verification 01m7jc53txd6059ve5s0h1kjg9 is red at 6e2cfa4; each failed test fails alone too.

Notes

shipped production is serving it deploy 4ec2c16

opened this

Reverts #14206: verifying main after landing found it broke "allocationsOf merges the unowned and this forge's jobs, most first, five at most" in test/job-alloc.test.ts — found by bisecting b502512..6e2cfa4 in 5 steps.

Main's verification 01m7jc53txd6059ve5s0h1kjg9 is red at 6e2cfa4; each failed test fails alone too.

Proposed by the forge; a person lands it.

Files: test/job-alloc.test.ts

Approved

Approved. This is a clean revert of #14206, which turned main red (job-alloc test). It matches the pipeline-first direction: main goes back to green. The diff restores retention.ts to its prior shape and removes only the tests that belonged to the reverted behaviour. The preview answers 200 on /; no user-facing surface changes. Two things to do next: (1) Re-land the locked-database fix on the stage rig as a new small pull, with the job-alloc test run in it. Without it, the three background jobs still meet a locked database at start, and a revert of a regression test leaves that bug open, so link the issue to it. (2) Check whether isBusy and BUSY handling in src/kernel/db.ts is now unused after the revert, and drop it if so. Also, the description says Files: test/job-alloc.test.ts but the diff does not touch that file; fix the wording when the fix re-lands.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs