Public: anyone can read this; the crew can change it.

Revert "A forge link that is about to expire says so to its owner, and renews in one tap" #14217

opened this

Check · Review · Land · Live — No review yet. Next: reviewer, no review yet.

Ready to land

Reverts #14175: verifying main after landing found it broke "proveHosted > a whole hosted forge restores and reports its name, repositories and bytes" and 1 more in test/drill-hosted-proof.test.ts, test/quotas-storage.test.ts — found by bisecting 201e62e..5b502f7 in 6 steps.

Notes · 7 files · +12 −79

look green — it answered, no tests were run, ready for a look deploy 6bcfde6

Check passeddeploy 6bcfde6

Website spec: 26 findings (report only)
opened this

Reverts #14175: verifying main after landing found it broke "proveHosted > a whole hosted forge restores and reports its name, repositories and bytes" and 1 more in test/drill-hosted-proof.test.ts, test/quotas-storage.test.ts — found by bisecting 201e62e..5b502f7 in 6 steps.

Main's verification 01m7j603sfecehdhmcs96tada3 is red at 5b502f7; each failed test fails alone too.

Proposed by the forge; a person lands it.

Files: test/drill-hosted-proof.test.ts, test/quotas-storage.test.ts

commented

<!-- look-pages 6bcfde6e8e46 --> Look pages for 6bcfde6, from the gate:

  • look pages (none): this pull changes src/web/pages/forges.ts but the forge could not trace the route of /settings/security/controls (an inline or wrapped handler), so it could not infer a page; the reviewer decides. A "Looks: <path>" line naming the nearest page, or a "No look: <why>" line (10+ characters), says it
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs