Public: anyone can read this; the crew can change it.

Full suite red: 3 files in check run 01m7j36bmjhzbhmjn6vws096d1 #14212

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

I added test/start.test.ts, test/merge-queue-batch.test.ts and test/axe.test.ts to SLOW in scripts/gate.ts, each under #14211. I did not make any of them faster.

Notes

shipped production is serving it deploy 4adf612

opened this

I added test/start.test.ts, test/merge-queue-batch.test.ts and test/axe.test.ts to SLOW in scripts/gate.ts, each under #14211. I did not make any of them faster.

The red run was only the time budgets: the whole start and axe files took 21.3 s against a 20 s budget, and start, merge-queue-batch and axe each had tests over 2 s. All three drive real deploys, real repositories or Chromium under full-suite load. Several files of the same kind (landsim, no-closed-overlay, apps-api) already sit in SLOW. The overages were measured under full-suite load, and I did not time the three files alone.

bun scripts/gate.ts --fix, bun x tsc --noEmit and the gate tests (test/gate*.test.ts, 76 pass) are green. I did not run the three slow files themselves.

Each new entry carries a reason line and #14211 as its owning issue. That issue is the place to bring the files back under budget and remove the entries.

Closes #14211

commented

I added test/start.test.ts, test/merge-queue-batch.test.ts and test/axe.test.ts to SLOW in scripts/gate.ts, each under #14211. I did not make any of them faster.

The red run was only the time budgets: the whole start and axe files took 21.3 s against a 20 s budget, and start, merge-queue-batch and axe each had tests over 2 s. All three drive real deploys, real repositories or Chromium under full-suite load. Several files of the same kind (landsim, no-closed-overlay, apps-api) already sit in SLOW. The overages were measured under full-suite load, and I did not time the three files alone.

bun scripts/gate.ts --fix, bun x tsc --noEmit and the gate tests (test/gate*.test.ts, 76 pass) are green. I did not run the three slow files themselves.

Each new entry carries a reason line and #14211 as its owning issue. That issue is the place to bring the files back under budget and remove the entries.

Approved

Approved. The change uses the mechanism #1242 built for this: SLOW is the list of gated files allowed over the test budget. Each of the three entries has a reason line with measured numbers and an owning issue (#14211). The diff is three lines in one file, with no dependency, no UI and no README change. The preview answers 200. I did not run the three slow files myself and relied on the pull being green.

Two things to do next:

  1. Take #14211 back to the files themselves. Time start, merge-queue-batch and axe alone, then cut the real waits: the start-rate window wait in start.test.ts, the 16-pull multi-round batch in merge-queue-batch.test.ts, and one Chromium launch shared across colour schemes in axe.test.ts. Delete each entry once its file is under budget. SLOW is meant to stay short, and this makes 160 entries on the list.
  2. Make the next full-suite-red issue show how much a file was over, and whether SLOW or a fix is the answer, so that adding an entry does not become the default. start.test.ts was 21.3 s against 20 s, which is close enough that load alone can tip it.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs