Public: anyone can read this; the crew can change it.
A wave page says how long the wave took, from its first issue opened to its last pull landed #14162
Check · Review · Land · Live done — Landed and live in production.
A wave page and the MCP waves answer for one wave now say how long the wave took, or how long it has been open, in the same words. New tests, the type check, the design lint and the MCP size, waves and landed tests pass. I did not run the full suite; the forge's check does.
shipped production is serving it deploy 7c29c34
7 earlier comments
The terminal wave screen now shows how long the wave took, and waveStart no longer queries once per pull. scripts/gate.ts --fix and tsc --noEmit came back clean. test/tui-waves.test.ts and test/wave-duration.test.ts pass (22 tests). I ran only those two files, not the wider suite.
- Terminal door: the wave screen shows the same
took N days/open for N daysline, built bywaveDurationover the viewer-filtered pulls, as the page and the MCP do. The screen already hadf.db, so no new wiring was needed. A new test intest/tui-waves.test.tscovers it. The earlier "No door" commit line is superseded. - Doc:
docs/features/wave-duration.mddescribes the line and where it comes from. - Batching:
waveStartlooks the repo up once per owner and name. It then runs oneIN (...)query for the wave's pulls and one for the issues they close, so two queries per repo however many pulls. - Ordering: earliest-start comparison now uses
Date.parse, so mixed timestamp formats cannot misorder it.
To try it, open a repository's /waves/<version> page and read the version line, or open the same wave in the terminal waves screen.
🤖 Generated with Claude Code
<!-- look-pages d13fb773aefc --> Look pages for d13fb77, from the gate:
look pages (inferred): this pull changes src/web/pages/waves.ts; the forge pictures /preview-admin/sample/waves (src/web/pages/waves.ts), the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
This is the gate's automatic look-pages note again, and it asks for no change. I made no commit and pushed nothing.
The inferred page, /preview-admin/sample/waves, is the one this pull changes. No Looks: or No look: override is needed.
🤖 Generated with Claude Code
I pushed an empty commit with a Direction: line, and bun scripts/gate.ts now passes locally. No code changed, so I did not re-run tsc or the tests.
The "pipeline first" rule fires because the pull adds docs/features/wave-duration.md and changes nothing under scripts/, src/flow/, src/nightly/, src/checks/ or forge.json. I chose the Direction: override over touching the pipeline. Issue #14128 asks for the wave duration and nothing about the pipeline, so a pipeline edit here would be unrelated. The line says so, and a reviewer can disagree with it there.
The pull is otherwise as before. The wave page, the terminal waves screen and the MCP show took N days or open for N days, and waveStart is batched to two queries per repo.
🤖 Generated with Claude Code
<!-- look-pages 19b80a42847d --> Look pages for 19b80a4, from the gate:
look pages (inferred): this pull changes src/web/pages/waves.ts; the forge pictures /preview-admin/sample/waves (src/web/pages/waves.ts), the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
The wave-duration note had no row in the features index, which caused two of the three failures. I added the row to docs/features/README.md and pushed.
- Orphan and index tests: both now pass locally in
test/feature-orphans.test.ts. - Fast-forward test: "a fast-forward applies the previewed id: a parent that moved after it is not taken" passes when run alone (
test/take-expect.test.ts, 5 of 5). It ran in 108 ms in the check, and this pull touches nothing near it, so I think it was a timing flake under load. I did not change anything for it, and the forge's next run will show whether it recurs. - Not run: the full suite, since the forge runs it on the push. I ran
bun scripts/gate.ts --fixbefore pushing but did not read past the last lines of its output (the look-pages line) and did not runbun x tsc --noEmitthis time.
<!-- look-pages 22a68f979cbd --> Look pages for 22a68f9, from the gate:
look pages (inferred): this pull changes src/web/pages/waves.ts; the forge pictures /preview-admin/sample/waves (src/web/pages/waves.ts), the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
A wave's page, the MCP and the terminal's waves screen now say how long the wave took. It reads took 3 days once every change has landed and open for 3 days while one hasn't.
- How it's counted: it runs from the earliest opening of an issue in the wave (its pulls' own and the issues they close) to the last pull landed. Whole days are rounded down, and under a day reads
less than a day. - Visibility and cost: only pulls the reader may see are counted. A wave with no visible change says nothing.
waveDurationinsrc/story/wave_duration.tsbuilds the words once for all three places and reads issue times in two queries per repository. - Not done: no pipeline code is touched.
- Last push: it added the missing row for
wave-duration.mdindocs/features/README.md, which fixed the two orphan/index tests. "a fast-forward applies the previewed id: a parent that moved after it is not taken" passed when I ran it alone and looks like a load flake. I haven't seen the forge's rerun yet. - Latest feedback: the gate comment only lists the look page,
/preview-admin/sample/waves. It asks for no change, so I pushed nothing new. - Release hold: the note says production is rolling and changes to it should wait. This pull only deploys a preview and a person merges it, so I changed nothing for it. Please hold the merge until the release settles.
To try it, open /waves/<version> on a repository in the preview at https://lab--14162--forge-trevato-apps.open-platform.sh and read the duration on the version line.
Earlier asks are met: the terminal door now shows the same words, waveStart is batched to two queries per repo, the features index row is added, and nothing was added to README.md. Only the viewer-visible pulls are counted, and the issues read are in the same repo as those pulls, so nothing leaks. Output is escaped through html and the words are the same on the page, the MCP and the terminal. Tests cover closed, open, no-landings and no-changes waves on the page and the MCP, plus the terminal line. Non-blocking: the terminal test only checks that a passed-in string is rendered; a test through wavesScreen would also pin the wiring. Non-blocking: this is a feature ahead of the pipeline list; the Direction line in the commit says why it is kept small and separate.
A wave page and the MCP
wavesanswer for one wave now say how long the wave took, or how long it has been open, in the same words. New tests, the type check, the design lint and the MCP size, waves and landed tests pass. I did not run the full suite; the forge's check does.src/story/wave_duration.ts.data-wave-durationspan on the version line. The MCPwavesanswer for one wave gets a shorttookfield, andtest/mcp-size.test.tspasses.test/wave-duration.test.tscovers a closed wave, an open wave, a wave with no landings and a wave with no changes, on both the page and the MCP.chapters.tsis untouched, because waves here are story files rather than chapters. Days are whole days rounded down, with "less than a day" below one./<owner>/<repo>/waves/<version>and read the version line, or call the MCPwavestool with aversion.The pre-push hook refused the first push because no commit said how to try the change. I added an empty "Try:" commit to satisfy it.
Closes #14128