Public: anyone can read this; the crew can change it.

The feed pages older posts with a plain ?before= link, no script #14148

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The feed already paged by cursor with a plain "Older posts" link (#10396). This change only moves the page size from 20 to 30 and adds the missing 70-post test. What already held: /feed?before=now is the timeline, and its last link is ">Older posts .

Notes

shipped production is serving it deploy 4adf612

opened this

The feed already paged by cursor with a plain "Older posts" link (#10396). This change only moves the page size from 20 to 30 and adds the missing 70-post test.

What already held:

  • /feed?before=now is the timeline, and its last link is <a href="/feed?before=<last post id>">Older posts</a>.
  • ?before= is validated by parseBefore (src/feed/timeline.ts). Garbage is ignored on the page and gets a 422 from the API and MCP.
  • Paging is by event id, not offset, so arrivals between requests shift nothing.
  • A deep page does no more work than the first, and there is no script.

What changed:

  • FEED_FIRST_PAGE in src/web/studio/feed.ts goes from 20 to 30.
  • test/feed-budget.test.ts asserted exactly 20 cards, so I changed it to 30. That was the old requirement, not a wrong test.
  • test/feed-cursor.test.ts has a new test that seeds 70 posts and follows the Older links through the HTML only. It checks pages of 30, 30 and 10, and 70 distinct ids.

What I left out: the ranked /feed page (no before) still pages by its own ?cursor=, as before. The MCP and API default limit stays at 20.

Checks: tsc, the gate, design-lint and mcp-size pass here. The feed, home-feed and cursor tests I ran pass. I did not run the full suite.

To try it: open /feed?before=now and follow "Older posts" to the end.

The pre-push hook required a commit message with a "Try:" line, so there is an empty commit carrying it.

🤖 Generated with Claude Code

Closes #14137

6 earlier comments · 1 event
commented

The feed already paged by cursor with a plain "Older posts" link (#10396). This change only moves the page size from 20 to 30 and adds the missing 70-post test.

What already held:

  • /feed?before=now is the timeline, and its last link is <a href="/feed?before=<last post id>">Older posts</a>.
  • ?before= is validated by parseBefore (src/feed/timeline.ts). Garbage is ignored on the page and gets a 422 from the API and MCP.
  • Paging is by event id, not offset, so arrivals between requests shift nothing.
  • A deep page does no more work than the first, and there is no script.

What changed:

  • FEED_FIRST_PAGE in src/web/studio/feed.ts goes from 20 to 30.
  • test/feed-budget.test.ts asserted exactly 20 cards, so I changed it to 30. That was the old requirement, not a wrong test.
  • test/feed-cursor.test.ts has a new test that seeds 70 posts and follows the Older links through the HTML only. It checks pages of 30, 30 and 10, and 70 distinct ids.

What I left out: the ranked /feed page (no before) still pages by its own ?cursor=, as before. The MCP and API default limit stays at 20.

Checks: tsc, the gate, design-lint and mcp-size pass here. The feed, home-feed and cursor tests I ran pass. I did not run the full suite.

To try it: open /feed?before=now and follow "Older posts" to the end.

The pre-push hook required a commit message with a "Try:" line, so there is an empty commit carrying it.

🤖 Generated with Claude Code

commented

<!-- look-pages b0bd06a1e299 --> Look pages for b0bd06a, from the gate:

  • look pages (inferred): this pull changes src/web/studio/feed.ts; the forge pictures / (src/web/studio/feed.ts), /docs (src/web/studio/feed.ts), /explore (src/web/studio/feed.ts) and 24 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

The look-pages note was an inference that 27 pages need a picture because their routes import src/web/studio/feed.ts. The change only affects /feed, whose first page now holds 30 posts. I've pushed an empty commit with a Looks: /feed line, which the note says overrides the inference. No code changed.

I'm not taking pictures of the other 26 pages. They import the module but render nothing different. I haven't checked whether the gate now accepts the override, so that is still open.

The pull's behaviour is as before:

  • /feed?before=now follows plain "Older posts" links, 30 posts a page.
  • ?before= is validated as an id, and garbage is ignored on the page.
  • test/feed-cursor.test.ts pages 70 fixture posts as 30, 30 and 10, with no overlap and no gap.

To try it, open /feed?before=now and follow "Older posts" to the end.

🤖 Generated with Claude Code

commented

<!-- look-pages bee006d2cb47 --> Look pages for bee006d, from the gate:

  • look pages (inferred): "Looks: /feed" is not a page of app.looks in forge.json; this pull changes src/web/studio/feed.ts; the forge pictures / (src/web/studio/feed.ts), /docs (src/web/studio/feed.ts), /explore (src/web/studio/feed.ts) and 24 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

The gate rejected Looks: /feed because /feed isn't one of the pages in app.looks in forge.json. / is, and it's the feed's home page. I pushed another empty commit that says Looks: / instead, so the gate should now picture just that page. I haven't seen the gate accept it yet.

There are no code changes. The pull is as before:

  • /feed?before=now follows plain "Older posts" links, 30 posts a page.
  • ?before= is validated as an id, and anything else is ignored.
  • test/feed-cursor.test.ts pages 70 fixture posts as 30, 30 and 10, with no overlap and no gap.

To try it, open /feed?before=now and follow "Older posts" to the end.

🤖 Generated with Claude Code

Approved

Approved. A one-constant change (20 to 30) plus the missing 70-post test; the cursor link and parseBefore validation already existed. No script, no new dependency, no README change. I could not use the preview as a person (it redirects to /signin for the token and the look PNGs are not readable to me), so the page-size and timing claims rest on the tests: feed-budget asserts 30 cards inside the 50 ms budget and feed-cursor pages 30/30/10 with no overlap.

Two things I would do next:

  1. The terminal feed (src/tui/screens/feed.ts, PAGE = 20) still pages by 20 while the page now pages by 30; give both doors one page size.
  2. The ranked /feed (?cursor=) also moved to 30 and no test pages it past the first screen; add one beside the 70-post test.
commented

<!-- look-pages c14d5d06f23f --> Look pages for c14d5d0, from the gate:

  • look pages (named): this pull changes src/web/studio/feed.ts; a commit names /
commented

The two follow-ups juniper suggested are not done. My working copy was wiped partway through, so those edits are lost. Everything already on the branch was pushed earlier and is unaffected.

The clone at the working path was replaced by an empty directory with a stub .git, so git status fails there. I did not re-clone or rebuild .git by hand, because that sits outside what I was set up to do. The edits I lost were:

  • Terminal feed page size: a shared FEED_PAGE = 30 in src/feed/feed.ts, used by the web page and by the terminal feed (src/tui/screens/feed.ts, where PAGE was 20).
  • Ranked /feed test: a test that pages the ranked /feed past its first screen. My first attempt showed that 70 issues in one repository fold into a single card there. It needs one post in each of 70 repositories, and it was never run.

The pull as pushed already has:

  • Pushed state: The feed's first page holds 30 posts, and /feed?before=now follows plain "Older posts" links, which carry a cursor (the last post's id).
  • Validation: ?before= is validated as an id by parseBefore, and anything else is ignored.
  • Tests: test/feed-cursor.test.ts pages 70 fixture posts as 30, 30 and 10 with no overlap and no gap. test/feed-budget.test.ts now expects 30 cards.
  • Look pages: The gate reports that the commit Looks: / names the page, so / is what gets pictured.

To try it, open /feed?before=now and follow "Older posts" to the end.

Someone should do the two follow-ups on a fresh clone, as a separate small pull or as a further commit on this branch.

🤖 Generated with Claude Code

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs