Public: anyone can read this; the crew can change it.

The MCP changelog answer includes each wave's closing date and pull count, within the size ceilings #14096

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The MCP changelog answer (releases with shipped: true, also served by GET /api/v1/releases?shipped=true) now has a waves field. Each entry is { repo, name, closed, pulls }: closed is the closing date, or null while the wave is open, and pulls counts the pulls landed in it.

Notes

shipped production is serving it deploy 4adf612

opened this

The MCP changelog answer (releases with shipped: true, also served by GET /api/v1/releases?shipped=true) now has a waves field. Each entry is { repo, name, closed, pulls }: closed is the closing date, or null while the wave is open, and pulls counts the pulls landed in it.

tsc is clean and bun test test/mcp-size.test.ts passes unchanged, along with the changelog-chapter, releases and API releases tests. I did not run the full suite. I extended the releases tool's doc string by a few words and raised no ceiling. No other open pull held part of this, and I did not see the "production is rolling" hold touch it.

  • Source: "Wave" here means the chapters the /changelog page groups pulls under. waves is built from the same grouping, so the answer matches the page and is ordered the same way. It shows only what an anonymous reader sees, since the shipped answer is public.
  • Move: chapterEntries moved from src/web/pages/changelog.ts to src/release/chapter_groups.ts so the answer module doesn't import from web. The page re-exports it, so existing imports still work.
  • Tests: test/mcp-changelog-waves.test.ts checks that closing date, pull count, open waves and the "between chapters" bucket come out right. It also checks that the answer and the tool report waves, empty when no wave is told.
  • Not covered: I did not build a full end-to-end fixture with real merged pulls and git landings. The grouping logic is tested directly, and the answer is only checked in its empty case.
  • Push: the pre-push hook wanted a "Try:" commit, so the last commit is an empty one that says how to try it.

Try it: call releases with { "shipped": true } on a forge that has chapters and read waves.

🤖 Generated with Claude Code

Closes #14083

5 earlier comments · 1 event
commented

The MCP changelog answer (releases with shipped: true, also served by GET /api/v1/releases?shipped=true) now has a waves field. Each entry is { repo, name, closed, pulls }: closed is the closing date, or null while the wave is open, and pulls counts the pulls landed in it.

tsc is clean and bun test test/mcp-size.test.ts passes unchanged, along with the changelog-chapter, releases and API releases tests. I did not run the full suite. I extended the releases tool's doc string by a few words and raised no ceiling. No other open pull held part of this, and I did not see the "production is rolling" hold touch it.

  • Source: "Wave" here means the chapters the /changelog page groups pulls under. waves is built from the same grouping, so the answer matches the page and is ordered the same way. It shows only what an anonymous reader sees, since the shipped answer is public.
  • Move: chapterEntries moved from src/web/pages/changelog.ts to src/release/chapter_groups.ts so the answer module doesn't import from web. The page re-exports it, so existing imports still work.
  • Tests: test/mcp-changelog-waves.test.ts checks that closing date, pull count, open waves and the "between chapters" bucket come out right. It also checks that the answer and the tool report waves, empty when no wave is told.
  • Not covered: I did not build a full end-to-end fixture with real merged pulls and git landings. The grouping logic is tested directly, and the answer is only checked in its empty case.
  • Push: the pre-push hook wanted a "Try:" commit, so the last commit is an empty one that says how to try it.

Try it: call releases with { "shipped": true } on a forge that has chapters and read waves.

🤖 Generated with Claude Code

commented

<!-- look-pages b4a87042d837 --> Look pages for b4a8704, from the gate:

  • look pages (none): this pull changes src/web/pages/changelog.ts but the forge could not trace the route of /settings/security/controls (an inline or wrapped handler), so it could not infer a page; the reviewer decides. A "Looks: <path>" line naming the nearest page, or a "No look: <why>" line (10+ characters), says it
commented

The MCP changelog answer now lists each wave with its closing date and pull count. The previous check failed only on the "both doors" gate rule, so I pushed an empty commit that carries the gate's exemption lines. I did not re-run the gate, tsc or the tests here, and the forge's check on this push is the verdict.

  • No door: the edit to src/web/pages/changelog.ts only moves the wave grouping into src/release/chapter_groups.ts. The page shows the same lines as before, so no src/tui/ change or docs/features/ how-to is needed.
  • Looks: src/web/pages/changelog.ts. The gate could not trace the route for /settings/security/controls, so I named the page myself.
  • Behaviour: the MCP releases tool now calls with shipped: true and reads each wave's closed date and pull count. test/mcp-changelog-waves.test.ts covers this.

To try it, call the MCP changelog tool and check that each wave carries its closing date and pull count.

commented

<!-- look-pages 0a5b9d510008 --> Look pages for 0a5b9d5, from the gate:

  • look pages (none): this pull changes src/web/pages/changelog.ts but the forge could not trace the route of /settings/security/controls (an inline or wrapped handler), so it could not infer a page; the reviewer decides. A "Looks: <path>" line naming the nearest page, or a "No look: <why>" line (10+ characters), says it
commented

I pushed a commit with a No look: waiver, because this pull changes no rendered page. I have not seen whether the gate now accepts it.

The gate note said it could not trace the route for /settings/security/controls. The edit to src/web/pages/changelog.ts only moves the wave grouping into src/release/chapter_groups.ts, so the page renders the same as before and there is nothing to picture.

My earlier commit used Looks: src/web/pages/changelog.ts. That was wrong: the gate (src/kernel/look_rule.ts) only accepts a Looks: line that names a URL path listed in app.looks in forge.json. The waiver line in the new commit is No look: src/web/pages/changelog.ts only moves wave grouping into src/release/chapter_groups.ts; the rendered page is unchanged.

If you would rather have a picture of the changelog page, tell me the path from app.looks and I will name it instead.

Changes requested — before the latest push

The field works on the preview (waves: [] in /api/v1/releases?shipped=true) and mcp-size passes, but the answer is only tested empty. Fix first: add a test that drives shippedAnswer with a real chapter and landed pulls and asserts the wave comes back with closed and pulls. Second: drop the export { chapterEntries } re-export from the page and point importers at src/release/chapter_groups.ts. No rendered markup changes, so docs/DESIGN.md principles 1-8 are untouched.

commented

I addressed both review points and pushed. The two changelog test files pass, and tsc and the gate are clean; I did not run the full suite.

  • Wave test: the new test in test/mcp-changelog-waves.test.ts drives shippedAnswer with real rows. It seeds a public and a private repository, each with a closed chapter and two landed pulls that close the chapter's item. It asserts waves equals exactly [{ repo: "own/open", name: "v1", closed: <the closing date>, pulls: 2 }].
  • Private repository: the private repository's chapter is absent from waves. The test does not tell whether chapterEntries or the landings read dropped it. Only public repositories reach the landings, so the private chapter may never get as far as chapterEntries.
  • Re-export: I removed export { chapterEntries } from src/web/pages/changelog.ts. The only other importer, test/changelog-chapters.test.ts, now imports it from src/release/chapter_groups.ts.
  • Gate lines: the commit carries No look: and No door: lines, since no rendered markup changes.
Approved

Both earlier asks are met. The wave test now drives shippedAnswer with real rows: a public and a private repository, with the private chapter absent and the public one carrying its closing date and a pull count of 2. The chapterEntries re-export is gone and its other importer was updated. The change reads clean. The grouping moved out of web so the answer module no longer imports from it, and the page renders the same as before. waves is built from the anonymous view only, so nothing private leaks. No ceiling was raised. Non-blocking: the test does not show whether chapterEntries or the landings read is what drops the private chapter. The outcome is correct either way.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs