Public: anyone can read this; the crew can change it.

A maintenance duty files a finding when a chapter's issue has had no run and no pull for 24 hours #14076

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

A new chapter-stall maintenance duty files one bug defect per stalled issue in an open chapter, and is registered in src/maintain/registry.ts. The six new tests pass, tsc is clean, and the gate left nothing to commit. I did not run the full suite.

Notes

shipped production is serving it deploy 4adf612

opened this

A new chapter-stall maintenance duty files one bug defect per stalled issue in an open chapter, and is registered in src/maintain/registry.ts. The six new tests pass, tsc is clean, and the gate left nothing to commit. I did not run the full suite. scripts/fast.ts found the diff too broad to name, so I ran the new test, the red-apps test, the maintenance tests and test/pages-budget.test.ts.

What it does

  • Stalled: an issue in a repository's open chapter whose last sign of work is 24 hours old or more. The signs are a run on the issue, a pull whose description closes it (Closes #N), and the moment it entered the chapter or the chapter opened. A fresh chapter or a fresh addition is therefore not stalled.
  • Left alone: repositories with no open chapter, draft and closed chapters, and closed issues. The duty files nothing for these.
  • Filing: one finding per stalled issue, and one defect per issue titled #N in chapter X has had no run and no pull for 24 hours. While that defect is open no second is filed, and closing it during a stall lets the next daily run file a fresh one.
  • Test: test/maintenance-chapter-stall.test.ts drives the clock through the duty's now argument.

Choices to check

  • Location: the duty lives in src/maintain/duties/chapter_stall.ts, where the other duties live, not in src/maintenance/ as the issue said.
  • Page budget: the /maintenance statement budget goes from 65 to 68, in both src/perf/page_budget.ts and test/pages-budget.test.ts. The new duty reads its own state, and the measured count was 68.
  • Docs: I added a section to docs/features/maintenance.md.
  • Prior work: nothing on main already did this. The latest commit in this area was b214c3a6e (red-apps), whose pattern this follows.

Left out

  • The duty never comments on, closes or edits an issue.
  • It does not count a pull that only mentions an issue without Closes/Fixes/Resolves.
  • It does not file a report when the chapter has no open issues.
  • The release hold on trevato/forge did not touch this change.

To try it: bun test test/maintenance-chapter-stall.test.ts, or watch the chapter-stall row on /maintenance.

🤖 Generated with Claude Code

Closes #14057

commented

A new chapter-stall maintenance duty files one bug defect per stalled issue in an open chapter, and is registered in src/maintain/registry.ts. The six new tests pass, tsc is clean, and the gate left nothing to commit. I did not run the full suite. scripts/fast.ts found the diff too broad to name, so I ran the new test, the red-apps test, the maintenance tests and test/pages-budget.test.ts.

What it does

  • Stalled: an issue in a repository's open chapter whose last sign of work is 24 hours old or more. The signs are a run on the issue, a pull whose description closes it (Closes #N), and the moment it entered the chapter or the chapter opened. A fresh chapter or a fresh addition is therefore not stalled.
  • Left alone: repositories with no open chapter, draft and closed chapters, and closed issues. The duty files nothing for these.
  • Filing: one finding per stalled issue, and one defect per issue titled #N in chapter X has had no run and no pull for 24 hours. While that defect is open no second is filed, and closing it during a stall lets the next daily run file a fresh one.
  • Test: test/maintenance-chapter-stall.test.ts drives the clock through the duty's now argument.

Choices to check

  • Location: the duty lives in src/maintain/duties/chapter_stall.ts, where the other duties live, not in src/maintenance/ as the issue said.
  • Page budget: the /maintenance statement budget goes from 65 to 68, in both src/perf/page_budget.ts and test/pages-budget.test.ts. The new duty reads its own state, and the measured count was 68.
  • Docs: I added a section to docs/features/maintenance.md.
  • Prior work: nothing on main already did this. The latest commit in this area was b214c3a6e (red-apps), whose pattern this follows.

Left out

  • The duty never comments on, closes or edits an issue.
  • It does not count a pull that only mentions an issue without Closes/Fixes/Resolves.
  • It does not file a report when the chapter has no open issues.
  • The release hold on trevato/forge did not touch this change.

To try it: bun test test/maintenance-chapter-stall.test.ts, or watch the chapter-stall row on /maintenance.

🤖 Generated with Claude Code

Approved

Read the diff in full. The duty reads only stored rows and files through fileIssueOnce, so no user text reaches a shell or SQL. Titles and chapter names are stripped of <, > and backticks before they go into the body. It adds no endpoint, no body read and no dependency. The how-to is in docs/features/maintenance.md, not the README. The /maintenance row already exists in both doors, so no new TUI screen is needed. The tests take the fake clock through now. The +3 statement budget is justified in the comment. Non-blocking nits: the per-issue MAX(created_at) run query is an N+1, and the tests share state across cases.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs