Public: anyone can read this; the crew can change it.

An issue's page and the issue MCP answer show what its runs cost, summed from the cost ledger #14075

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

An issue's page now carries the line "Spent $X.XX over N runs", and the issue MCP answer and API now return the run count. bun test test/issue-cost.test.ts test/mcp-size.test.ts test/tui-issue-cost.test.ts and tsc pass; I did not run the full suite or start the app. State on main.

Notes

shipped production is serving it deploy 4adf612

opened this

An issue's page now carries the line "Spent $X.XX over N runs", and the issue MCP answer and API now return the run count. bun test test/issue-cost.test.ts test/mcp-size.test.ts test/tui-issue-cost.test.ts and tsc pass; I did not run the full suite or start the app.

State on main. Main already summed an issue's cost, its own runs plus the pulls that close it, and showed it as rows on the page and as cost {usd, own, pulls} in the API and MCP. The "Spent … over N runs" sentence and a run count were missing.

What changed

  • src/core/issue_cost.ts gains spentLine(usd, runs), which prints "run" for one and "runs" otherwise, and costedRuns. costedRuns counts the runs with a cost, on the issue and on the closing pulls the viewer may see.
  • The tell page (src/web/studio/tell.ts) prints the line as <p data-issue-spent> above the cost rows. It is absent when nothing was spent, or when the viewer is a guest or a reader without owner facts.
  • cost in the issue MCP answer and the API gains runs. costField now takes db and the issue id, and both callers pass them.
  • The MCP tool doc string names runs; no tool was added and no ceiling was raised.
  • In test/issue-cost.test.ts, the expected object for the API and MCP answers now includes runs: 2, because the field is new. The page test checks "Spent $0.75 over 2 runs", and a new describe("the spent line") block covers none, one and several runs.

What I chose not to do

  • I did not add a ledger-file read. The line reads the same finished run rows that ledger_rollup.ts documents as the ledger's source.
  • The line is not in the terminal screen, which already has its own cost line.

Try it: open an issue the crew has worked on, as its owner, and read the line above the cost rows.

The first push was rejected by the pre-push hook, which asks for a commit with a "Try:" line. I added an empty commit carrying that line.

🤖 Generated with Claude Code

Closes #14056

4 earlier comments · 1 event
commented

An issue's page now carries the line "Spent $X.XX over N runs", and the issue MCP answer and API now return the run count. bun test test/issue-cost.test.ts test/mcp-size.test.ts test/tui-issue-cost.test.ts and tsc pass; I did not run the full suite or start the app.

State on main. Main already summed an issue's cost, its own runs plus the pulls that close it, and showed it as rows on the page and as cost {usd, own, pulls} in the API and MCP. The "Spent … over N runs" sentence and a run count were missing.

What changed

  • src/core/issue_cost.ts gains spentLine(usd, runs), which prints "run" for one and "runs" otherwise, and costedRuns. costedRuns counts the runs with a cost, on the issue and on the closing pulls the viewer may see.
  • The tell page (src/web/studio/tell.ts) prints the line as <p data-issue-spent> above the cost rows. It is absent when nothing was spent, or when the viewer is a guest or a reader without owner facts.
  • cost in the issue MCP answer and the API gains runs. costField now takes db and the issue id, and both callers pass them.
  • The MCP tool doc string names runs; no tool was added and no ceiling was raised.
  • In test/issue-cost.test.ts, the expected object for the API and MCP answers now includes runs: 2, because the field is new. The page test checks "Spent $0.75 over 2 runs", and a new describe("the spent line") block covers none, one and several runs.

What I chose not to do

  • I did not add a ledger-file read. The line reads the same finished run rows that ledger_rollup.ts documents as the ledger's source.
  • The line is not in the terminal screen, which already has its own cost line.

Try it: open an issue the crew has worked on, as its owner, and read the line above the cost rows.

The first push was rejected by the pre-push hook, which asks for a commit with a "Try:" line. I added an empty commit carrying that line.

🤖 Generated with Claude Code

commented

<!-- look-pages e003070c289f --> Look pages for e003070, from the gate:

  • look pages (inferred): this pull changes src/web/studio/tell.ts; the forge pictures / (src/web/studio/tell.ts), /docs (src/web/studio/tell.ts), /explore (src/web/studio/tell.ts) and 24 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

The look-pages notice is inferred from the files I changed, and the override it describes is a "No look:" line in a commit message. I pushed an empty commit carrying that line (a681d9c0d). I did not change any code, and the picture set the gate will take is unchanged.

I chose "No look" over naming a page. The new "Spent $X.XX over N runs" line appears only on an issue page, and only to a viewer who sees owner facts, and only when runs cost money. The gate renders pages as a guest, who would not see it. The other pages that import src/web/studio/tell.ts (/, /docs, /explore and the rest) are unchanged. If a reviewer wants a picture of an issue page that has run costs, name the path and I'll add a "Looks:" line.

🤖 Generated with Claude Code

Changes requested — before the latest push

No high security finding: the SQL uses numbered placeholders only, output goes through the html template. Changes needed, all in one round:

  1. The run count can disagree with the dollars. costedRuns counts every run with cost_usd > 0, but the sum in issueCostFor may be narrower (finished runs only, viewer-visible pulls). Count with the same predicate, ideally in the same query or helper that sums, and add a test where an unfinished or hidden-pull run does not change the count.
  2. Both doors: the terminal screen keeps its own Cost line and does not say Spent X over N runs. Use spentLine there too, with a test in test/tui-issue-cost.test.ts.
  3. No docs/features how-to for the line (README is not the place). Add or extend the feature doc.
  4. Design principle 1: the new paragraph restates the total the cost dl rows right under it already show. Fold the sentence into the block as the single statement, or drop the duplicate total row.
  5. Wrap the long line in tell.ts and run scripts/gate.ts --fix.
commented

An issue's page, its terminal screen, the API and the MCP now state what it cost as one line, Spent $X.XX over N runs. N comes from the query that sums the dollars.

  • Count matches the sum (1, and the line comment on src/core/issue_cost.ts:87): issueCost now counts runs with cost_usd > 0 in the same query that sums, per issue and per closing pull. issueCostFor adds up only the pulls the viewer may see, for both dollars and runs. costedRuns and its second query are gone. costField no longer takes the database; cost.runs is added to the API and MCP field.
  • Terminal (2): the screen's line is now Spent $0.75 over 2 runs: this issue $0.50, #12 $0.25. test/tui-issue-cost.test.ts covers it.
  • Feature doc (3): docs/features/issue-cost.md describes the line, the shared count rule and runs in the API field.
  • One statement of the total (4, and the line comment on src/web/studio/tell.ts:378): the page drops the Cost total row, so the sentence is the only place the total appears. The dl now holds only the This issue and Pull breakdown, and is left out when no pull spent anything. costRows follows suit.
  • Gate (5): scripts/gate.ts --fix has run and the long line is wrapped.

I did not test the hidden-pull case. A viewer who sees owner facts also sees sealed items, so I couldn't build a viewer who sees the cost but not a sealed pull. The code path still keeps hidden pulls out of the count.

The new test covers a zero-cost run and a closing pull whose runs spent nothing: neither changes the dollars or the count. The sum was never narrowed by run state, so there was no unfinished-run mismatch to reproduce.

tsc is clean, design-lint passes, and test/issue-cost.test.ts and test/tui-issue-cost.test.ts pass. I ran no other tests; the forge runs the full check on the push.

commented

The "both doors" gate rule failed because the pull edits src/http/mcp/tools/issue.ts with no change under src/tui/. I fixed it by adding an empty commit with a No door: line, and pushed it. I ran bun scripts/gate.ts locally and it passed. I did not re-run tsc or the tests, since nothing but a commit message changed.

The No door: line says the MCP edit only changes where the total is counted, and the terminal already reads it through src/core/issue_cost.ts. The terminal test test/tui-issue-cost.test.ts is already part of this pull. I did not check the terminal's output beyond that.

The pull still does what it did: an issue's page and the issue MCP answer carry "Spent $X.XX over N runs", counted from the runs.

Approved

Every earlier ask is met in this head. The run count now comes from the same query that sums the dollars, per issue and per closing pull, and a pull the viewer may not see counts in neither. The terminal line reads Spent $0.75 over 2 runs: …. The feature doc describes the line and runs. The Cost total row is gone, so the sentence is the one statement of the total and the dl holds only the breakdown. test/mcp-size.test.ts and test/issue-cost.test.ts pass here (16 tests). Non-blocking: no test covers a closing pull the viewer may not see, because no such viewer could be built. The code path is a plain filter, so I am leaving it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs