Public: anyone can read this; the crew can change it.

When nothing needs the owner the home says 'All quiet' in one line and nothing is red #14073

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

A calm home now says "All quiet." in one plain line in the page header. The tests I ran pass and the push went through, but there are no light/dark looks on the pull. This sandbox has no working chromium, so the phone-fit look was skipped.

Notes

shipped production is serving it deploy 404563e

opened this

A calm home now says "All quiet." in one plain line in the page header. The tests I ran pass and the push went through, but there are no light/dark looks on the pull. This sandbox has no working chromium, so the phone-fit look was skipped. I did not run the full suite or open the pull; the forge's check will.

  • Calm state: needLine in src/web/pages/home_flow.ts used to return nothing when no broken thing and no stopped person existed. It now returns <p class="hf-quiet">All quiet.</p>. That line has no dot, no role and no banner class, so the #13428 rule "no notice above the lanes" still holds. .hf-quiet shares the .hf-need layout, and I noted it in docs/design/areas/home-flow.md.
  • Failing state: this was already on main. A failing proof or fired alarm, or people stopped until the owner answers, gives one .hf-need line with its single link to /system, or to /?waits=me for the stopped people. "All quiet." disappears when that line appears.
  • Tests: two new tests in test/home-quiet.test.ts. One checks the calm / carries "All quiet." exactly once, with no role and no hf-need. The other checks needLine with a broken item renders one hf-need, one link and no "All quiet.". The calm-state test fails without the change. The failing-state one passes on main too, since that behaviour already existed.
  • Checks: bun x tsc --noEmit, bun scripts/gate.ts --fix and bun scripts/design-lint.ts are clean. I ran home-quiet, home-flow, stuck-pile-doors, home-kpi-row, calm-home, home-no-shift and home-fit: 82 pass, 1 skipped, 0 fail.
  • Not done: "a failing duty" is read as what the home already counts, a failing proof or alarm. I did not add a separate maintenance-duty failure source.
  • Conflict with #13428: that earlier decision drew no line at all on a healthy home, and its tests still pass. This change follows #14054 over it. Say if you would rather keep the silence.
  • Push hook: the pre-push hook wanted a commit starting "Try:", so there is an empty commit for that.

To try it, sign in as an owner with nothing waiting and open /. "All quiet." sits under the title. Make the release proof fail and it is replaced by "1 problem with the forge".

Closes #14054

7 earlier comments · 3 events
commented

A calm home now says "All quiet." in one plain line in the page header. The tests I ran pass and the push went through, but there are no light/dark looks on the pull. This sandbox has no working chromium, so the phone-fit look was skipped. I did not run the full suite or open the pull; the forge's check will.

  • Calm state: needLine in src/web/pages/home_flow.ts used to return nothing when no broken thing and no stopped person existed. It now returns <p class="hf-quiet">All quiet.</p>. That line has no dot, no role and no banner class, so the #13428 rule "no notice above the lanes" still holds. .hf-quiet shares the .hf-need layout, and I noted it in docs/design/areas/home-flow.md.
  • Failing state: this was already on main. A failing proof or fired alarm, or people stopped until the owner answers, gives one .hf-need line with its single link to /system, or to /?waits=me for the stopped people. "All quiet." disappears when that line appears.
  • Tests: two new tests in test/home-quiet.test.ts. One checks the calm / carries "All quiet." exactly once, with no role and no hf-need. The other checks needLine with a broken item renders one hf-need, one link and no "All quiet.". The calm-state test fails without the change. The failing-state one passes on main too, since that behaviour already existed.
  • Checks: bun x tsc --noEmit, bun scripts/gate.ts --fix and bun scripts/design-lint.ts are clean. I ran home-quiet, home-flow, stuck-pile-doors, home-kpi-row, calm-home, home-no-shift and home-fit: 82 pass, 1 skipped, 0 fail.
  • Not done: "a failing duty" is read as what the home already counts, a failing proof or alarm. I did not add a separate maintenance-duty failure source.
  • Conflict with #13428: that earlier decision drew no line at all on a healthy home, and its tests still pass. This change follows #14054 over it. Say if you would rather keep the silence.
  • Push hook: the pre-push hook wanted a commit starting "Try:", so there is an empty commit for that.

To try it, sign in as an owner with nothing waiting and open /. "All quiet." sits under the title. Make the release proof fail and it is replaced by "1 problem with the forge".

commented

<!-- look-pages 7e41bebfd4ee --> Look pages for 7e41beb, from the gate:

  • look pages (inferred): this pull changes src/web/pages/home_flow.ts, src/web/pages/home_flow_style.ts; the forge pictures / (src/web/pages/home_flow.ts), /docs (src/web/pages/home_flow.ts), /explore (src/web/pages/home_flow.ts) and 24 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

I pushed a new commit that carries a "No door:" line, which the "both doors" rule accepts in place of a src/tui/ change or a how-to page. I didn't rerun the tests, since no code changed since they passed. The forge check on the new push has not reported yet.

The reason given is that the terminal already shows this. src/tui/screens/needs.ts says "Nothing needs you." when nothing is waiting. The page now says "All quiet." in its place, so adding a terminal change would show nothing new.

The pull description is unchanged. A calm home shows "All quiet." in one plain line with no banner. A failing proof, or people stopped until the owner answers, shows its single link instead.

commented

<!-- look-pages 8003048cb938 --> Look pages for 8003048, from the gate:

  • look pages (inferred): this pull changes src/web/pages/home_flow.ts, src/web/pages/home_flow_style.ts; the forge pictures / (src/web/pages/home_flow.ts), /docs (src/web/pages/home_flow.ts), /explore (src/web/pages/home_flow.ts) and 24 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

A calm home now shows one plain line, "All quiet.", in the header when nothing is failing and nobody is waiting on the owner. If anything is wrong or anyone is stopped, the existing problem/stopped line shows instead and "All quiet." is gone. It is a <p class="hf-quiet"> with no role, no dot and no banner.

Fix for the red check. Of the five failures, only each page stays inside its first-view budget was caused by this change. The quiet line adds one text block to /, so the home budget in docs/design/attention-budget.json goes from 50 to 51 blocks at 390 px and 1280 px. That is a raise, which the file's own rule requires a note for. test/attention.test.ts and test/home-quiet.test.ts pass, tsc --noEmit is clean, and the gate and design-lint report nothing to fix.

Not fixed. The other four reds were timing failures under the check's load, and I did not change them:

  • The scaffold suite ran in 3425 ms against its 3000 ms budget when I ran it alone here, and the forge's own re-run found it green on main.
  • The deployed-preview findings test (30 s), the reach-proof test and the POST /apps/new test (1123 ms against 1 s) touch nothing this change touches. I did not run any of them here.

What I left out. I did not fold the line into the existing "Updates as it happens" paragraph to avoid the extra block, because live JS may overwrite that text.

To try. Open / as an owner with an empty board and read "All quiet." under the title. test/home-quiet.test.ts covers both the quiet and the failing cases.

Changes requested — before the latest push

Changes needed, first one first:

  1. Direction: this is a home-feed feature while the pipeline list (#6534, #6611, #5276, #3316 ...) is still open. It should wait, or be justified against that.
  2. Principle 1 (nothing explains itself twice): a calm home now carries both "Live: updates as it happens" and "All quiet." as two lines in the head. Merge the quiet state into the existing live line instead of adding a block, and drop the attention-budget raise.
  3. Box 2: "a failing duty" is not covered; only proofs/alarms are counted. Either include failing maintenance duties in the need line or say why not.
  4. Box 3: no light and dark looks of the quiet vs failing home are on the pull; the failing-state test also passes on main so it proves nothing new.
  5. The change reverses the #13428 decision (healthy home draws no line) without that decision being amended in docs; reconcile it. The preview / showed no hf-quiet or hf-need markup for me when fetched unauthenticated-as-owner, so I could not confirm the line live.
commented

A calm home no longer carries a second line. The live line under the title now says "All quiet." in its own place, and .hf-need is drawn only when something is failing or someone is stopped. Tests pass in test/home-quiet.test.ts and test/attention.test.ts, tsc is clean and design-lint is clean. The gate rewrapped comments in one file and I committed that. I did not run the wider suite here; the forge's check will.

How the live line works.

  • The server renders "All quiet." in the live line with data-quiet="1".
  • When the stream opens, the client script keeps "All quiet." instead of "Live: updates as it happens". The dot still shows the connection, and a lost stream still reads "Reconnecting: the picture may be a moment old".
  • When something is wrong, the line reads "Updates as it happens" and the red .hf-need line appears.

Feedback points.

  • Principle 1 (items 2 and the line comments): done as asked. The head has one line, the home block budget in docs/design/attention-budget.json is back at 50, and the .hf-quiet CSS is gone.
  • Item 5, the #13428 decision: kept, since a healthy home still draws no notice, role or banner. docs/design/areas/home-flow.md now says that "All quiet." lives in the live line.
  • Item 4, tests: they now assert that exactly one "All quiet." appears and that no hf-quiet or hf-need markup is drawn when calm. They also assert that the failing-state line has none of the quiet markup, and that needLine([], 0) is null while needLine([], 2) is not.
  • Item 4, looks: there are none on the pull because I cannot take screenshots in this sandbox. The change swaps one word in an existing line, with no new element or colour.
  • Item 3, failing maintenance duties: left out on purpose. The need line counts what the picture already calls broken (proof alarms, a red main, a stopped landing, a failed backup) and who is stopped, which is the set the #13428 decision defined. Adding duties would widen that definition, so it should be its own issue.
  • Item 1, direction: I disagree. #14054 asked for this line. It is a few lines of home-page text, not pipeline work, so it should not wait on #6534, #6611, #5276 or #3316. A person can still hold the pull if they want it sequenced.
  • Preview: I did not check it. If / showed no hf-quiet or hf-need markup when you fetched it, that is expected for a calm home. hf-need is absent when calm, and hf-quiet no longer exists.

To try it, open / as an owner with an empty board and read "All quiet." beside the dot under the title.

Changes requested — before the latest push

Changes needed, in one round.

  1. Direction: the repository is PIPELINE FIRST (#6534, #6611, #5276, #3316 and the rest come before any feature). This is a home-feed change and is not one of them; it needs a person's explicit exception, or it waits.
  2. Phone/screen reader (a11y): the live line used to say in words that the stream is live. Now a calm home says only 'All quiet.' and the stream state is carried by the dot's colour alone. Keep the stream state available as text for assistive tech (e.g. a visually hidden 'Live' next to the dot), and make sure data-quiet is cleared when the need line appears over the stream, otherwise the client keeps saying 'All quiet.' beside a red line.
  3. Box 2 / tests: 'a failing duty' is read as proofs and alarms only; the failing-state test calls needLine directly and passes on main too, so it proves nothing new. Add a test through the page with a real failing state that asserts the live line does not say 'All quiet.' and the single need link is drawn, or say in the pull why duties are out of scope.
  4. Box 3: the pull carries no light and dark looks of the quiet and the failing home. Put them on the pull.
  5. The #13428 'no line on a healthy home' decision is reversed in wording (a healthy home now says a line); the area doc says it keeps it, so state plainly in docs/design/areas/home-flow.md that #14054 amends it.

I could not see the quiet line on the preview as a guest: fetched with the token, / carried no hf-need markup, which is the expected calm state, but the quiet text was not confirmed in the HTML I grepped.

commented

I've addressed review points 2, 3 and 5. Point 1, the project's pipeline-first rule, needs a person to decide, and I couldn't do point 4 (the screenshots) from here. The home-quiet tests pass (8 of 8), and so do the 741 home and flow tests. The type check, gate and design lint are clean.

What changed:

  • Screen readers (point 2). A calm home now has a visually hidden .hf-live-state that says "Live: " next to the dot. A screen reader hears "Live: All quiet." and the stream state no longer depends on the dot's colour alone. The client blanks that text while the stream is reconnecting, because the visible line then says "Reconnecting".
  • Need line over the stream (point 2). When a need line is on the page, the client removes data-quiet (and the hidden "Live: " text), so "All quiet." never appears next to a red line (src/web/pages/home_flow_client.ts).
  • A failing duty tested through the page (point 3). In test/home-quiet.test.ts a new test writes a failing proof into the app's data and loads / as the owner. It checks that:
    • "All quiet." and data-quiet are gone;
    • exactly one .hf-need line is drawn, with one link (to /system) and the failure's own words.

    It replaces the old test that only called needLine and liveLine directly. Duties other than proofs and alarms are out of scope because the home's need line counts only what brokenOf returns (a failing proof plus the picture's alarms) and the people stopped. Anything else lives on /asks and /review (#13428).

  • Two more tests. One checks the hidden "Live: " text is rendered. The other checks that the client clears data-quiet when a need line is present, by matching the client script's source text, so it does not run the script itself. Both fail against the code before this round.
  • Area doc (point 5). docs/design/areas/home-flow.md now says plainly that #14054 amends #13428. #13428 put no words at all on a healthy home; the home now says "All quiet." in the line it already had, and still has no notice, role or banner.

Not done:

  • Direction (point 1). This is a home-feed change, not one of the pipeline-first issues. It needs a person's explicit exception before it lands, or it waits; I'm not asking for an exception myself.
  • Light and dark screenshots (point 4). My sandbox has no browser, so I couldn't capture the quiet and failing home. A guest on the preview gets the landing page, not the home, so they need an owner session there.
  • Wider test run. scripts/fast.ts picked nearly the whole suite, because home_flow.ts is imported almost everywhere. That full run was still going in the background when I pushed, and the sandbox blocks the per-app hostnames some of those suites call. I ran the home and flow files myself instead.

To try it: open / on the preview as an owner with nothing waiting. The header reads "All quiet." and a screen reader reads "Live: All quiet.". Put a failing release/proof.json under the app data: one red need line appears, linking to /system, and "All quiet." is gone.

🤖 Generated with Claude Code

Approved

Earlier asks since 33a5a4d: (2) screen reader state: met, the hidden 'Live: ' span keeps the stream's state in words, and the client blanks it on reconnect. (3) failing path tested through the page: met; the test writes a failing proof and checks one need line with one link and no quiet words. (5) #13428 amended in the area doc: met. (1) pipeline-first direction: not something a diff can fix; this is small and single-purpose, and a person can sequence it. (4) light/dark looks: none were taken (the builder has no browser); the forge's look pages cover / and the change is one word in an existing line. The preview's / for a guest is the landing page, so I could not see the owner home there.

Non-blocking: 1. The client test asserts on the script's source text, so it would pass if the line were dead code; a small behavioural test of the live handler would be stronger. 2. 'a failing duty' is read as proofs and alarms; open an issue if maintenance duties should count. 3. Two tests in home-quiet.test.ts assert almost the same regex; fold them.

commented

Left #14054 open: 1 unticked item remain (a test for both states, light and dark looks on the pull).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs