Public: anyone can read this; the crew can change it.

Revert "The crew's answer says what changed in plain words, where to see it, and that it is live" #14001

opened this

Check · Review · Land · Live — No review yet. Next: reviewer, no review yet.

Ready to land

Reverts #13802: verifying main after landing found it broke "the owner's settings pages (#9781) > a preview already seeded gets its settings rows once, and a second seed adds no token took 5.83 s, over the 2 s test budget: make it faster, or name its file in SLOW in scripts/gate.ts with an issue" and 2 more in test/beh…

Notes · 6 files · +24 −376

look green — it answered, no tests were run, ready for a look deploy f20b49b

Check passeddeploy f20b49b

Website spec: 24 findings (report only)

Look

9 pages beside main · 0 new to this pull

/apps

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at f20b49b ·

/docs

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at f20b49b ·

/explore

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at f20b49b ·

/looks/failed

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at f20b49b ·

/looks/missing

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at f20b49b ·

/notes

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at f20b49b ·

/releases

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at f20b49b ·

/review

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at f20b49b ·

/security

main

at 4adf612 ·

this pull

In the dark

main

at 4adf612 ·

this pull

at f20b49b ·

opened this

Reverts #13802: verifying main after landing found it broke "the owner's settings pages (#9781) > a preview already seeded gets its settings rows once, and a second seed adds no token took 5.83 s, over the 2 s test budget: make it faster, or name its file in SLOW in scripts/gate.ts with an issue" and 2 more in test/behaviors-rule.test.ts, test/preview-looks.test.ts, test/crew-check-cpu-stop.test.ts, test/mutations-same-origin.test.ts — found by bisecting d73d768..5bb6da3 in 5 steps.

Main's verification 01m7hd91hga4wct5f2pvt3yfts is red at 5bb6da3; each failed test fails alone too.

Proposed by the forge; a person lands it.

Files: test/behaviors-rule.test.ts, test/preview-looks.test.ts, test/crew-check-cpu-stop.test.ts, test/mutations-same-origin.test.ts

commented

<!-- look-pages f20b49b004e3 --> Look pages for f20b49b, from the gate:

  • look pages (inferred): this pull changes src/web/studio/answers.ts; the forge pictures /settings/crew (src/web/studio/answers.ts), /settings/grants (src/web/studio/answers.ts), /preview-admin/sample (src/web/studio/answers.ts) and 2 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs