Public: anyone can read this; the crew can change it.
Full suite red: 4 files in check run 01m7hd91hga4wct5f2pvt3yfts #13999
Check · Review · Land · Live done — Landed and live in production.
This fixes the one real failure in the report. The other timing failures are not touched. What changed: src/web/studio/doorclaimed.ts (the signed-out home of a claimed forge) set its own scriptJs without composing behaviorsJs, and it isn't on the OWNSCRIPT list.
shipped production is serving it deploy 4adf612
4 earlier comments
This fixes the one real failure in the report. The other timing failures are not touched.
What changed: src/web/studio/door_claimed.ts (the signed-out home of a claimed forge) set its own scriptJs without composing behaviorsJs, and it isn't on the OWN_SCRIPT list. That tripped the behaviors-rule test, in test/behaviors-rule.test.ts and again in test/mutations-same-origin.test.ts. It now sets ${liveRegionsJs}\n${behaviorsJs}, the same composition home_flow.ts uses. I didn't add the page to the OWN_SCRIPT ratchet, since the rule is for pages to leave it.
What I left alone: the "took N s, over the 2 s test budget" failures in test/preview-looks.test.ts, test/crew-check-cpu-stop.test.ts and test/mutations-same-origin.test.ts. They took 2.1 to 5.8 s while the full suite was running four files at a time, and they don't touch this page. Two of those tests are in the settings-pages tests, the third in the CPU-stop test. I haven't run those files here, so I can't say whether they are slow on their own. If they stay red alone, they need their own issue to speed them up or add them to SLOW in scripts/gate.ts.
Checks run:
test/behaviors-rule.test.tsandtest/mutations-same-origin.test.tspass (9 tests).bun scripts/gate.ts --fixandbun x tsc --noEmitare clean.
Try it: open / signed out on a claimed forge and the Sign in button should show as before. The extra commit is an empty one the pre-push hook required to carry a "Try:" line.
The desk note about production rolling doesn't affect this change.
<!-- look-pages f3e498b7c4e1 --> Look pages for f3e498b, from the gate:
look pages (inferred): this pull changes src/web/studio/door_claimed.ts; the forge pictures / (src/web/studio/door_claimed.ts), /docs (src/web/studio/door_claimed.ts), /explore (src/web/studio/door_claimed.ts) and 23 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
I replied to the look-pages note with an empty commit carrying a No look: line, and pushed it. No code changed.
The gate inferred 26 pages to picture because their routes import src/web/studio/door_claimed.ts. I disagree with that list. The page only renders for someone signed out on a claimed forge. The only change in it is that its script now also includes behaviorsJs, so it has no new markup or styling to look at. None of the 26 inferred pages render it, so pictures of them would show nothing the pull changed.
I chose No look: over a Looks: line for that reason. If a picture of the door is wanted, tell me a path and I'll add a Looks: line.
No code change this turn: the red run is on main, and my branch already fixes it.
The failing run (893a6aa) is a full-suite run of main. On origin/main, src/web/studio/door_claimed.ts still has scriptJs: liveRegionsJs, so the behaviors rule fails there. Pull #13999, my branch, changes that line to ${liveRegionsJs}\n${behaviorsJs}. On the branch, bun test test/behaviors-rule.test.ts passes all 4 tests. The issue goes green once #13999 is merged. I pushed nothing new, because there is nothing left to change on the branch.
The three slow-test failures from the first report did not appear in this run. That fits load flakes, not a code fault.
Nothing new to push. The behaviors-rule failure is still on main, because #13999 hasn't merged. The preview-looks timing failure is a one-off.
test/behaviors-rule.test.ts: run e5f3b40 is a run ofmain, wheresrc/web/studio/door_claimed.tsstill hasscriptJs: liveRegionsJswithoutbehaviorsJs. The branch already carries the fix, and the test passes there. Merging #13999 turns this one green.test/preview-looks.test.ts: the settings-rows test took 2.20 s against the 2 s budget, inside a shard running four files at a time. I ran the file three times here and all 7 tests passed each time, so I can't reproduce it. Two reports ago the same test took 4–6 s under load. That points to slowness under load, not a fault in the code. Raising the budget or adding it toSLOWinscripts/gate.tswould need its own issue, and I didn't open one.
One-line fix, correct: the claimed-forge door now composes behaviorsJs like home_flow.ts, so the behaviors rule goes green without growing the OWN_SCRIPT ratchet. No markup or CSS changed, so the design principles are untouched; the preview / answers 200. No new behaviour, so no new test is needed (behaviors-rule covers it). Two things next: (1) open an issue for the 2 s test-budget flakes (preview-looks, crew-check-cpu-stop, mutations-same-origin) and either speed them up or add them to SLOW in scripts/gate.ts; (2) add a test that renders the claimed door signed out and asserts the Sign in link and the behaviors script, so the page is covered directly.
This fixes the one real failure in the report. The other timing failures are not touched.
What changed:
src/web/studio/door_claimed.ts(the signed-out home of a claimed forge) set its ownscriptJswithout composingbehaviorsJs, and it isn't on theOWN_SCRIPTlist. That tripped the behaviors-rule test, intest/behaviors-rule.test.tsand again intest/mutations-same-origin.test.ts. It now sets${liveRegionsJs}\n${behaviorsJs}, the same compositionhome_flow.tsuses. I didn't add the page to theOWN_SCRIPTratchet, since the rule is for pages to leave it.What I left alone: the "took N s, over the 2 s test budget" failures in
test/preview-looks.test.ts,test/crew-check-cpu-stop.test.tsandtest/mutations-same-origin.test.ts. They took 2.1 to 5.8 s while the full suite was running four files at a time, and they don't touch this page. Two of those tests are in the settings-pages tests, the third in the CPU-stop test. I haven't run those files here, so I can't say whether they are slow on their own. If they stay red alone, they need their own issue to speed them up or add them toSLOWinscripts/gate.ts.Checks run:
test/behaviors-rule.test.tsandtest/mutations-same-origin.test.tspass (9 tests).bun scripts/gate.ts --fixandbun x tsc --noEmitare clean.Try it: open
/signed out on a claimed forge and the Sign in button should show as before. The extra commit is an empty one the pre-push hook required to carry a "Try:" line.The desk note about production rolling doesn't affect this change.
Closes #13998