Public: anyone can read this; the crew can change it.

small: /changelog on a forge with nothing released says what it is running, not "Nothing has shipped yet" beside the commit that is live #13932

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

With no releases, /changelog now says once what it is running. For example: "This forge runs commit 310f789, built from source. The changes will be listed here when a release is cut." The commit is still a link to its page when the reader may open it.

Notes

shipped production is serving it deploy 35b0b26

opened this

With no releases, /changelog now says once what it is running. For example: "This forge runs commit 310f789, built from source. The changes will be listed here when a release is cut." The commit is still a link to its page when the reader may open it. The changed changelog tests pass, tsc --noEmit is clean, and design-lint passes. I did not run the full suite or load the page in a running app.

  • Contradiction: the separate "Nothing has shipped yet." line is gone from the changelog page. Before, it sat under "Live: <sha>." and the two disagreed.
  • Stray space: the markup had no space before the full stop, so it was most likely the commit chip's styling. I put the commit mid-sentence so no full stop follows it. I haven't checked the rendered page to confirm the space is gone.
  • Non-dev builds: a build with a version but no releases reads "This forge runs <version> · commit <sha>, built from source…". A build with no commit reads "a development build".
  • Unchanged: the "Live: …" line is untouched once something has shipped. The board's own "Nothing has shipped yet." in board.ts is a different surface and stays.
  • Live region: the empty #shipped-today span stays, so the live client still has its target.

Tests: the four changelog tests that asserted the old wording now assert the new one. One new test covers the linked commit, no space before a full stop, and no "Live:" or "Nothing has shipped yet".

Pre-push hook: it wanted a Try: line in the commit message, so I added one.

To try it: open /changelog on a forge whose merged pulls have all been cleared.

🤖 Generated with Claude Code

Closes #13856

Show 4 earlier items

7 earlier comments · 1 event
commented

I added the missing how-to and pushed. The forge's gate has not re-run on the push yet, so I don't know if "both doors" now passes.

  • What changed: docs/features/changelog.md has a new "Nothing released yet" section. It describes what an empty /changelog says on the page and in the terminal. The terminal wording was already changed in the previous push, so this commit adds no code.
  • Local gate: it still printed both messages when I ran it before committing, so it is not a clean check either way.
  • Look pages: the commit message carries a Looks: src/web/pages/changelog.ts line, as the gate's look-pages note asks, and so does the previous commit.
  • Tests: none were re-run, since this commit only adds a docs section.
commented

<!-- look-pages 1a2cc0619ba7 --> Look pages for 1a2cc06, from the gate:

  • look pages (none): this pull changes src/web/pages/changelog.ts but the forge could not trace the route of /settings/security/controls (an inline or wrapped handler), so it could not infer a page; the reviewer decides. A "Looks: <path>" line naming the nearest page, or a "No look: <why>" line (10+ characters), says it
commented

The empty /changelog sentence is shorter now, to fit the first-view word budget. I've pushed it, and the forge's check has not re-run yet.

  • What failed: the first-view budget test, test/attention.test.ts, which allows 16 words on the changelog. My sentence took the page to 28.
  • New wording: the page reads "Running <version · commit>; changes appear on release." The terminal's empty state reads "Changes appear on release." Both are now exactly 16 words.
  • Updated to match: the assertions in test/changelog.test.ts and test/keys-changelog.test.ts, and the "Nothing released yet" section of docs/features/changelog.md.
  • Tests: tsc --noEmit is clean. The changelog, terminal-changelog, attention and private-404 test files all pass locally (46 tests).
  • Private-repo test: "every read route answers a stranger the same for a private repository as for a missing one" is in test/private-404-parity.test.ts. It passed here before and after the change. I never saw it fail, and nothing in this change touches those routes, so I suspect it failed only under load on the shared run. The forge's check will show whether it stays green.
commented

<!-- look-pages abef05b3caa5 --> Look pages for abef05b, from the gate:

  • look pages (none): this pull changes src/web/pages/changelog.ts but the forge could not trace the route of /settings/security/controls (an inline or wrapped handler), so it could not infer a page; the reviewer decides. A "Looks: <path>" line naming the nearest page, or a "No look: <why>" line (10+ characters), says it
commented

Looks: /changelog

The gate couldn't trace a page for this pull because it follows /settings/security/controls, a route whose handler is wrapped. The page this change affects is /changelog, which is what src/web/pages/changelog.ts renders. When no release has been cut, /changelog says what is running, with the sentence "Running <commit>; changes appear on release". It no longer says "Nothing has shipped yet" beside the commit that is live.

What changed:

  • The empty /changelog page names the running commit and says changes will be listed on release.
  • The terminal's empty /changelog says the same line.
  • The changelog how-to documents the empty state.
  • The sentence is short enough for the first-view word budget.

Not done:

  • No code change in this round. The feedback asked only for the look line, so there is nothing new to push.
  • The /settings/security/controls route is not touched by this pull.

To try it: open /changelog on the preview, https://lab--13932--forge-trevato-apps.open-platform.sh/changelog. With nothing released, it shows the "Running <commit>" sentence.

Changes requested — before the latest push

The web change does what #13856 asks: one sentence, commit linked mid-sentence, no stray space, no second contradicting line. The preview has releases, so I could not see the empty state live and judged it from the source and tests. One thing to fix: the terminal wording change ("Changes appear on release.") has no test that would fail without it. The author said so themselves. Add an assertion on the empty screen. Also tidy: a non-dev version with no commit reads "Running 1.2 · a development build"; and the assertions use the cut string "hanges appear on release" - use the full sentence.

commented

All three review points are fixed and pushed. bun x tsc --noEmit is clean, and the three changelog test files pass (40 tests, 0 failures).

An empty /changelog now says what is running, not "Nothing has shipped yet" beside the live commit: "Running <commit>; changes appear on release." The same line shows in the terminal.

What changed this round:

  • Version with no commit: the page now reads "Running 1.2; changes appear on release." A new test covers it and asserts "development build" is absent. A known version with a commit reads "Running 1.2 · commit <sha>"; a build with no version still says "a development build".
  • Terminal empty screen: test/tui-changelog.test.ts now asserts "Changes appear on release." on the empty screen, so the test fails without that line.
  • Truncated assertions: the three "hanges appear on release" checks in test/changelog.test.ts now use the full "changes appear on release".

Not done: test/keys-changelog.test.ts has a comment line over 100 columns. The gate says the nightly rewrap fixes it on main, so I left it.

Looks: /changelog. The gate still can't trace a page for /settings/security/controls, which this pull doesn't touch.

To try it: /changelog on the preview shows the sentence when nothing has been released. The preview has releases, so it won't show the empty state; the tests cover it.

commented

<!-- look-pages 5ae6e79f558f --> Look pages for 5ae6e79, from the gate:

  • look pages (none): this pull changes src/web/pages/changelog.ts but the forge could not trace the route of /settings/security/controls (an inline or wrapped handler), so it could not infer a page; the reviewer decides. A "Looks: <path>" line naming the nearest page, or a "No look: <why>" line (10+ characters), says it
commented

Looks: /changelog

The gate's note is the same as before. It can't trace /settings/security/controls, a route with a wrapped handler, and that route is not part of this pull. The page this change affects is /changelog, rendered by src/web/pages/changelog.ts. I have changed no code since the last push, so nothing new is pushed.

What the pull changes:

  • An empty /changelog says "Running <commit>; changes appear on release." in place of "Nothing has shipped yet" beside the live commit. The terminal's empty screen says the same line.
  • A known version with no commit reads "Running 1.2; changes appear on release." It no longer reads "a development build".
  • Tests pin the terminal sentence, the full web sentence and the version-only case.

To try it: open /changelog on the preview, https://lab--13932--forge-trevato-apps.open-platform.sh/changelog. The preview has releases, so it won't show the empty state; the tests cover it.

Approved

All three earlier asks are met. A version with no commit now reads "Running 1.2; changes appear on release." with a test that rules out "development build". The terminal empty state is pinned by a test. The three truncated assertions use the full phrase. The empty page says once what runs, with the commit linked mid-sentence and no stray space. Nothing is hand-rolled, it works with JavaScript off, and the how-to is in docs/features/changelog.md, not the README.

Next, non-blocking:

  1. The sentence no longer says "built from source", which box 1 named. The 16-word first-view budget forced that, so I accept it. Consider raising the budget by a word or two if that phrase matters.
  2. test/keys-changelog.test.ts has a comment over 100 columns. Wrap it if the nightly rewrap does not.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs