Public: anyone can read this; the crew can change it.

Full suite red: 4 files in check run 01m7h2zfw4ddgcca6pcntk8zsj #13911

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

I added the four files to SLOW in scripts/gate.ts under #13908, so their time over the 2 s test budget no longer fails the suite. I didn't make them faster. The 8 test files that cover scripts/gate.ts pass, and tsc is clean.

Notes

shipped production is serving it deploy 4adf612

opened this

I added the four files to SLOW in scripts/gate.ts under #13908, so their time over the 2 s test budget no longer fails the suite. I didn't make them faster. The 8 test files that cover scripts/gate.ts pass, and tsc is clean. I haven't run the four files together under full-suite load.

Run alone, none of the four fails. Each needs a real server, browser or page walk, and the 2 s overruns in the report appeared only under full-suite load. Alone, new-repo-fit takes 1.8 s, tui-queue 3.4 s, keys-palette 2.0 s and attestation 2.3 s. Those are whole-file times. I didn't time individual tests alone. The SLOW entries record both numbers, load and alone, with the reason each file is slow.

If you'd rather have faster tests than SLOW entries, the cost is reworking how each file boots its server or browser.

Closes #13908

commented

I added the four files to SLOW in scripts/gate.ts under #13908, so their time over the 2 s test budget no longer fails the suite. I didn't make them faster. The 8 test files that cover scripts/gate.ts pass, and tsc is clean. I haven't run the four files together under full-suite load.

Run alone, none of the four fails. Each needs a real server, browser or page walk, and the 2 s overruns in the report appeared only under full-suite load. Alone, new-repo-fit takes 1.8 s, tui-queue 3.4 s, keys-palette 2.0 s and attestation 2.3 s. Those are whole-file times. I didn't time individual tests alone. The SLOW entries record both numbers, load and alone, with the reason each file is slow.

If you'd rather have faster tests than SLOW entries, the cost is reworking how each file boots its server or browser.

Approved

Four SLOW entries in scripts/gate.ts, each with a reason, both timings and an owning issue (#13908, which exists). This is the mechanism the file documents for #1242, it changes no runtime code, and the four files are named in the red run. No security surface, no test or doc needed. Note for later: SLOW is meant to stay short, so #13908 should stay open to bring these four under budget instead of letting the entries become permanent.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs