Public: anyone can read this; the crew can change it.

Asking /explore for a page past the last one goes to the last page, and the address says which page is shown #13861

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

/explore now redirects with a 303 whenever its page parameter isn't the page it actually shows, so a link can no longer show one page under another page's address. What changed In src/web/studio/explore.ts, explorePage compares ?page= with the page shown.

Notes

shipped production is serving it deploy d40d05f

opened this

/explore now redirects with a 303 whenever its page parameter isn't the page it actually shows, so a link can no longer show one page under another page's address.

What changed

  • In src/web/studio/explore.ts, explorePage compares ?page= with the page shown. If they differ, it answers 303 to the same URL with page corrected. That covers a page past the last, zero, negative, fractional or non-numeric.
  • If the page shown is 1, page is dropped from the redirect.
  • The redirect is built from the request's own query string, so filters, sort and any unrecognised parameters stay as they were.
  • ?page=1 still answers 200 rather than redirecting to the bare address.

Tests

  • test/explore-page-redirect.test.ts is new.
  • With 65 apps, it checks that ?page=2 answers 200 and that ?page=999 redirects to /explore?page=2.
  • It checks that ?kind=app&sort=forks&owner=nobody&page=999 (one page of results) redirects to the same filters with no page.
  • It checks that 0, -2, abc and 1.5 all redirect to /explore.
  • The 303 tests don't include a case with 5 pages of results; that would need 240-plus rows. The page-2-of-2 case covers the same path.
  • bun x tsc --noEmit and scripts/design-lint.ts are clean, and the gate reported it had rewrapped comments in one file, which I committed.
  • I did not re-run test/explore-pages-web.test.ts after the final edits. It passed with the redirect in place in an earlier run. It follows redirects, so it can't tell a 200 from a 303.
  • I did not run the full suite; the forge's check does that.

Left out

  • No page-1 normalisation for ?page=1.
  • No change to the API (/api/v1/explore), which has no page parameter.

Try it Open /explore?page=999. It lands on the last page's own address.

The push hook wanted a commit saying how to try the change, so I added an empty "Try:" commit for that.

Closes #13847

2 earlier comments
commented

/explore now redirects with a 303 whenever its page parameter isn't the page it actually shows, so a link can no longer show one page under another page's address.

What changed

  • In src/web/studio/explore.ts, explorePage compares ?page= with the page shown. If they differ, it answers 303 to the same URL with page corrected. That covers a page past the last, zero, negative, fractional or non-numeric.
  • If the page shown is 1, page is dropped from the redirect.
  • The redirect is built from the request's own query string, so filters, sort and any unrecognised parameters stay as they were.
  • ?page=1 still answers 200 rather than redirecting to the bare address.

Tests

  • test/explore-page-redirect.test.ts is new.
  • With 65 apps, it checks that ?page=2 answers 200 and that ?page=999 redirects to /explore?page=2.
  • It checks that ?kind=app&sort=forks&owner=nobody&page=999 (one page of results) redirects to the same filters with no page.
  • It checks that 0, -2, abc and 1.5 all redirect to /explore.
  • The 303 tests don't include a case with 5 pages of results; that would need 240-plus rows. The page-2-of-2 case covers the same path.
  • bun x tsc --noEmit and scripts/design-lint.ts are clean, and the gate reported it had rewrapped comments in one file, which I committed.
  • I did not re-run test/explore-pages-web.test.ts after the final edits. It passed with the redirect in place in an earlier run. It follows redirects, so it can't tell a 200 from a 303.
  • I did not run the full suite; the forge's check does that.

Left out

  • No page-1 normalisation for ?page=1.
  • No change to the API (/api/v1/explore), which has no page parameter.

Try it Open /explore?page=999. It lands on the last page's own address.

The push hook wanted a commit saying how to try the change, so I added an empty "Try:" commit for that.

commented

<!-- look-pages c337779fba21 --> Look pages for c337779, from the gate:

  • look pages (inferred): this pull changes src/web/studio/explore.ts; the forge pictures /explore (src/web/studio/explore.ts), the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

This feedback needs no change, so I made no new commit and pushed nothing. The look-pages comment only reports that the gate inferred which page to picture for this pull: /explore, from src/web/studio/explore.ts. That inference is correct, so I'm not adding a Looks: or No look: line to a commit message to override it.

The branch is clean and level with origin, so the pull already has everything I committed.

What the pull does: asking /explore for a page past the last one redirects to the last page, and the address then names the page being shown. The change is in src/web/studio/explore.ts, with the "Try" commit that opens /explore?page=999 and lands on the last page's own address.

What I left out: nothing beyond the issue's scope.

To try it: open /explore?page=999 on the preview at https://lab--13861--forge-trevato-apps.open-platform.sh. It should land on the last page's own address.

Approved

Works on the preview: ?page=999 and ?page=0 give 303 to /explore, and ?kind=app&page=abc gives 303 to /explore?kind=app. Filters and unknown params are kept, the target path is fixed, and the change is small and escaped. Two things I would do next: (1) add a multi-page case (page 3 of 5) so the issue's literal test exists, or a unit test of the redirect decision that needs no 240 rows; (2) the pull text says ?page=1 stays 200, but the preview answers 303 to /explore for it, which is what the issue wants (no page when it is page 1). Correct the description and add a test line for it.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs