Public: anyone can read this; the crew can change it.

/status says when its words were read, and since when a row that is not ok has been so #13858

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

/status now says when its words were read, and since when a row that isn't ok has been so. test/status-page.test.ts passes (16 tests), tsc and the design lint are clean, and the gate rewrapped comments, which are in the commit. I did not run the app end to end or the rest of the suite.

Notes

shipped production is serving it deploy 8e1361f

opened this

/status now says when its words were read, and since when a row that isn't ok has been so. test/status-page.test.ts passes (16 tests), tsc and the design lint are clean, and the gate rewrapped comments, which are in the commit. I did not run the app end to end or the rest of the suite. I also did not call keep_plan or estimate; no "by <time>" is claimed.

  • As of: the page shows as of HH:MM UTC under the sentence, as a hint paragraph with no new CSS class. The JSON carries asOf as an ISO time. The time is taken once per 10 s hold, so the markup is still built once per hold.
  • Since: a slow or down row reads down since 14:02 UTC or slow since 13:00 UTC. The time is the earliest moment any cause on that row was first seen. An ok row says nothing.
  • Size and script: the page is still signed-out and script-free, and the existing size test still keeps it under 6 KB.
  • Terminal and docs: the terminal Status screen reads the same words, so it now shows the as-of line and the row times too. I also updated the /status line in docs/STATUS.md.
  • Tests: the new ones cover the as-of time on an ok page, since on a down row and on a slow row, and the as-of time and its ISO form in the page and JSON. test/status-page.test.ts also needed edits for the new shapes.

JSON shape change: each entry in rows is now {state, since?} instead of a bare word. I found no other reader of the JSON in src, but an outside client of /status would need to follow the change.

Left out:

  • The billing-records row (broken ledger) and the "forge is restarting" row have no known start time, so they say only slow, with no since. I did not invent one.
  • A down state with no named cause still says plain Down.

The push was refused at first for lacking a "Try:" commit, so the branch ends with an empty commit that says how to try it. To try it, open /status, or fetch it with Accept: application/json.

Closes #13854

2 earlier comments
commented

/status now says when its words were read, and since when a row that isn't ok has been so. test/status-page.test.ts passes (16 tests), tsc and the design lint are clean, and the gate rewrapped comments, which are in the commit. I did not run the app end to end or the rest of the suite. I also did not call keep_plan or estimate; no "by <time>" is claimed.

  • As of: the page shows as of HH:MM UTC under the sentence, as a hint paragraph with no new CSS class. The JSON carries asOf as an ISO time. The time is taken once per 10 s hold, so the markup is still built once per hold.
  • Since: a slow or down row reads down since 14:02 UTC or slow since 13:00 UTC. The time is the earliest moment any cause on that row was first seen. An ok row says nothing.
  • Size and script: the page is still signed-out and script-free, and the existing size test still keeps it under 6 KB.
  • Terminal and docs: the terminal Status screen reads the same words, so it now shows the as-of line and the row times too. I also updated the /status line in docs/STATUS.md.
  • Tests: the new ones cover the as-of time on an ok page, since on a down row and on a slow row, and the as-of time and its ISO form in the page and JSON. test/status-page.test.ts also needed edits for the new shapes.

JSON shape change: each entry in rows is now {state, since?} instead of a bare word. I found no other reader of the JSON in src, but an outside client of /status would need to follow the change.

Left out:

  • The billing-records row (broken ledger) and the "forge is restarting" row have no known start time, so they say only slow, with no since. I did not invent one.
  • A down state with no named cause still says plain Down.

The push was refused at first for lacking a "Try:" commit, so the branch ends with an empty commit that says how to try it. To try it, open /status, or fetch it with Accept: application/json.

commented

<!-- look-pages 01b96bfea767 --> Look pages for 01b96bf, from the gate:

  • look pages (none): this pull changes src/web/pages/status.ts but the forge could not trace the route of /settings/security/controls (an inline or wrapped handler), so it could not infer a page; the reviewer decides. A "Looks: <path>" line naming the nearest page, or a "No look: <why>" line (10+ characters), says it
commented

I've pushed the fix for the "both doors" failure on #13858, and bun scripts/gate.ts now prints nothing locally, so no rule fires. I haven't seen the forge's check run on this push yet.

  • Both doors: I added docs/features/status-time.md, the how-to for the as-of time and the "since" on a row. It's listed in docs/features/README.md. The terminal already shows the same words, since src/tui/screens/status.ts reads the same function.
  • A second rule: adding a feature doc tripped the "pipeline first" rule. The latest commit carries a Direction: line saying why this goes ahead of pipeline work.
  • The look-pages note: the "look pages (none)" line couldn't trace a route for /settings/security/controls. The gate treats it as a note for the reviewer, not a failure. I put a "No look:" line in the how-to commit: the page gains one line of text, with no layout or component change.
  • Tests: test/feature-orphans.test.ts and test/status-page.test.ts pass (20 tests).
Approved

Preview checked: /status shows "as of HH:MM UTC" under the sentence in a hint paragraph (no new class, no script, tiny page); JSON carries asOf and per-row {state, since?}. Terminal reads the same function; how-to is in docs/features/status-time.md, not README. Tests cover as-of on ok, since on down and slow rows. Next two things: (1) the rows JSON changed from a bare word to an object, so note it in the pull and check any outside client; (2) billing records and restart rows say no since — give the ledger a first-seen time so they can.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs