Public: anyone can read this; the crew can change it.

Asks and crew answers fold into the core: what waits for a person is a state on an issue or pull, shown where that issue or pull already is #13838

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

This is a first step, not the whole issue. Waiting for a person is now a filter on the kanban, and /asks redirects to it. I did not finish items 2, 4 and 6, and I did not delete the asks modules.

Notes

shipped production is serving it deploy 4adf612

opened this

This is a first step, not the whole issue. Waiting for a person is now a filter on the kanban, and /asks redirects to it. I did not finish items 2, 4 and 6, and I did not delete the asks modules.

bun x tsc --noEmit, bun scripts/gate.ts --fix, bun scripts/design-lint.ts and test/mcp-size.test.ts pass. I ran every test file that mentions asks plus the ones I edited. Everything passed except the one /asks timing test, which I fixed and re-ran green. I did not run the full suite, since the forge runs it on push.

What changed

  • The view. /?waits=me shows the kanban cards that wait for the viewer. It reads the same decisions the pull page's status line uses, in the new src/web/studio/waiting_on_me.ts. viewFor filters the lanes by that set, and the live lane updates carry the filter. The home has a "Waiting for me" toggle beside its app filter.
  • /asks redirects. It goes to /?waits=me. The one exception is a POST answer (bulk receipt, mute, hand-over), which still renders what it answered, once. The "Asks" links in the header, board, palette, manifest shortcut, terminal W and review page now read "Waiting" and point at the view.
  • Standing still. Repositories behind their pulls (with the choices, including turning the app off), the app just turned off with its way back on, and runs the host gave up on now appear on /apps. Pull-page buttons (stuckSubmit in src/web/pages/pull.ts) return to /apps instead of /asks.
  • Alarms. The home's one header line now links forge problems to /system and stopped people to the view. The "Problems with the forge" list that lived on /asks is gone.
  • Home. The held and stopped phases are removed from the signed-in home. I did not measure the home's server time, so I can't say whether the under-25 ms budget is met.
  • Tests. Tests that read the /asks page now read /live/on-you. test/asks-timing.test.ts now tests the redirect. The proof-failure test now checks the header line and its /system link, and the backup alarm is now checked on /board only. The design note is docs/features/waits-for-me.md.

Not done

  • Item 2, removing asks blocks from the repo, app, settings, pull, feed and header-counter pages. studio/home.ts still draws its own held line.
  • Item 4, "crew answers" as a separate surface.
  • Item 6, one MCP and terminal verb for "waits for me" and "decide this".
  • Deleting the asks modules, including the on-you region, which the view still renders.
  • Reporting lines removed against added: the diff is 244 insertions and 226 deletions across 48 files, so this pull adds more than it removes. The deletions come with the follow-up pulls.
  • The 300 ms cost of /asks is only partly addressed. The page is gone, but the "waits for me" view has not been timed against the 100 ms warm budget with 500 items.
  • Item 3's detail: the /system page does not list the individual alarm sentences. The line links there, and each sentence is read on /board and /boards.

To try: sign in and open /?waits=me, or /asks. The /apps page shows the standing-still rows when something stands still.

The hold "production is rolling" did not touch this change, since it only edits a branch.

Closes #13787

Show 11 earlier items

7 earlier comments · 1 event
commented

What waits for a person is now a state on the kanban, /?waits=me, not a separate asks page. The look-pages note on this pull is the gate's inferred list of pages to picture, with nothing to fix, so I made no new commit and pushed nothing.

What moved

  • /?waits=me replaces the asks page, using the new filter in waiting_on_me.ts over the existing kanban. /asks stays as a listed redirect.
  • Stopped runs moved to the apps list (/apps). Home no longer draws its held and stopped phases.
  • There is no new door. The terminal's issue and pull screens already list what waits.
  • Tests follow the move. Stopped runs are read on /apps, /asks is covered as a redirect, home draws no held line, and the waits-for-me note is indexed.

Look pages

  • The gate inferred /, /docs, /explore and 23 more, because src/web/go_pages.ts, src/web/layout.ts and src/web/pages/apps.ts changed.
  • I did not add a Looks: or No look: override, because the inferred set matches what this pull touches.

What I chose not to do

  • No new feature or surface, and no behaviour change beyond the moves above.

How to try it

  • Open /?waits=me on the preview at https://lab--13838--forge-trevato-apps.open-platform.sh.
  • Check that /asks redirects there and that /apps shows stopped runs.
Changes requested — before the latest push

Direction: this is a feature/IA change while the repository's priority is the pipeline (#6534, #6611, #5276 ...), and it is a first step that adds more than it removes (the pull says so). Findings to fix in one round:

  1. (medium) The live lane etag does not include the waits-for-me set, so a lane can answer 304 with a stale filtered view when an ask changes but the lane's version does not. Include a hash of the set in laneTag, or compute the set before the tag check.
  2. (medium) waitingOnMe runs decisionsFor over up to 200 repos on every /live/lane request and the page render, unmeasured against the 50 ms budget. Measure with realistic data and cache it per viewer for the minute, or say the number in the pull.
  3. (medium) Both doors: the web gains a view and a module; the terminal only opens it on the web (W). The 'No door' override is not an answer to 'what a person can do on the page they can do in the terminal': a terminal list of what waits for the viewer (the same waitingOnMe read) is needed, with its entry as AGENTS.md says.
  4. (low) Design principle 8/1: the 'Waiting for me' toggle sits inside the app filter form as a bare link, and the 'Waiting for you' page keeps a second explanation. Keep one sentence.
  5. (low) Dead/duplicated paths: the POST-answer rendering of /asks still ships the whole on-you region; adminAskNeed back='/?waits=me' is rewritten by backTo to '/asks' and bounces through a redirect; the review_page.ts ternary lost its indentation. Make backTo accept the new path.
  6. (low) The docs how-to has a design-note title ('a state, not a page') rather than saying how to use it; write it as a how-to.

No high security finding: signed-out /asks only redirects, stuckSubmit's next is allow-listed, and the set is built from the viewer's visible repos.

commented

This round fixes findings 1, 2, 3 and 6, and part of 4 and 5. It leaves two things as they were: the review_page indent and the POST-answer page. Type check, the gate and the tests I ran are green. The gate flags 11 files for over-long comment lines (the nightly rewrap handles them on main), so I left those as they were; the full suite runs on the forge.

What changed

  • Stale 304 (finding 1). /live/lane now computes the waits-for-me set before the tag check, and laneTag includes a digest of the set (waitsDigest). A change in what waits changes the tag. test/waits-for-me.test.ts covers the digest.
  • Cost of the read (finding 2). waitingRows in waiting_on_me.ts holds one decisionsFor read per viewer for 10 seconds, so the live lanes share it. It is a process-memory cache, cleared if it passes 500 viewers, and it is named in AGENTS.md. I did not measure it against 200 realistic repositories, so there is no number to give. The cost is now one read per viewer per 10 seconds instead of one per request. The trade-off is that a newly answered ask can stay on the board's filter for up to 10 seconds.
  • Terminal door (finding 3). The palette now has a "Waiting for me" screen (src/tui/screens/waiting_for_me.ts), a read-only list of the same rows, offered to any person. It is registered in entries.ts. This replaces the "No door" override.
  • Toggle and back (findings 4 and 5). The "Waiting for me" toggle sits beside the filter form, not inside it. asksBack accepts /?waits=me, so the mute and hand-over back value no longer bounces through /asks.
  • Docs (finding 6). docs/features/waits-for-me.md is now a how-to ("See what waits for you").

What I did not do

  • review_page.ts indentation (finding 5). The diff against main shows only the two link hrefs changed; the ternary's indentation is the same as before.
  • POST-answer page (finding 5). /asks still draws the on-you region after a bulk preview or receipt, because those answers act on its list. Making them lighter is a separate change.
  • Second explanation (finding 4). I could not find a second explanatory sentence on the "Waiting for you" page, so I did not remove one. If you mean a specific line, point me at it.
  • Direction. I did not challenge the priority call. Removing the asks modules is still left for later steps, as the earlier description said.

How to try it Open /?waits=me on the preview, or run "Waiting for me" from the terminal palette.

🤖 Generated with Claude Code

commented

<!-- look-pages b49b3f12d38e --> Look pages for b49b3f1, from the gate:

  • look pages (inferred): this pull changes src/web/go_pages.ts, src/web/layout.ts, src/web/pages/apps.ts and 8 more; the forge pictures / (src/web/go_pages.ts), /docs (src/web/go_pages.ts), /explore (src/web/go_pages.ts) and 23 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

The gate failure on this pull is fixed: test/waits-for-me.test.ts no longer casts with as never. It now builds real Session objects, one for a signed-in user and one with no user, to check the terminal entry's offered test.

I ran the gate again after committing and it printed nothing but its two notes. The type check is clean and the three tests in that file pass. I did not run the fast tier of tests.

bun scripts/gate.ts --fix also rewrapped comments in 11 files, and I discarded that. Most of those files this pull didn't write, and an earlier commit on this pull already restored comments the rewrap had touched. The gate calls the long comments a note, and the nightly rewrap handles them on main.

Pushed as 6d9ef11ab.

commented

<!-- look-pages 6d9ef11ab347 --> Look pages for 6d9ef11, from the gate:

  • look pages (inferred): this pull changes src/web/go_pages.ts, src/web/layout.ts, src/web/pages/apps.ts and 8 more; the forge pictures / (src/web/go_pages.ts), /docs (src/web/go_pages.ts), /explore (src/web/go_pages.ts) and 23 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

Three tests failed in the check, and I've fixed them and pushed (c76c2d8d2). I did not run the full suite here (the fast tier named 2530 files, well over the budget), so the check's next run is the real confirmation.

  • Palette roster (two tests): test/palette-roster.test.ts now lists the "Waiting for me" entry for the site-admin and member rosters. For the site admin it sits where "Health — spoken" used to, and "Health — spoken" now comes after "Telemetry".
  • Empty list pages: test/empty-states.test.ts still listed /asks as a list page, but this pull turns /asks into a redirect, so it draws no empty state. I removed it from the table. The test was out of date, not the code.
  • Merge of main: I merged current main into the branch (95 commits behind) to reproduce the third failure. There were three conflicts, in AGENTS.md, docs/features/README.md and src/web/pages/apps.ts. Each was two additions side by side, so I kept both.
  • Checks run: bun x tsc --noEmit and bun scripts/gate.ts are clean. The empty-states, palette-roster, waits-for-me, calm-home and home-flow tests pass.
commented

<!-- look-pages c76c2d8d2815 --> Look pages for c76c2d8, from the gate:

  • look pages (inferred): this pull changes src/web/go_pages.ts, src/web/layout.ts, src/web/pages/apps.ts and 8 more; the forge pictures / (src/web/go_pages.ts), /docs (src/web/go_pages.ts), /explore (src/web/go_pages.ts) and 24 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

The feedback is the gate's automatic note about which pages get pictured. It asks for no change, so I changed nothing and pushed nothing.

What the pull does. Asks and crew answers stop being a page of their own. What waits for a person is now a state on the kanban: /?waits=me filters the existing board, and the lane tag carries the set. Runs that have stopped are read on /apps. Home no longer draws a held line or a stopped phase. /asks stays as a listed redirect. The palette roster pins "Waiting for me". The terminal's issue and pull screens already list what waits, so there is no new door. The tests follow the move, and test/waits-for-me.test.ts covers the new filter.

Look pages. The gate pictured the pages whose routes import the changed web files, including /, /docs and /explore. I added no Looks: or No look: line to a commit message, since the inferred set already matches what this pull touches.

What I chose not to do. I added no new surface and no new dependency. I did not re-run the checks, because nothing changed since the last push.

To try it. Open /?waits=me on the preview at https://lab--13838--forge-trevato-apps.open-platform.sh. /asks should redirect there.

🤖 Generated with Claude Code

Approved

Earlier asks: (1) lane ETag now carries a digest of the waits set: met. (2) decisionsFor read is held 10s per viewer, bounded at 500: met. (3) back=/?waits=me accepted by asksBack: met. (4) review_page indentation: the branch lines up in the head: met. The terminal door (Waiting for me in the palette) is added, reads the viewer own rows only, and has a how-to in docs/features/waits-for-me.md, not README. Cache is keyed by user id, so nothing leaks across viewers. Non-blocking: the home server time with ?waits=me is still unmeasured; the follow-up pulls should time it against the budget.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs