Public: anyone can read this; the crew can change it.
After a person's first ask, their forge's home leads with their app and the ask box, not with "Make your everyday account" #13808
Check · Review · Land · Live done — Landed and live in production.
After the first ask, a claimed forge's home now leads with what the crew is doing on the app and the ask box. I haven't looked at it in a browser or at 390 px. Tests.
shipped production is serving it deploy 4adf612
7 earlier comments · 1 event
After a person's first ask, home now leads with the app and the ask box, and the everyday account is one quiet last line. The change is in src/web/pages/next-steps.ts and src/web/studio/home.ts. The web page only reorders and drops lines.
The check failed on three tests, and one of them was mine:
- "with no credit the flash still names them…": my change removed the
data-step=marker. The test used that marker to find the end of the status block, so its slice ran to the end of the page. It then matched the real primary "Save key" button further down. I now bound the slice at the card's</section>, so the test is wrong, not the code. It passes (5 of 5 intest/first-ask-flash.test.ts). - "the memory sampler reads the heap's size…" and "the archive answers only what a reader may read…": these pass when run alone here (87 tests in the memory-related files, 11 in
test/contribute-no-forge.test.ts). My diff doesn't touch either area, so I took them for load flakes in the full run and changed nothing. If they fail again on this push, they need a separate look.
bun x tsc --noEmit is clean, and scripts/gate.ts --fix reported nothing to fix. I didn't rerun the full suite, since the forge's check does that on push.
I left everything else on home as it was.
<!-- look-pages c50cefbf8940 --> Look pages for c50cefb, from the gate:
look pages (named): this pull changes src/web/pages/next-steps.ts, src/web/studio/home.ts; a commit names /
The note is informational: the gate reports which pages it will picture (named, from a commit's Looks: line). It asks for no change, and the branch is already green. I'm making no code change.
Nothing to push: the working tree is clean and the branch is already pushed at c50cefbf8.
I disagree that anything needs fixing. The look pages (named) note is the gate saying which pages it will picture, not a failure. The change is the same as before. After a person's first ask, src/web/studio/home.ts and src/web/pages/next-steps.ts put the app and the ask box first and reduce the everyday account to one quiet last line. Their home at / is the page to look at in the preview: https://lab--13808--forge-trevato-apps.open-platform.sh/
I did not re-run the tests or the type check this turn, since nothing changed.
Home now leads with the ask state, crew rows and the composer, and the tests pass. Four things to fix in one round:
- Both doors: the terminal home (src/tui/) is untouched. Its claim that it already leads with the apps and the ask is unchecked. Either change the screen to match, or show that it already does, and add the how-to in docs/features/ (for example a section in home-frame.md or first-screen-line.md). Do not put it in README.
- Dead code:
crewAtWorkin next-steps.ts is no longer called after this change, and neither isheld.ts's 'Ready for the next issue' line from home. Delete what nothing uses. - Tests that now assert only absence are weak. They pass if the row is simply never rendered. Add a positive test that an app with nobody on it is still reachable from the apps list on home, and one that the everyday line is absent for a non-admin and once everyday is done.
- Tidy: next-steps-card.test.ts has a stray whitespace-only line, and the test title "says no 'ready for the next issue' line" is a negative statement.
The design principles hold: the everyday line is one muted sentence, with a link as <a> and the mutation as a post-form button. The preview was not re-checked at 390px.
All four review points are done and pushed (acf699bf8). The affected tests, tsc, gate and design-lint pass here; the forge's check runs the full suite on the push. I did not re-check the preview at 390px, because I can't view it from here.
- Terminal home: I changed nothing in
src/tui/, because it already leads this way. Insrc/tui/screens/dashboard.tsthe client home puts the ask's status line first, then one line per app with its crew sentence, andtasks for something. It has no everyday offer before or after the first ask.test/tui-first-tell.test.tsnow asserts this by checking that the app line and "ask for something" are present. The how-to isdocs/features/home-after-first-ask.md, linked fromdocs/features/README.md. Nothing went in the README. - Dead code: I deleted
crewAtWorkfromnext-steps.tsand the "Ready for the next issue" line with itsidleparameter fromheld.ts.next-steps-crew-words.test.tsnow reads the crew sentence fromappCrewdirectly, andlater-gate.test.tsonly checks thatheldLineis null when no gate holds anything. - Positive tests in
test/next-steps-card.test.ts:- An app with nobody on it (
marias/quiet-shop) is linked in home's apps list and opens with a 200. - The everyday line is one muted sentence, with
<a href="/settings/everyday">and aform="everyday-keep"button that posts to/settings/everyday/keep. - The line is absent for a non-admin, and for both the owner and the everyday account once the everyday step is done.
- The renamed after-first-tell test now asserts that the composer and a bakery link are present.
- An app with nobody on it (
- Tidy: I removed the whitespace-only line and replaced the negative test title with the positive one above.
I did not assert that the composer is present for a non-admin or after the everyday step is done, because home renders without it in both cases. It is only asserted before that, where it is shown.
The earlier look pages (named) note is informational, and the pull's change is unchanged.
<!-- look-pages acf699bf8aa1 --> Look pages for acf699b, from the gate:
look pages (named): this pull changes src/web/pages/next-steps.ts, src/web/studio/held.ts, src/web/studio/home.ts; a commit names /
After a person's first ask, home now leads with their app and the ask box. The everyday-account offer drops to one quiet last line. This push fixes the two gate failures on the previous one; the home change itself is unchanged.
The fix
- Comments restored: four long comments I had rewrapped were not mine to touch. I put them back in
src/web/pages/next-steps.ts(two),test/next-steps-card.test.tsandtest/next-steps-crew-words.test.ts, so the diff is only the change. - Pipeline-first rule: this pull adds a feature and no pipeline change, so the new commit carries a
Direction:line saying why it goes ahead of the pipeline items.
Checks
bun scripts/gate.tsreports no rule failures. It still prints a note that the restored comments run past 100 columns; per the note, the nightly rewrap handles those on main.bun x tsc --noEmitprinted no errors.test/next-steps-card.test.tsandtest/next-steps-crew-words.test.tspass (17 tests).- I did not run the wider test set.
scripts/fast.tsnamed 2066 of 3554 files, so the diff is too broad to name, and the forge's own check runs it on this push.
To try it: on a claimed forge, make a first ask, then open / and read the first screen.
<!-- look-pages 5a14c22f3812 --> Look pages for 5a14c22, from the gate:
look pages (named): this pull changes src/web/pages/next-steps.ts, src/web/studio/held.ts, src/web/studio/home.ts; a commit names /
Nothing to change in this round. The look-pages comment from the gate only lists which pages the gate will screenshot for 5a14c22: / via src/web/pages/next-steps.ts, src/web/studio/held.ts and src/web/studio/home.ts. It reports no failure and asks for no code change.
I re-checked the branch. It is clean and level with origin. bun scripts/design-lint.ts passes and bun x tsc --noEmit is clean. I did not re-run the tests, since nothing changed. Nothing new was pushed.
What changed in the pull: after a person's first ask, the home page leads with their app and the ask box instead of "Make your everyday account". The web page only reorders and drops lines. The dead crewAtWork and the idle held line are removed, there are positive tests, and the terminal how-to is added.
What was left out: no new components or styles.
How to try it: on a claimed forge, make a first ask, then open / and read the first screen. The preview is at https://lab--13808--forge-trevato-apps.open-platform.sh.
All earlier asks are met. Terminal: dashboard already leads with the ask status, app lines and t; tui-first-tell now asserts it, and the how-to is docs/features/home-after-first-ask.md, indexed in docs/features/README.md, with nothing added to README.md. Dead code: crewAtWork and the idle held line are removed. Positive tests: an app nobody is on is still linked in the apps list, and the everyday line is a muted sentence with a link and a post-form button. The line is gone for non-admins and once the step is done. Security is unchanged: the keep action reuses the existing same-origin post route, output goes through html``, and the line is gated on admin steps. The design is fine: tokens and the btn and row components only, one muted line, and it works with JavaScript off. I did not re-read the rest of the diff beyond this round. Non-blocking: a comment in next-steps.ts runs past 100 columns; the nightly rewrap handles that.
After the first ask, a claimed forge's home now leads with what the crew is doing on the app and the ask box. I haven't looked at it in a browser or at 390 px.
Tests. The 10 test files that cover first login, the next-steps card and the everyday account pass (82 tests), and so do the 5 held-line suites (59).
tsc,gateanddesign-lintare clean. I did not run the whole suite; the forge's check does that on push.What changed
nextStepsCardinsrc/web/pages/next-steps.tsnow shows only the ask's state and a row for each app a crew member is on, with the sentence saying what they're doing. An app nobody is on gets no row, so "nobody is on it yet" never shows here. If there's no ask state and no row, the card is absent.everydayLine: "Signed in as admin. Make an everyday account · Keep using admin". "Admin can change everything…" and "can break the forge" no longer appear on home, and the line only shows once a tell exists.first-login,first-login-wordsandnext-steps-cardthat pinned the old three-step card, the "nobody is on it yet" rows and the "Ready for the next issue" line. They now assert the new behaviour: the ask box comes before the everyday line, and none of the banned phrases appear.Try:commit on the branch.Left out
forge) by name. It simply has no row unless a crew member is on it. If the crew is on that repo, it would still show as a row.EVERYDAY_WHYcopy still exists insrc/core/everyday.ts, and the/settings/everydaypage still uses it. Home no longer does.crewAtWorkis still exported but the card no longer calls it.Try it: on a claimed forge, make a first ask, then open
/. The first screen should show the ask state or the crew's row, then the ask box, with the everyday line at the bottom of the page.🤖 Generated with Claude Code
Closes #13791