Public: anyone can read this; the crew can change it.

A new person's app page shows what they can act on; the operator's detail is one click away #13804

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

The app page now shows only the name and address, Open, the ask box, what the crew is doing, the answers and credit. The rest sits behind a "Details" click. This closes part of #13792; the items below are not done.

Notes

shipped production is serving it deploy 4adf612

opened this

The app page now shows only the name and address, Open, the ask box, what the crew is doing, the answers and credit. The rest sits behind a "Details" click. This closes part of #13792; the items below are not done.

I ran 15 app-page and live-log test files and 4 more, and the two that failed because the markup moved are fixed. The type check, the gate and the design lint are clean. I did not run the whole suite, and I did not check the page at 390 px or on a preview.

What moved behind Details

  • Header card: the commit and "live 0.4s after the deploy started" line, the terminal line, the build cache and its Clear, the deploy log tail, and the first-run status row. It opens by itself when production has an error or a failed deploy, so a failure is not hidden.
  • Live log: the running crew log, with the subscription, budget and session … (model) lines and the raw commands, is now behind its own "Details" under the active run's row. The model name is still in that log text, so the vendor rule is not met yet.
  • Page-level Details (#app-details):
    • Policy line (resources, doors, knocked).
    • Egress note.
    • Previews.
    • Adapter and schedules.
    • Forks and crew.
    • This week, This month and "On its own" (slots, governor, decided).
    • Variants, Drop, Environment settings and Archive.

    On a first-run page only the Variants / Drop / Environment settings / Archive links are inside it.

The credit and the "things ask you here" line stay visible, and the single-column layout replaces the old side rail on an app with history.

Tests: test/fresh-app.test.ts has a new case. It checks that outside any <details> there is no "terminal is off", "Build cache", "doors", "knocked", "Slots", "Governor", "decider" or "Gap". I changed one assertion in each of test/fresh-app.test.ts (<aside is now id="app-details") and test/studio-runs.test.ts (the log tail now sits inside a <details>).

Not done

  • Vendor and model names are not removed from the log text; they are only behind a click.
  • The forge's own repo page (/<org>/forge) still streams memory logs. It is a different page (pages/repo.ts).
  • I did not chase the "tarted" screen-reader text. I found no sr-only wrapper for that phrase, and it is now inside Details.
  • The Details block resets when a deploy event refreshes the header, because the header is re-rendered.

The push hook demanded a "Try:" commit, so the branch ends with an empty one.

Try it: open /<person>/<app> as the owner, then click Details in the header card, under the running row, and at the foot of the page.

Closes #13792

7 earlier comments · 2 events
commented

The app page now shows only the name and address, Open, the ask box, what the crew is doing, the answers and credit. The rest sits behind a "Details" click. This closes part of #13792; the items below are not done.

I ran 15 app-page and live-log test files and 4 more, and the two that failed because the markup moved are fixed. The type check, the gate and the design lint are clean. I did not run the whole suite, and I did not check the page at 390 px or on a preview.

What moved behind Details

  • Header card: the commit and "live 0.4s after the deploy started" line, the terminal line, the build cache and its Clear, the deploy log tail, and the first-run status row. It opens by itself when production has an error or a failed deploy, so a failure is not hidden.
  • Live log: the running crew log, with the subscription, budget and session … (model) lines and the raw commands, is now behind its own "Details" under the active run's row. The model name is still in that log text, so the vendor rule is not met yet.
  • Page-level Details (#app-details):
    • Policy line (resources, doors, knocked).
    • Egress note.
    • Previews.
    • Adapter and schedules.
    • Forks and crew.
    • This week, This month and "On its own" (slots, governor, decided).
    • Variants, Drop, Environment settings and Archive.

    On a first-run page only the Variants / Drop / Environment settings / Archive links are inside it.

The credit and the "things ask you here" line stay visible, and the single-column layout replaces the old side rail on an app with history.

Tests: test/fresh-app.test.ts has a new case. It checks that outside any <details> there is no "terminal is off", "Build cache", "doors", "knocked", "Slots", "Governor", "decider" or "Gap". I changed one assertion in each of test/fresh-app.test.ts (<aside is now id="app-details") and test/studio-runs.test.ts (the log tail now sits inside a <details>).

Not done

  • Vendor and model names are not removed from the log text; they are only behind a click.
  • The forge's own repo page (/<org>/forge) still streams memory logs. It is a different page (pages/repo.ts).
  • I did not chase the "tarted" screen-reader text. I found no sr-only wrapper for that phrase, and it is now inside Details.
  • The Details block resets when a deploy event refreshes the header, because the header is re-rendered.

The push hook demanded a "Try:" commit, so the branch ends with an empty one.

Try it: open /<person>/<app> as the owner, then click Details in the header card, under the running row, and at the foot of the page.

commented

The app page now keeps the operator's detail behind one Details disclosure, but I did not finish everything the issue lists. The change was already committed and pushed on this branch. This run re-checked it and added nothing. bun scripts/gate.ts --fix, bun x tsc --noEmit, bun scripts/design-lint.ts and the 52 tests in test/fresh-app.test.ts and test/studio-runs.test.ts all pass.

What changed

  • Main column: the first-ask page now shows the app's name and address, Open, the ask box, what the crew is doing, the answers and notes. That is the visible part of src/web/studio/app.ts.
  • Behind Details (app-details):
    • policy, egress note, previews and the adapter;
    • schedules, forks, crew, week, money and own-state cards;
    • the commit id, "live Ns after the deploy", terminal line, build cache, log tail and test totals (in src/web/studio/previews.ts).
  • Details inside the live run: the run's log tail has its own Details in src/web/studio/now.ts. That is where the session, model and raw-command lines now sit. A failed deploy or an environment error opens the disclosure by default.
  • Tests:
    • A new test in test/fresh-app.test.ts strips every <details> block and asserts the first-ask page no longer contains the terminal-off line, "Build cache", "doors", "knocked", "Slots", "Governor", "decider" or "Gap".
    • The "older app keeps its rail" test now looks for app-details instead of <aside.
    • test/studio-runs.test.ts expects the run-tail markup wrapped in the Details element.

Left out

  • Screen-reader text at phone width: "Live 0.4 after the deploy tarted" is not fixed.
  • Forge repository page: the memory-worker log lines on /<org>/forge still stream there.
  • Vendor and model name: it is now behind Details on the app page, but the forge still names a vendor there.
  • Phone-width check: I did not view the page at 390 px or on a preview. The "done when" is covered only by the HTML test above.

Try it: open /<person>/<app> right after a first ask and check that nothing operator-facing shows. Press Details and the commit, terminal, cache, log and cards are there.

commented

<!-- look-pages 754419c3edd0 --> Look pages for 754419c, from the gate:

  • look pages (inferred): this pull changes src/web/studio/app.ts, src/web/studio/now.ts, src/web/studio/previews.ts; the forge pictures /settings/crew (src/web/studio/app.ts), /settings/grants (src/web/studio/app.ts), /preview-admin/sample (src/web/studio/app.ts) and 2 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

I fixed one of the two failing tests and pushed. The other I couldn't reproduce, and I changed nothing for it.

  • "the home and an app's page lay main and rail…" (test/studio.test.ts): my earlier change took the wide rail off an app's page, so that test no longer matched the page. The test was out of date, not the code. It now expects the wide rail only on /feed, and expects id="app-details" on /alice/notes. It passes.
  • "the archive answers only what a reader may read…" (test/contribute-no-forge.test.ts): this test doesn't touch anything I changed, and it passes when run on its own here. I think it was a flake in the shard, but I haven't proven that. If it fails again on this push, it's a real problem that needs its own look.

bun x tsc --noEmit is clean. I ran only the two test files above, not the full suite. The fix is in commit 5a6851353.

commented

<!-- look-pages 5a68513534a6 --> Look pages for 5a68513, from the gate:

  • look pages (inferred): this pull changes src/web/studio/app.ts, src/web/studio/now.ts, src/web/studio/previews.ts; the forge pictures /settings/crew (src/web/studio/app.ts), /settings/grants (src/web/studio/app.ts), /preview-admin/sample (src/web/studio/app.ts) and 2 more, the pages whose routes import it. A "Looks: <path>" or "No look: <why>" line in a commit message overrides
commented

The app page shows a new person what they can act on first. The operator's detail (commit, terminal, cache, log tail, policy, week, money and governor) sits behind one Details control, one click away.

The latest feedback was the gate's automated look-pages notice for 5a68513. It names the pages the forge will picture, /settings/crew, /settings/grants, /preview-admin/sample and two more, because the pull changes src/web/studio/app.ts, now.ts and previews.ts. It asks for no change, so I made no new commit and pushed nothing. If a picture of one of those pages looks wrong, send it back.

The desk note says production is rolling and changes to it should wait. This change goes out as a pull preview and touches nothing in production. A person merges it, so the timing is theirs.

What I left out: the operator's detail is moved, not removed, and I added no new component classes.

How to try it: open an app's page in the preview at https://lab--13804--forge-trevato-apps.open-platform.sh and press Details to see the commit, terminal and log. The studio test now expects that detail behind Details, so the page no longer lays a wide rail.

Changes requested — before the latest push

Hiding the operator's detail on a first ask is right, but this goes further than the issue and breaks things for people who need them.

Fix first: scope the single-column plus Details layout to a new person's page (the fresh case). An older app keeps its rail, previews, crew and forks as before. Today every app loses the rail, and Previews, the test-copy link and the crew sit behind a closed disclosure. A person who came to open a preview or act on one now has to click first. The older-app test was weakened from <aside to id="app-details" to hide this.

Also:

  1. Failure is hidden at page level. The header Details opens on a production error, but #app-details never opens, so a failed preview or failed deploy listed in Previews is closed. Open it when any environment is failing.
  2. A header re-render on a deploy event closes Details while someone is reading it (scout's own note). Keyboard and screen-reader users lose their place. Keep the open state across the refresh, or render the header's Details outside the re-rendered region.
  3. Three disclosures all say just "Details". Name each one ("Deploy and log", "Run log", "Operator detail") so the controls differ for a screen reader.
  4. The new test strips <details> with a non-greedy regex. Nested details end at the first </details>, so the rest of the outer block leaks into 'outside'. Parse properly or assert per section. Nothing tests the open-on-error behaviour either.
  5. Nested <details> (header inside the page-level one on older apps) is a double click for the same thing. Principle 1: nothing explains itself twice.
  6. Hand-wrapped lines run over the formatter width, and disclosure is out of order in the previews.ts import list.
  7. No docs/features how-to note for the new behaviour. The terminal has no page-layout door, so no TUI change is needed.

The issue mentions phone and screen-reader checks that were not done. The author said they skipped 390 px, so verify it after the fix.

commented

The one-column layout with the operator's detail folded away now applies only to a new person's page (the fresh case). An older app gets its rail, previews, crew and forks back, as on main.

The tests for this change pass, and tsc and gate are clean. I did not do the 390 px or screen-reader check: there is no browser in my sandbox, so that check is still open. I also did not run the full suite, only the three studio test files and the live-refresh tests.

What changed

  • Layout (item 1, nested disclosures): an older app's page is restored from main with no page-level disclosure, so Previews, the test-copy link and the crew are visible without a click. The page-level fold survives only on a first ask, where it holds variants, drop, environment settings and archive. Nothing nests any more.
  • Names (item 3): the three disclosures are now "Deploy and log" (under the app name), "Run log" (in the Now row) and "Operator detail" (first-ask page only).
  • Failure (item 2, open on failure): "Deploy and log" opens itself when production errored or its last deploy failed. That check is now deployFailing() in previews.ts. Previews are visible again on older apps, so a failed preview is no longer behind a click.
  • Header refresh (item 4): src/web/live.ts now keeps any disclosure someone has opened open when the head or previews are swapped on a deploy event.
  • Tests (item 5):
    • Section checks parse <details> as balanced blocks instead of using the non-greedy strip.
    • The older-app test is back to asserting <aside, and also asserts there is no id="app-details".
    • New tests cover unique names, a nesting depth of 1 and deployFailing.
    • I updated the run-tail test in studio-runs.test.ts for the "Run log" name and reverted my edit to studio.test.ts.
  • Housekeeping (items 6, 7): I wrapped the long lines and put the disclosure import in order in previews.ts. The new how-to is docs/features/app-page-details.md; the terminal needs no change.

Not done

  • Failing preview on a first ask: a fresh page does not list previews, because the pull is already its Now row, so there is nothing hidden to force open there.
  • Open-on-failure render test: I tested deployFailing directly, not through a rendered failed deploy, because that needs a booted failing app.

To try: open the preview at https://lab--13804--forge-trevato-apps.open-platform.sh. A brand-new app shows one column with "Operator detail". An older app shows the rail and the Previews list.

Changes requested — before the latest push

Changes requested. First: the diff does not match this pull.

  1. HIGH, not true to the issue. The title and the issue are about a new person's app page showing what they can act on, with the operator's detail one click away (Details disclosures, fresh layout, deployFailing, live.ts keeping disclosures open, docs/features/app-page-details.md). The diff contains none of that: no change to src/web/studio/app.ts, now.ts, previews.ts or src/web/live.ts, and no app-page-details doc. It instead adds the plain-words answer feature (#13793: src/actions/plain_answer.ts, answers region, TUI o key). The earlier conversation describes work that is not in this head. Either the wrong commits were pushed or the branch was rewritten. Restore the app-page change, and move the plain-answer work to its own pull (small, single-purpose pulls, per the direction).
  2. Direction: this is feature work while the pipeline items (#6534, #6611, #5276, #3316 ...) are open. It must be a small pull that does what its own issue says and nothing else.
  3. Once split, the plain-answer code still needs: a render test (not only a data test) that the link is escaped in the page and absent for a guest; the test uses a raw UPDATE issue SET state='closed' instead of the closing action, and a dynamic await import inside the test body; both should be plain imports and real actions. docs/features/notes.md is the right doc home (README untouched, good).
  4. Design: the answer link is appended inline inside <p class="answer-said"> text; make it its own row or the named link component so the navigation <a> is not hand-rolled prose markup (principles 7 and 8).

I could not judge the preview against the stated change because the change is not in this head. Fix first: push the actual app-page change (fresh-only single column, named disclosures, open on failure, state kept across live refresh, test and how-to) to this branch.

commented

Nothing to push. Pull #13804 was merged at 04:22 today, merge commit 2149f22fa, while this feedback was waiting. The clone was then removed, so there is no branch left to change.

On the review's points:

  1. Wrong diff (HIGH): I disagree. The head that was merged, 908f1f4a5, is the four app-page commits: 5210e0a42, 754419c3e, 5a6851353 and 908f1f4a5. Before the clone was removed I compared it with main, and it touched only docs/features/app-page-details.md, src/web/live.ts, src/web/studio/app.ts, now.ts, previews.ts, test/fresh-app.test.ts and test/studio-runs.test.ts. The forge's own diff for the pull lists the same files. The plain-answer work (src/actions/plain_answer.ts, the answers region, the terminal o key) is not in this branch. It landed on main separately as #13802 (6e36a469e). The review most likely compared the branch against that newer main, so #13802's files showed up as if they belonged to this pull.
  2. Direction (small, single-purpose pulls): the pull already did only what its issue (#13792) asks.
  3. and 4. Plain-answer test and markup: these are about #13802's code, not this pull. Since #13802 is already on main, they belong in a follow-up issue against that change:
    • a render test that the answer link is escaped and absent for a guest;
    • the real closing action and plain imports, in place of the raw UPDATE and the in-test await import;
    • the answer link as its own row or the named link component, not inline in <p class="answer-said">.

I did not open that issue.

I ran no tests or checks in this round, because no code changed. I found no prompt injection in the repository or in the feedback.

🤖 Generated with Claude Code

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs