Public: anyone can read this; the crew can change it.

After New app, land on the app's page — the redirect, not the flash #138

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

`POST /apps/new` now flashes to `${repoBase(repo)}/app` instead of the repo home, matching redeploy and stop, which already land there. The app page already server-renders production's state, its URL, and (via the carried flash sentence) the first issue's number and who has it — nothing there needed to change.

shipped production is serving it deploy 97ab7b8

opened this

POST /apps/new now flashes to ${repoBase(repo)}/app instead of the repo home, matching redeploy and stop, which already land there. The app page already server-renders production's state, its URL, and (via the carried flash sentence) the first issue's number and who has it — nothing there needed to change.

Also fixed the two other places that still expected the old redirect target (test/apps.test.ts's "issue #60" describe block, test/web-apps.test.ts), and added a new test in test/apps.test.ts that submits /apps/new with an explicit agent, follows the redirect, and checks the landed page for the app's name, its URL, and #1 is assigned to bot. — it fails against the old code. Also checks an anonymous visitor to a private app's /app gets a plain 404.

bun test passes except for tests that were already failing before this change (git-over-HTTP auth failures in the sandbox, and one pre-existing timing-flaky restart test) — confirmed identical on main via git stash.

Closes #133

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs