Public: anyone can read this; the crew can change it.

The claim page holds up on a phone: a margin, a reload that keeps the code, a password for the asking #13786

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Walking a claim link as a stranger on production, at 390 px and at desktop width. What the person met on /claim, and what this changes (src/web/pages/claim.ts): No margin on a phone. The text touched the screen edge: a page with no bar had no gutter.

Notes

shipped production is serving it deploy 59903fa

opened this

Walking a claim link as a stranger on production, at 390 px and at desktop width. What the person met on /claim, and what this changes (src/web/pages/claim.ts):

  • No margin on a phone. The text touched the screen edge: a page with no bar had no gutter. The form now sits in the page column, which has one. No new CSS.
  • A reload lost the link. The code leaves the address bar on load, so a reload (a phone does one whenever it brings the tab back) left the form on screen and then answered "This link does not work any more." for a good link. The tab now remembers the code (sessionStorage; it never returns to the address bar).
  • The username rule was not readable by the browser. [A-Za-z0-9._-] is an error under the v flag browsers compile pattern with (Chrome logs it and skips the check). The dash is escaped, here and on /start/claim.
  • Back after claiming told a signed-in person to sign in ("This link was already used… ask riley to send you a new one", riley being the reader). Signed in on a used link, they go home.
  • A password only after a passkey failed. Beside Create your passkey there is now Use a password instead, which brings out the same password field.
  • "Open it as trevato and you will take over trevato's account on this forge" read as an instruction. It now says: "Choose a username of your own. Choosing trevato instead takes over the account trevato set this forge up with, and everything already made under it."

Tests: test/claim-page-words.test.ts (the pattern compiles with v; the page script keeps the code; the password button; signed in on a used link → 303 /), and the two tests that pin the take-over sentence. 659 tests across every file that touches /claim or the passkey form pass.

Note: test/client-size.test.ts is red on main today, before this pull (CSS 44802 B against a 44800 B ceiling); this pull adds no CSS, and /claim JS is 23796 B against 24064 B.

No door: the claim link is opened in a browser; the terminal has no claim form to change. Try: open a fresh claim link on a phone, reload it, press Use a password instead, make the account, then press Back.

🤖 Generated with Claude Code

commented

<!-- look-pages fb9549205f9e --> Look pages for fb95492, from the gate:

  • look pages (none): this pull changes src/web/pages/claim.ts, src/web/pages/start_claim.ts but the forge could not trace the route of /settings/security/controls (an inline or wrapped handler), so it could not infer a page; the reviewer decides. A "Looks: <path>" line naming the nearest page, or a "No look: <why>" line (10+ characters), says it
Approved

Approved. The preview serves the claim form with the shell gutter, a username pattern that compiles under the v flag, the Use a password instead button, and a redirect home for a signed-in person on a used link. Everything works with JS off, since the password field is simply shown.

Two things I would do next:

  1. Clear sessionStorage claim-code once the claim succeeds or the link is dead. Today it outlives the claim in that tab.
  2. Replace the string-contains checks for sessionStorage and passkey-skip in claim-page-words.test.ts with a behaviour test of the script. They pass if the strings merely appear in the bundle.

The page is not in the look pages. The gate could not trace the route, so I did not read the claim screenshots. Judged from the served HTML only.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs