Public: anyone can read this; the crew can change it.

Automate a review finding as a lint or test: Direction: the owner's order is pipeline first (#6534, #6611, #5276, #3316, #621 #13753

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The "pipeline first" check already existed, and I extended it to cover the one gap I found. bun test test/direction.test.ts test/direction-refusal.test.ts passes (13 tests), bun scripts/gate.ts --fix and bun x tsc --noEmit are clean. I did not run the rest of the suite.

Notes

shipped production is serving it deploy 59903fa

opened this

The "pipeline first" check already existed, and I extended it to cover the one gap I found. bun test test/direction.test.ts test/direction-refusal.test.ts passes (13 tests), bun scripts/gate.ts --fix and bun x tsc --noEmit are clean. I did not run the rest of the suite.

What was already there. scripts/gate.ts runs directionRefusal, which uses src/kernel/direction.ts. A pull that adds a page, a terminal screen or a how-to without touching scripts/, src/flow/, src/nightly/, src/checks/ or forge.json needs a Direction: <why> line in a commit message, and the failure names rule "pipeline first". I checked the merged file lists of #11263 and #12444. Both add a terminal screen and a how-to, so the check refuses them today.

What changed. #10317 got through the existing check in the form it merged: it added about 90k lines of vendored three.js under src/web/render/vendor/, but only edited existing screens and how-tos. A file added under any vendor/ directory now counts as a feature, once per directory, so one vendored library is one finding. The same Direction: line or a pipeline change satisfies it. Editing an existing vendored file does not trigger it. The change is in src/kernel/direction.ts, with a test in test/direction.test.ts.

What I did not do. I did not widen the rule to every new file under src/web/ or src/maintain/. The waiver caps a waived pull at 2 feature files, so counting every new module would force a page and its helpers to be split across pulls. I could not verify #13651, which is a redesign. The rule treats an edit of 150 or more lines to an existing page as a feature, but I have not checked #13651's size against that.

To try it. In a clone, add any file under a vendor/ directory with no pipeline change and run bun scripts/gate.ts. It exits 2 with rule "pipeline first". Add Direction: <reason of 10 or more characters> to a commit message and it passes.

🤖 Generated with Claude Code

Closes #13748

commented

The "pipeline first" check already existed, and I extended it to cover the one gap I found. bun test test/direction.test.ts test/direction-refusal.test.ts passes (13 tests), bun scripts/gate.ts --fix and bun x tsc --noEmit are clean. I did not run the rest of the suite.

What was already there. scripts/gate.ts runs directionRefusal, which uses src/kernel/direction.ts. A pull that adds a page, a terminal screen or a how-to without touching scripts/, src/flow/, src/nightly/, src/checks/ or forge.json needs a Direction: <why> line in a commit message, and the failure names rule "pipeline first". I checked the merged file lists of #11263 and #12444. Both add a terminal screen and a how-to, so the check refuses them today.

What changed. #10317 got through the existing check in the form it merged: it added about 90k lines of vendored three.js under src/web/render/vendor/, but only edited existing screens and how-tos. A file added under any vendor/ directory now counts as a feature, once per directory, so one vendored library is one finding. The same Direction: line or a pipeline change satisfies it. Editing an existing vendored file does not trigger it. The change is in src/kernel/direction.ts, with a test in test/direction.test.ts.

What I did not do. I did not widen the rule to every new file under src/web/ or src/maintain/. The waiver caps a waived pull at 2 feature files, so counting every new module would force a page and its helpers to be split across pulls. I could not verify #13651, which is a redesign. The rule treats an edit of 150 or more lines to an existing page as a feature, but I have not checked #13651's size against that.

To try it. In a clone, add any file under a vendor/ directory with no pipeline change and run bun scripts/gate.ts. It exits 2 with rule "pipeline first". Add Direction: <reason of 10 or more characters> to a commit message and it passes.

🤖 Generated with Claude Code

Approved

Clean, small and tested. A file added under any vendor/ directory now counts as one feature per vendor directory in the pipeline-first check, so a vendored library like #10317 needs a Direction: line or a pipeline change. Edits to existing vendored files do not trigger it. The failure still names rule "pipeline first". The test covers the single finding, the waiver, the pipeline exemption and the edit case. The change touches no web, terminal or network surface, so there is no new input, output or secret to review. Note that #13651 (a redesign) is not shown to be caught; that is a size-threshold question, not a defect here.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs