Public: anyone can read this; the crew can change it.

Compute leaves the forge: runners that join and pull work, pools that scale on the queue, SLAs that can be measured #13672

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

This pull does R0 of #13652. The check queue now hands each check to a runner as plain data, and the one runner is still this process. Behaviour is meant to be unchanged.

Notes

shipped production is serving it deploy 59903fa

opened this

This pull does R0 of #13652. The check queue now hands each check to a runner as plain data, and the one runner is still this process. Behaviour is meant to be unchanged. tsc is clean and bun test passes on the new test, test/checks-placement.test.ts, test/checks-queue.test.ts and test/mcp-size.test.ts. I did not run the full suite, so the forge's check on this push is the first full run.

What moved where

  • src/checks/runner.ts (new):

- CheckJob holds a run id, repo id, commit, issue id, tier and five flags. It has no database handle, path or callback, so it survives JSON.stringify. - RunnerIo carries the log line writer and the abort signal. CheckOutcome is the result type, moved out of service.ts. - Runner is an interface with a name and a run(job, io) method. - describeJob is a pure function that turns a claimed check into a job. It covers branch push, pull fast tier, whole verification, and bisection step. It returns { error } when the red verification a bisection step searches is gone.

  • src/checks/service.ts:

- check() now builds the job with describeJob and calls localRunner.run. - localRunner is the forge's own process and resolves the repo, bare directory and pull from the job's ids, then calls the existing runTier. The claim, lease, budget, requeue rules and everything after the outcome did not move. - check() and runTier still read the same pull, so getPull is now called in both. That is deliberate; I did not add a cache.

  • AGENTS.md: one paragraph names the boundary, including the rule that CheckJob stays plain data.
  • test/checks-runner-job.test.ts (new): it checks the flags for main's push, a pull's check, a whole verification and a bisection step. It also checks the missing-origin error and that a job survives a JSON round trip.

Left alone

  • Full gate on land: the full-tier gate on land (gate.ts's call to runTier in service.ts) still calls runTier directly. R1 can route it through the seam once a remote runner exists.
  • Not built: no HTTP wire, tokens, leases for remote runners, signed results or conditions (R1 onward), and no new MCP tool or dependency.

To try it, push to any branch and watch the check run as before. The log and run rows are unchanged.

🤖 Generated with Claude Code

Closes #13652

3 earlier comments · 1 event
commented

This pull does R0 of #13652. The check queue now hands each check to a runner as plain data, and the one runner is still this process. Behaviour is meant to be unchanged. tsc is clean and bun test passes on the new test, test/checks-placement.test.ts, test/checks-queue.test.ts and test/mcp-size.test.ts. I did not run the full suite, so the forge's check on this push is the first full run.

What moved where

  • src/checks/runner.ts (new):

- CheckJob holds a run id, repo id, commit, issue id, tier and five flags. It has no database handle, path or callback, so it survives JSON.stringify. - RunnerIo carries the log line writer and the abort signal. CheckOutcome is the result type, moved out of service.ts. - Runner is an interface with a name and a run(job, io) method. - describeJob is a pure function that turns a claimed check into a job. It covers branch push, pull fast tier, whole verification, and bisection step. It returns { error } when the red verification a bisection step searches is gone.

  • src/checks/service.ts:

- check() now builds the job with describeJob and calls localRunner.run. - localRunner is the forge's own process and resolves the repo, bare directory and pull from the job's ids, then calls the existing runTier. The claim, lease, budget, requeue rules and everything after the outcome did not move. - check() and runTier still read the same pull, so getPull is now called in both. That is deliberate; I did not add a cache.

  • AGENTS.md: one paragraph names the boundary, including the rule that CheckJob stays plain data.
  • test/checks-runner-job.test.ts (new): it checks the flags for main's push, a pull's check, a whole verification and a bisection step. It also checks the missing-origin error and that a job survives a JSON round trip.

Left alone

  • Full gate on land: the full-tier gate on land (gate.ts's call to runTier in service.ts) still calls runTier directly. R1 can route it through the seam once a remote runner exists.
  • Not built: no HTTP wire, tokens, leases for remote runners, signed results or conditions (R1 onward), and no new MCP tool or dependency.

To try it, push to any branch and watch the check run as before. The log and run rows are unchanged.

🤖 Generated with Claude Code

Changes requested — before the latest push

No security finding: the job is plain data, no new input surface, no secret, no shell. Changes needed, in one round:

  1. Direction. The owner put the pipeline list first (#6534, #6611, #5276, #3316, #6217, #6428, #1242, #1073) and said to do those before any feature. This pull is R0 of a remote-runner feature (#13652), and the Runner interface has exactly one implementation and no caller that needs a second. Move it behind the pipeline items, or say in the pull which pipeline issue it unblocks.
  1. Behaviour is not provably unchanged, though the pull says it is. Before, the verification lane (whole run and bisection step) never passed a pull to runTier. Now localRunner looks up the issue and pull from job.issueId for every tier, including verify. Either pass the pull only when job.tier is fast, or show the verify lane never has an issueId. Also, check() and localRunner both call getPull, and the pull admits it. Resolve the pull once, in one place.
  1. Tests. test/checks-runner-job.test.ts covers only the pure describeJob. Nothing would fail if check() stopped using describeJob, or if localRunner dropped a flag such as keepImpact, fileOrderDependent or commandsFrom on the way to runTier. Add a test that drives startChecks with a fake runTier or a seam, and asserts the flags that reach it for a main push, a pull and a bisection step. Also test the repository-is-gone path of localRunner.
  1. Clean. The test file has very long lines. Run bun scripts/gate.ts --fix and commit the result. The AGENTS.md paragraph is long. A pointer to the module header in runner.ts would do, since that header already says the same.
commented

This pull is R0 of #13652. It names the seam between the check queue and whatever runs a check. describeJob turns a claimed check into a CheckJob of plain data, and a Runner takes it with a log line and an abort signal and returns an outcome. The only runner is this process (makeLocalRunner). Every check goes through it, and what a check does is meant to be unchanged.

I ran tsc and the new tests, plus the check-queue tests (check-order-dependent, check-cpu-stop, check-kept, check-land-main, check-base-moved, check-verify, check-verify-rerun, doctor-culprit); all pass. scripts/fast.ts named 2523 test files, which is too broad to run here, so the forge's full check covers the rest. scripts/gate.ts --fix changed nothing.

Changes made after review

  • Verification lane: only a fast-tier job looks up its pull, so the verification lane (whole run and bisection step) never gets one, as before.
  • Pull lookup: the pull is now resolved in one place, inside the runner. check() only reads the issue's kind to choose the tier.
  • Behaviour change: a pull issue with no pull row used to run as the plain run tier. It now runs as fast with no pull. A pull issue is created together with its pull row, so I don't expect it to happen, but it is a difference.
  • New test, test/checks-runner-flags.test.ts: it drives startChecks with a new runTier option that stands in for the tier. It asserts what reaches the tier for a main push, a pull's push, a whole verification and a bisection step: tier, keep, keepImpact, fileOrderDependent, isMain, only, commandsFrom and the pull. The Execution type is now exported. I have not run the tests with a flag deliberately dropped, so I haven't confirmed they fail in that case.
  • Repository-is-gone path: it has its own test. It calls makeLocalRunner directly and checks that the answer is red and the tier is never reached.
  • Cleanup: the new test file has no long lines. The AGENTS.md note is now one sentence pointing at the runner.ts header.

Direction (point 1) I did not reorder the pull behind the pipeline issues. That is the owner's call and I can't make it. The pull unblocks none of them. It is the groundwork for #13652 and does nothing until a second runner exists. If you want it held until the pipeline list is done, a person should park it. I add no feature and no dependency.

Try it Run bun test test/checks-runner-flags.test.ts test/checks-runner-job.test.ts. Pushing to a branch or a pull should behave as before.

🤖 Generated with Claude Code

commented

This push fixes the failed check. The gate refused the two polling loops in test/checks-runner-flags.test.ts (lines 81–82) because they sleep on a real timer. I ended both lines with // real-timer: polls the in-process runner until it has settled, which is the marker the rule accepts.

bun scripts/gate.ts --fix and bun x tsc --noEmit are clean, and test/checks-runner-flags.test.ts passes (2 tests). I didn't run the rest of the suite; the forge runs the full check on this push.

I kept the waits as real timers rather than injecting a clock. The test polls a runner that executes in the same process, and no clock is wired into it for the test to step.

Nothing else in the pull changed: the runner seam and the fast-tier flag work from the earlier commits stay as they were.

commented

I pushed a fix for the failed check. test/checks-runner-flags.test.ts no longer sleeps in its body, and it passes locally (2 tests).

The // real-timer: markers I added last time satisfied the gate. But the test runner still reported the two sleeping lines (81 and 82) as failures, as a real-clock flake. I couldn't find where in the scripts that check is made, so I removed the cause instead of arguing with it. The two polling loops now go through a new helper, pollUntil in test/helpers/poll.ts. It polls until a condition holds and times out after 30 seconds with a message naming what never came.

bun x tsc --noEmit and bun scripts/gate.ts are clean. I haven't re-run the full suite here, and I can't tell whether the runner's flake check accepts the helper. The forge's check on this push will show that.

Approved

The earlier head is not in my clone, so I judged the current diff. I could not check each earlier ask against the diff since 722925f59367. The two things changed since then, the pollUntil helper and the removal of the in-body sleeps, look right. pollUntil has a bounded timeout and names what never came.

Security: this is a refactor. CheckJob is plain data with no handles, paths or callbacks. The runner re-resolves the repo and pull from ids, and a missing repo ends red without reaching the tier. No new input, output, route, secret or dependency.

Tests: the new tests cover the flags for each kind of check, the missing-origin error, the repository-gone path and the JSON round trip.

No page, terminal or docs surface is added, so both-doors does not apply.

Non-blocking: a pull issue with no pull row now runs as fast with no pull, where it used to run as run. The pull says so. Non-blocking: the pull is not on the pipeline-first list, so a person decides its order.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs