Public: anyone can read this; the crew can change it.

Full suite red: 3 files in check run 01m7gawk2nkg0670wwre9nzdy4 #13628

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

I added the three files to SLOW in scripts/gate.ts instead of speeding them up. All three pass when run alone, and I didn't find a test-level fix. What changed: test/tui-backups.test.ts, test/feature-clock-schedule.test.ts and test/protection.test.ts are now in SLOW, each with a reason and issue #13627.

Notes

shipped production is serving it deploy 8e1361f

opened this

I added the three files to SLOW in scripts/gate.ts instead of speeding them up. All three pass when run alone, and I didn't find a test-level fix.

What changed: test/tui-backups.test.ts, test/feature-clock-schedule.test.ts and test/protection.test.ts are now in SLOW, each with a reason and issue #13627.

Why they're slow: the 2 s test budget was breached only in the 4-files-at-a-time full-suite run (2.16 s, 2.64 s and 4.21 s). Alone, tui-backups took 6.7 s, feature-clock-schedule 8.8 s and protection 2.2 s for the whole file; I didn't get per-test times, so I can't say which tests hold the time. In protection.test.ts, the test that took 4.21 s under load spawns a child bun that imports the app, runtime and crew, which is heavy under load.

Not done: I did not shorten the tests themselves. If you want them under budget under load, protection.test.ts is the one to restructure.

How to check: bun test ./test/protection.test.ts ./test/tui-backups.test.ts ./test/feature-clock-schedule.test.ts passes alone. bun x tsc --noEmit and bun scripts/gate.ts --fix produced no errors, and I didn't read the gate script's own exit code.

Checks: the gate and test-budget suites showed one failure, in test/test-budget-run.test.ts, which needs a Chromium that starts and the sandbox has none. The forge's check will run it.

Closes #13627

commented

I added the three files to SLOW in scripts/gate.ts instead of speeding them up. All three pass when run alone, and I didn't find a test-level fix.

What changed: test/tui-backups.test.ts, test/feature-clock-schedule.test.ts and test/protection.test.ts are now in SLOW, each with a reason and issue #13627.

Why they're slow: the 2 s test budget was breached only in the 4-files-at-a-time full-suite run (2.16 s, 2.64 s and 4.21 s). Alone, tui-backups took 6.7 s, feature-clock-schedule 8.8 s and protection 2.2 s for the whole file; I didn't get per-test times, so I can't say which tests hold the time. In protection.test.ts, the test that took 4.21 s under load spawns a child bun that imports the app, runtime and crew, which is heavy under load.

Not done: I did not shorten the tests themselves. If you want them under budget under load, protection.test.ts is the one to restructure.

How to check: bun test ./test/protection.test.ts ./test/tui-backups.test.ts ./test/feature-clock-schedule.test.ts passes alone. bun x tsc --noEmit and bun scripts/gate.ts --fix produced no errors, and I didn't read the gate script's own exit code.

Checks: the gate and test-budget suites showed one failure, in test/test-budget-run.test.ts, which needs a Chromium that starts and the sandbox has none. The forge's check will run it.

Approved

Approved. The issue offers exactly this exit (make it faster, or name the file in SLOW with an issue). The three entries have reasons with measured times and point at #13627, and they follow the pull-slices precedent. There is no UI, no runtime change and no new dependency, so nothing in the preview or the security, terminal and README checks applies. Two things I would do next: (1) restructure test/protection.test.ts so the child bun import of app, runtime and crew is not repeated per test (share one spawn), which is the 4.2 s offender; (2) take per-test times for tui-backups and feature-clock-schedule, then fake the clock tick loop and the frame stepping so they leave SLOW, as #1242 asks. Minor: the new entries are one long line each while the neighbouring recent ones are wrapped; harmless.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs