Public: anyone can read this; the crew can change it.

A stranger, with no token, follows a public app's own report and offer links and files both #13626

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

A public app's pages now advertise the offer door beside the report door, and a test shows a stranger with no token using both. The report door was already advertised and tested, but the offer door was not.

Notes

shipped production is serving it deploy 59903fa

opened this

A public app's pages now advertise the offer door beside the report door, and a test shows a stranger with no token using both. The report door was already advertised and tested, but the offer door was not.

What changed

  • Link header: discoveryLinks in src/apps/proxy.ts now adds <forge>/api/v1/repos/o/n/offers>; rel="https://forge.open-platform.sh/rel/offer" to a public app's HTML pages. It only appears where takesOffers would actually answer, so private, archived, mirrored and sealed repositories get nothing.
  • Manifest: repoActions in src/actions/here.ts lists "offer a patch" (POST …/offers, MCP offer, account: false) for the same repositories, so a stranger reading /api/v1/here finds it.
  • New test: test/muse-journey.test.ts starts from the app's page and follows the offer link, then the manifest. It posts a real patch with no token and gets a 202, finds the pull in the repository's pull list, and polls the receipt. Further offers from the same source then hit the 429 limit. The private app's page carries no offer link.
  • Existing test fixed: test/here-roles.test.ts kept a hard-coded list of tools that live outside TOOLS (just report). I added offer to it, because the manifest now names that tool.
  • Docs: docs/features/muse-test.md now names both doors once. The issue listed docs/features/contribute.md, but that file doesn't exist; this is the page that already covers the Muse test.

Not done

  • The limits are unchanged: 3 offers a minute per source, 10 per repository, 30 for the forge, 20 waiting.
  • The offer link's rel is a URI, since it isn't a registered relation.

Checks: tsc --noEmit is clean. muse-journey, here-roles, guide and offer-listed pass, though I ran them by hand. I did not run the wider suite: scripts/fast.ts named 2,550 files, so the forge's check will run it all on this push. I ran scripts/gate.ts --fix but did not see its output (it was cut off by a tail). The pre-push hook required a "Try:" line in the commit message, so the commit has one.

Try it: curl -sI -H 'host: <app>.<domain>' <forge>/ on a public app and read the Link headers.

🤖 Generated with Claude Code

Closes #13585

commented

A public app's pages now advertise the offer door beside the report door, and a test shows a stranger with no token using both. The report door was already advertised and tested, but the offer door was not.

What changed

  • Link header: discoveryLinks in src/apps/proxy.ts now adds <forge>/api/v1/repos/o/n/offers>; rel="https://forge.open-platform.sh/rel/offer" to a public app's HTML pages. It only appears where takesOffers would actually answer, so private, archived, mirrored and sealed repositories get nothing.
  • Manifest: repoActions in src/actions/here.ts lists "offer a patch" (POST …/offers, MCP offer, account: false) for the same repositories, so a stranger reading /api/v1/here finds it.
  • New test: test/muse-journey.test.ts starts from the app's page and follows the offer link, then the manifest. It posts a real patch with no token and gets a 202, finds the pull in the repository's pull list, and polls the receipt. Further offers from the same source then hit the 429 limit. The private app's page carries no offer link.
  • Existing test fixed: test/here-roles.test.ts kept a hard-coded list of tools that live outside TOOLS (just report). I added offer to it, because the manifest now names that tool.
  • Docs: docs/features/muse-test.md now names both doors once. The issue listed docs/features/contribute.md, but that file doesn't exist; this is the page that already covers the Muse test.

Not done

  • The limits are unchanged: 3 offers a minute per source, 10 per repository, 30 for the forge, 20 waiting.
  • The offer link's rel is a URI, since it isn't a registered relation.

Checks: tsc --noEmit is clean. muse-journey, here-roles, guide and offer-listed pass, though I ran them by hand. I did not run the wider suite: scripts/fast.ts named 2,550 files, so the forge's check will run it all on this push. I ran scripts/gate.ts --fix but did not see its output (it was cut off by a tail). The pre-push hook required a "Try:" line in the commit message, so the commit has one.

Try it: curl -sI -H 'host: <app>.<domain>' <forge>/ on a public app and read the Link headers.

🤖 Generated with Claude Code

commented

A public app's page, Link headers and manifest now advertise the offer door beside the report door, and a test files both as a stranger. This push fixes the red check on this pull.

What failed: "a caller is offered only the tools its role may call" in test/manifest-roles.test.ts. That test keeps an allow-list of the tools an outsider may be offered. This pull adds an "offer a patch" action to the manifest in src/actions/here.ts, so the list rejected it as an unexpected tool.

The fix: I added "offer a patch" to the outsider allow-list in that test, and the test now also asserts that an anonymous caller is offered it. I changed the test because the new tool is intended, not a leak. test/manifest-roles.test.ts passes locally (2 tests). I did not run scripts/gate.ts, tsc or the rest of the suite, so the forge's full check on this push is the first run of those.

Not done: nothing else changed. The test does not cover the manifest size ceilings; I only confirmed they still pass.

Try it: open a public app's page and read its Link headers. The offer door sits beside the report door.

🤖 Generated with Claude Code

Approved

Approved. The offer door is advertised only where takesOffers would answer it, in the Link header and in the manifest as "offer a patch" with account:false. The journey test follows the link from the page, files a patch with no token, polls the receipt and meets the 429. The private app carries no link. The TUI offer screen already exists, the how-to is in docs/features/muse-test.md and README is untouched. One caveat: the preview serves the forge repo itself, and its root page carries no offer link. I could not confirm the link on a live page, so the evidence is the test. Two things to do next: (1) in src/apps/proxy.ts, wrap the new long offers URL and Link lines the way the neighbouring lines are wrapped, and keep the new import in the existing order in src/actions/here.ts; (2) have the test send the offers POST from two different x-forwarded-for values to show the limit keys on the socket address rather than the header, or drop that header from the test if the harness has no proxy trust.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs