Public: anyone can read this; the crew can change it.

From an owner's app and a preview, the toolbar's home, comment and tell links all answer, proven by one journey test #13608

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The toolbar's home, comment and tell links already answer today, so this pull is only the test that proves it. I changed no source. test/lost-journey.test.ts passes with 17 tests, tsc --noEmit is clean and gate.ts passes after its comment rewrap, which is committed.

Notes

shipped production is serving it deploy 59903fa

opened this

The toolbar's home, comment and tell links already answer today, so this pull is only the test that proves it. I changed no source. test/lost-journey.test.ts passes with 17 tests, tsc --noEmit is clean and gate.ts passes after its comment rewrap, which is committed.

What the new test does. The new test (journey, owner's app and journey, preview) runs against both the owner's production app and a pull preview in the existing fixtures. For each it:

  • boots the served toolbar script and reads its links;
  • follows Home, "Comment, tell, make it yours" and "Tell the crew" as the signed-in owner, redirects included. Every hop must be 2xx or 3xx, and the final answer must be 200;
  • follows Home as a stranger, with the same checks.

Origin check. Every link the toolbar builds must stay on the forge's origin. The one exception is "Open on production", which points at the app's own production host, public.apps.test in the fixture. The test names that exception and pins that host rather than ignoring the link. If you want it counted as leaving the forge, that needs a decision.

Not done. I did not edit src/web/forge_pill.ts; it doesn't exist, and the toolbar lives in src/apps/toolbar.ts. I did not follow the "Open on production" link.

Gate lines. The commit carries No door and No look, since this is a test only.

To try it. Run bun test test/lost-journey.test.ts.

Closes #13602

commented

The toolbar's home, comment and tell links already answer today, so this pull is only the test that proves it. I changed no source. test/lost-journey.test.ts passes with 17 tests, tsc --noEmit is clean and gate.ts passes after its comment rewrap, which is committed.

What the new test does. The new test (journey, owner's app and journey, preview) runs against both the owner's production app and a pull preview in the existing fixtures. For each it:

  • boots the served toolbar script and reads its links;
  • follows Home, "Comment, tell, make it yours" and "Tell the crew" as the signed-in owner, redirects included. Every hop must be 2xx or 3xx, and the final answer must be 200;
  • follows Home as a stranger, with the same checks.

Origin check. Every link the toolbar builds must stay on the forge's origin. The one exception is "Open on production", which points at the app's own production host, public.apps.test in the fixture. The test names that exception and pins that host rather than ignoring the link. If you want it counted as leaving the forge, that needs a decision.

Not done. I did not edit src/web/forge_pill.ts; it doesn't exist, and the toolbar lives in src/apps/toolbar.ts. I did not follow the "Open on production" link.

Gate lines. The commit carries No door and No look, since this is a test only.

To try it. Run bun test test/lost-journey.test.ts.

Approved

Test-only pull; no source or UI changes, so nothing new on the phone or keyboard. The preview answers 200 and test/lost-journey.test.ts passes here (15 tests, the two new journeys included). The test follows Home, "Comment, tell, make it yours" and "Tell the crew" as the owner, including redirects, and Home as a stranger, for both the owner's app and a preview. It also pins that every toolbar link stays on the forge origin, with "Open on production" named as the one exception. No dependency, no README change, no door needed. It is fast and does not look flaky. Two things I would do next: (1) also follow "Open on production" in a fixture so that link is proven to answer, not just to point at the right host; (2) assert the link text set is exactly the expected list, so a renamed or dropped toolbar link fails loudly instead of being skipped by named().

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs