Public: anyone can read this; the crew can change it.

Full suite red: 3 files in check run 01m7g6jk92srkesh3cp1a4hzcw #13573

Closed opened this in answer to
Closed without merging

The real failure was the talk page's script byte cap. It is now 15,400 bytes, up from 15,200, and the other two files were timing flakes, so I left them alone. What changed test/talk-page.test.ts: the talkJs cap in "the page's own bytes are held" was 15,200.

Notes

stopped closed without shipping deploy ca1c170

opened this

The real failure was the talk page's script byte cap. It is now 15,400 bytes, up from 15,200, and the other two files were timing flakes, so I left them alone.

What changed

  • test/talk-page.test.ts: the talkJs cap in "the page's own bytes are held" was 15,200. The script is now 15,292 bytes, after the merged cost-display and starter-prompt features (#13456, #13339). That is the only assertion that failed. The cap rises by 200, enough to cover those features with about 100 bytes to spare. The CSS cap stays at 4,300 and the test still fails if the script bloats further.

What I chose not to do

  • test/llms-forks.test.ts and test/tui-plan-row.test.ts passed when I ran them here. Their reports were over the 2 s test budget (2.22 s and 2.02 s) in a full run with four files at a time, not assertion failures. I did not add them to SLOW.
  • The tui-plan-row report also lists the talk-page byte failure (shard 26), so the same cap change covers it.
  • I did not trim the script instead of raising the cap, because that would mean changing feature code for a cosmetic budget.

How to check

  • bun test test/talk-page.test.ts passes (62 tests), and bun scripts/gate.ts --fix and bun x tsc --noEmit ran with nothing flagged.
  • The three files together gave 65 pass and 1 fail before the edit. I didn't run the other two again afterwards.

Closes #13571

2 earlier comments
commented

The real failure was the talk page's script byte cap. It is now 15,400 bytes, up from 15,200, and the other two files were timing flakes, so I left them alone.

What changed

  • test/talk-page.test.ts: the talkJs cap in "the page's own bytes are held" was 15,200. The script is now 15,292 bytes, after the merged cost-display and starter-prompt features (#13456, #13339). That is the only assertion that failed. The cap rises by 200, enough to cover those features with about 100 bytes to spare. The CSS cap stays at 4,300 and the test still fails if the script bloats further.

What I chose not to do

  • test/llms-forks.test.ts and test/tui-plan-row.test.ts passed when I ran them here. Their reports were over the 2 s test budget (2.22 s and 2.02 s) in a full run with four files at a time, not assertion failures. I did not add them to SLOW.
  • The tui-plan-row report also lists the talk-page byte failure (shard 26), so the same cap change covers it.
  • I did not trim the script instead of raising the cap, because that would mean changing feature code for a cosmetic budget.

How to check

  • bun test test/talk-page.test.ts passes (62 tests), and bun scripts/gate.ts --fix and bun x tsc --noEmit ran with nothing flagged.
  • The three files together gave 65 pass and 1 fail before the edit. I didn't run the other two again afterwards.
commented

I merged main into the branch and pushed it. The only conflict was the talk page's script byte cap in test/talk-page.test.ts.

I took main's 15,900 over my 15,400. It is the higher of the two, so it still covers the script at 15,292 bytes. This pull now changes no code, since main already makes the same fix.

After the merge, test/talk-page.test.ts passes (65 tests) and bun x tsc --noEmit is clean. I did not run any other tests.

Because main has the fix, you may want to close #13573 rather than merge it.

commented

Closed by the crew: superseded, its change is already on main in 575823e0.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs