Public: anyone can read this; the crew can change it.

A like can be taken back in one tap, and the decision ledger records the withdrawal #13555

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

torque/forge:torque/13522-a-like-can-be-taken-back-in-one-tap-and → main 1 commit fork

  • Merged. torque/13522-a-like-can-be-taken-back-in-one-tap-and was merged into main as d6926e7.

Review

Sign in to review this change.
1 file changed +92 −0
test/feed-unlike.test.ts added +92
@@ -0,0 +1,92 @@
1 /**
2 * Taking a like back (#13522): the item shows unliked on reload, the ledger keeps a withdrawn row
3 * beside the like (never a deleted one), the count drops by one and never goes below zero, and the
4 * ranking's input moves so the feed re-ranks.
5 */
6 import { afterAll, beforeAll, describe, expect, test } from "bun:test";
7 import { mkdtemp, rm } from "node:fs/promises";
8 import { tmpdir } from "node:os";
9 import { join } from "node:path";
10 import { createApp, type App } from "../src/app.ts";
11 import { createRepo } from "../src/actions/repos.ts";
12 import { rankInputs } from "../src/core/rank_inputs.ts";
13 import { createToken } from "../src/core/tokens.ts";
14 import { createUser, type User } from "../src/core/users.ts";
15 import { readFeed } from "../src/feed/feed.ts";
16 import { ledgerCount, likeLedger } from "../src/feed/likes.ts";
17 import { serve, type Servers } from "../src/http/server.ts";
18 import { promote } from "./helpers/members.ts";
19
20 let dir: string;
21 let app: App;
22 let servers: Servers;
23 let alice: User;
24 let bob: User;
25 let carol: User;
26 let tok: Record<string, string>;
27 let item: string;
28
29 beforeAll(async () => {
30 dir = await mkdtemp(join(tmpdir(), "forge-unlike-"));
31 app = createApp({ dataDir: dir, port: 0 });
32 servers = await serve(app);
33 const mk = async (username: string, first = false) => {
34 const u = await createUser(app.db, { origin: "seed", trusted: true, username, email: `${username}@forge.local`, password: "a-good-passphrase", adminIfFirst: first });
35 if (!u.ok) throw new Error(u.error);
36 promote(app.db, u.value);
37 return u.value;
38 };
39 await mk("founder", true);
40 alice = await mk("alice");
41 bob = await mk("bob");
42 carol = await mk("carol");
43 tok = Object.fromEntries([bob, carol].map((u) => [u.username, createToken(app.db, u.id, "rw", "rw").token]));
44 const r = await createRepo(app, alice, { name: "open", visibility: "public" });
45 if (!r.ok) throw new Error("repo");
46 app.bus.append({ kind: "run.finished", repoId: r.value.id, actorId: alice.id, payload: { kind: "deploy", state: "ok", summary: "up", runId: "r1" } });
47 item = readFeed(app.db, alice).items.find((i) => i.app === "alice/open" && i.id.startsWith("event:"))!.id;
48 });
49
50 afterAll(async () => {
51 servers.stop();
52 app.close();
53 await rm(dir, { recursive: true, force: true });
54 });
55
56 const send = (who: string, kind: "liked" | "unliked") =>
57 fetch(`${servers.url}/api/v1/feed/interactions`, {
58 method: "POST",
59 headers: { authorization: `Bearer ${tok[who]}`, "content-type": "application/json" },
60 body: JSON.stringify({ item, kind }),
61 }).then((r) => r.json());
62 const seen = (who: User) => {
63 const i = readFeed(app.db, who).items.find((x) => x.id === item)!;
64 return { likes: i.likes ?? 0, liked: i.liked ?? false };
65 };
66
67 describe("taking a like back", () => {
68 test("one tap unlikes, a reload shows it, and the ledger holds a withdrawn row beside the like", async () => {
69 await send("bob", "liked");
70 await send("carol", "liked");
71 expect(seen(bob)).toEqual({ likes: 2, liked: true });
72 const before = rankInputs(app.db);
73
74 expect(await send("bob", "unliked")).toEqual({ likes: 1, liked: false });
75 expect(seen(bob)).toEqual({ likes: 1, liked: false });
76 expect(seen(carol)).toEqual({ likes: 1, liked: true });
77 expect(rankInputs(app.db)).not.toBe(before);
78
79 const rows = likeLedger(app.db, item).rows.map((r) => `${r.who}:${r.act}`);
80 expect(rows).toEqual(["bob:unlike", "carol:like", "bob:like"]);
81 expect(ledgerCount(app.db, item)).toBe(1);
82 });
83
84 test("withdrawing twice, or without having liked, never goes below zero or writes a row", async () => {
85 await send("carol", "unliked");
86 const rows = likeLedger(app.db, item).rows.length;
87 expect(await send("carol", "unliked")).toEqual({ likes: 0, liked: false });
88 expect(await send("bob", "unliked")).toEqual({ likes: 0, liked: false });
89 expect(likeLedger(app.db, item).rows.length).toBe(rows);
90 expect(seen(bob).likes).toBe(0);
91 });
92 });

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs