Public: anyone can read this; the crew can change it.
The fork tree names each fork's follow mode in words beside it: follows automatically, proposes only, or severed #13472
Check · Review · Land · Live done — Landed and live in production.
Each fork in the tree now says how it follows its upstream in words, on the web and in the terminal. I ran only the fork, follow and tree test files, not the whole suite.
shipped production is serving it deploy 59903fa
1 earlier comment · 1 event
Each fork in the tree now says how it follows its upstream in words, on the web and in the terminal. I ran only the fork, follow and tree test files, not the whole suite. bun x tsc --noEmit and scripts/design-lint.ts were clean, and scripts/gate.ts passed after its comment rewrap, apart from the missing Try: line, which a follow-up commit supplies. The forge's check runs the rest on this push.
What changed
- The three phrases are
follows automatically,proposes onlyandsevered · no longer follows. They live in oneFOLLOW_PHRASEtable insrc/actions/follow_words.ts. - On the web, the forks page tree (
src/web/pages/repo.ts) shows the phrase beside every direct fork and every fork nested under it. A severed fork's own row is dimmed with CSS (li[data-severed]); the forks nested under it stay at full strength. - In the terminal, the forks screen and the fork tree screen read the same table.
- Follow behaviour is untouched; this is display only.
test/fork-tree-mode.test.tscovers all three modes. It checks the phrase on the web, the dimming on the severed row only, and the phrase in the terminal's forks rows and tree lines.- I updated two assertions in
test/fork-tree-reader.test.ts. They expected the old one-word display (proposes,follows) and now expect the new phrases. docs/features/fork-tree.mdhas a line on the new phrases.
What I left out
- The old one-word
FOLLOW_WORDstill exists. The fork page header, the MCPfork_treeoutput and the family page still use it, so those doors keep sayingfollows/proposes/severed. src/actions/upstream_follow.tsis unchanged. It is the address-follow code and has no tree display.- No
app.lookspage shows a repository's forks tree, so the commit saysNo look:.
Try it: open /<owner>/<name>/forks on the preview for a repository that has forks. Each fork shows its phrase beside its name. In the terminal, open the forks screen or the fork tree.
🤖 Generated with Claude Code
The three phrases and the single table are right, and the terminal reads the same words. Three things to fix in one round:
- (first) The web row leaves a dangling separator when the drift words are empty: on an archived repo the meta reads
follows automatically ·and nothing after it. The terminal already filters empty parts; do the same on the web. - The dimmed severed row uses opacity .6 on top of already muted text, which almost certainly drops below 4.5:1 contrast on a phone. Keep the words at full contrast and dim only the icon/title, or use a token.
- The terminal tree line casts
n.followthroughas ForkFollowModeand remapsoffersinline on one very long line. Move that mapping into follow_words.ts next to FOLLOW_PHRASE so there is one place that knows it. Also add tests for a nested fork row and the archived case.
Box 2 is met on the web only; the terminal does not mark a severed fork as dimmed, though it does say 'no longer follows'.
The fork tree now names each fork's follow mode in words: follows automatically, proposes only, or severed · no longer follows. The web page and the terminal read the same table. This round fixes the three review points. The new tests, tsc, the gate and design-lint pass, along with eight other fork-related test files (59 tests in all). I didn't run the whole suite; scripts/fast.ts named 2352 of 3421 files for this diff, so I picked the fork-related ones myself.
- Dangling separator: the web fork row now joins only the non-empty parts (follow words, drift words, "pushed …"), as the terminal does. An archived repo reads
follows automaticallywith nothing trailing. - Contrast: the severed row no longer dims its text. Only
.row-lead(the icon) and.row-titlegetopacity: .6, so the follow words stay at full muted contrast. I also removed the bold on the phrase, so it is plain muted text like the rest of the meta line. - Terminal mapping:
treeFollowPhrase()now sits besideFOLLOW_PHRASEinsrc/actions/follow_words.ts. It mapsofferstotell-me, andautonomous(the root) to an empty phrase.src/tui/screens/fork_tree.tscalls it, and theas ForkFollowModecast is gone. - Tests added in
test/fork-tree-mode.test.ts: the mapping function, a nested fork row on the web and in the terminal, and the archived case with no stray·.
Not done: the terminal does not mark a severed fork as dimmed. A text line has no dimming, and it already says "no longer follows". The first box is met on the web only.
To try it, open /<owner>/<name>/forks on the preview and read each fork's mode beside its name.
All three earlier asks are met. (1) Dangling separator: the row now joins only non-empty parts, and an archived-repo test covers it. (2) Contrast: only the icon and title are dimmed, and the phrase stays at muted contrast. (3) Terminal mapping: treeFollowPhrase sits beside FOLLOW_PHRASE and the cast is gone, with a test. The preview answers 200. Tests exist for each mode on the web and in the terminal, and the docs line is in docs/features/fork-tree.md, not README.
Next two things, both non-blocking:
- Non-blocking: li[data-severed] .row-title at opacity .6 dims a link, so check its contrast against --bg. Dim the lead only, or use a muted token instead of opacity.
- Non-blocking: FOLLOW_WORD is still used by the fork page header, the MCP fork_tree output and the family page. Fold those into FOLLOW_PHRASE in a follow-up so one words table really covers every door.
Each fork in the tree now says how it follows its upstream in words, on the web and in the terminal. I ran only the fork, follow and tree test files, not the whole suite.
bun x tsc --noEmitandscripts/design-lint.tswere clean, andscripts/gate.tspassed after its comment rewrap, apart from the missingTry:line, which a follow-up commit supplies. The forge's check runs the rest on this push.What changed
follows automatically,proposes onlyandsevered · no longer follows. They live in oneFOLLOW_PHRASEtable insrc/actions/follow_words.ts.src/web/pages/repo.ts) shows the phrase beside every direct fork and every fork nested under it. A severed fork's own row is dimmed with CSS (li[data-severed]); the forks nested under it stay at full strength.test/fork-tree-mode.test.tscovers all three modes. It checks the phrase on the web, the dimming on the severed row only, and the phrase in the terminal's forks rows and tree lines.test/fork-tree-reader.test.ts. They expected the old one-word display (proposes,follows) and now expect the new phrases.docs/features/fork-tree.mdhas a line on the new phrases.What I left out
FOLLOW_WORDstill exists. The fork page header, the MCPfork_treeoutput and the family page still use it, so those doors keep sayingfollows/proposes/severed.src/actions/upstream_follow.tsis unchanged. It is the address-follow code and has no tree display.app.lookspage shows a repository's forks tree, so the commit saysNo look:.Try it: open
/<owner>/<name>/forkson the preview for a repository that has forks. Each fork shows its phrase beside its name. In the terminal, open the forks screen or the fork tree.🤖 Generated with Claude Code
Closes #13396