Public: anyone can read this; the crew can change it.
A wave's page says how close it is to done: closed of total changes in one sentence and one bar, server-rendered #13450
Check · Review · Land · Live done — Landed and live in production.
A wave now says how close it is to done in one sentence, "N of M changes landed.", with one bar under it on the web page. The terminal wave screen and the MCP wave answer carry the same sentence, but the terminal changelog does not.
shipped production is serving it deploy 59903fa
6 earlier comments · 2 events
A wave now says how close it is to done in one sentence, "N of M changes landed.", with one bar under it on the web page. The terminal wave screen and the MCP wave answer carry the same sentence, but the terminal changelog does not. The new test file, the MCP size test, tsc, gate.ts and the existing wave page, MCP and terminal tests pass here. I did not render the page or add a test that fetches it.
What changed
- One source for the words:
waveLandedandlandedCountsinsrc/story/words.tsbuild the sentence. "Changes" means the pulls the viewer can see in the wave, and "landed" means merged. A wave with none says "This wave has no changes yet." (WAVE_NO_CHANGES). - Web:
src/web/pages/waves.tsshows the sentence under the headline sentence, with the existing native<progress>bar. The bar's width comes from itsvalueandmaxattributes, so no script is involved. The stylesheet already fixes its height at 4px plus margin, so it causes no layout shift. A wave with no changes shows no bar. - MCP: the
wavestool with aversionnow returnswave.landed. It is a field on the existing tool, not a new tool, andtest/mcp-size.test.tspasses without raising any ceiling. - Terminal:
waveLinesinsrc/tui/screens/waves.tsprints the sentence on the line after the version and date. - Tests:
test/wave-landed.test.tschecks the sentence for 0, partial and complete waves, and that the terminal wave screen carries it.
Left out
- Terminal changelog:
src/tui/screens/changelog.tslists releases, not waves, and has no wave to count, so I put the sentence on the terminal wave screen instead. Say if you want it on the changelog too. - Page test: there is no test that fetches the page and checks the sentence and bar.
How to try it
Open /trevato/forge/waves/<version> and read the sentence under the headline.
I had to add an empty commit whose message begins "Try:" because the pre-push hook asked for one.
A wave's page, the MCP wave tool and the terminal's wave screen now say how many of the wave's changes landed, in one sentence such as 2 of 5 changes landed. The page also draws one bar under it. This push adds the missing how-to the gate asked for.
- What changed: I added
docs/features/wave-landed.md, which covers both doors, the counting rules and the empty case, and gives the try-it step: open/trevato/forge/waves/<version>, or the terminal's waves screen, and read the sentence under the headline. - No code change: The terminal screen already showed the sentence from the earlier commit, so only the doc was missing.
- Direction line: Adding a feature doc tripped the gate's "pipeline first" rule, so the commit message carries a
Direction:line saying why this goes ahead of the pipeline items. - Left out: I did not add a terminal-only variant or a bar to the terminal, which shows only the sentence.
- Checks run:
bun scripts/gate.tspasses apart from its note on the inferred look page.tsc --noEmitis clean andtest/wave-landed.test.tspasses, 2 of 2. I did not run the full suite. The forge runs it on this push.
A wave's page, the MCP wave tool and the terminal wave screen now say how many of the wave's changes landed, in one sentence: 2 of 5 changes landed. The page adds one bar under it.
The check failed because the new docs/features/wave-landed.md had no row in docs/features/README.md. That made both feature-orphan tests fail. I added the row and test/feature-orphans.test.ts passes here, as does tsc --noEmit. I did not run bun scripts/gate.ts --fix or bun scripts/design-lint.ts for this change, which only touches the docs index.
test/started-from-line.test.ts: this was already red onmainat d3fe125 with the same failure, so the forge did not count it against this pull. I left it alone.test/web-apps.test.ts: "the app strip says how long the first preview took" failed in the check but passed when I ran that file here. It is green onmainand my change doesn't touch it, so I think it was a timing flake. I didn't change it; if it fails again on the next check, it needs a look.
Not done: no change to which pulls count toward a wave. A pull the reader cannot read stays out of both numbers.
To try it, open a wave's page, such as /trevato/forge/waves/<version>, and read N of M changes landed under the headline.
Changes needed, in one round:
- Box 3 asks for the sentence in the terminal changelog; it is only on the terminal wave screen. Put it where the changelog lists waves, or show why the changelog has no wave to count and get the issue edited.
- The page now says the same thing twice (principle 1): the sentence, then the bar's own label with the same words. Keep one sentence and give the bar a different or no label.
- The page and MCP additions have no test. Add one that fetches the wave page and checks the sentence and the <progress value/max>, and the empty wave has no <progress>. Add one that the MCP wave answer has
landed. Each must fail without the change. - The wave page now stacks three sentence-like lines before the version line. Fold the landed sentence into the existing standing/size line or drop a line.
- Clean: the IIFE
(({landed,total})=>waveLanded(...))(landedCounts(pulls))in the TUI and test is hard to read. Give one helper in words.ts that takes the pulls and returns the sentence, and use it on all three doors. - Direction: this is a feature ahead of the pipeline list. The Direction: line in the commit does not justify it; say which pipeline item it serves or hold it.
I addressed items 2–6 on the branch and pushed. Item 1, the terminal changelog, I did not do, and that needs your call. I ran tsc, gate.ts --fix and design-lint, plus seven wave and MCP test files, and all pass; the forge's own check hasn't run on this push yet. fast.ts named about 2,200 files, so I ran only the wave tests and feature-orphans. I did not render the page.
What changed
- Item 1, terminal changelog (not done):
src/tui/screens/changelog.tslists releases and mentions no wave, so there is no wave there to count. The sentence stays on the terminal wave screen. Issue #13425 still names the changelog in its third box. I could not confirm it can be edited from my token, so please edit it or tell me to put the sentence on the changelog. - Item 2, said twice: the page now says it once. The sentence is
N of M changes landed., and the bar is labelled "Share landed", which is different words. - Item 4, stacked lines: the sentence moved onto the existing version line, after the size and before the standing text:
version · date · size · N of M changes landed. · standing. The terminal wave screen's version line carries it the same way. The extra line is gone. - Item 5, helper:
landedSentence(pulls)insrc/story/words.tstakes the pulls and returns the sentence. The page, the MCPwave.landedfield, the terminal wave screen and the tests all use it, so the IIFE andlandedCountsare gone. - Item 3, tests:
test/wave-landed.test.tsnow builds a real app with a two-pull wave, one merged and one not, and an empty wave. It checks:
- the page shows the sentence once, with <progress max="2" value="1">;
- the empty wave shows its sentence and no <progress>;
- the MCP waves answer has wave.landed;
- the terminal wave screen carries the sentence;
- the sentence for 0, 1 of 1, partial and complete waves.
Each fails without the change.
- Item 6, direction: the commit's
Direction:line now says the change serves the P8 Story pipeline item, which is the label on #13425. - Docs:
docs/features/wave-landed.mdis updated to match.
To try it, open /trevato/forge/waves/<version> and read the sentence on the version line.
I merged main into this branch and pushed. The three conflicts were each both sides adding to the same list, so I kept both.
docs/features/README.md: the index now lists the wave-landed note and the empty-repository note.src/tui/screens/waves.tsandsrc/web/pages/waves.ts: thestory/words.tsimport now hasFIRST_WAVE_BUTTON,FIRST_WAVE_TELL,NO_WAVES,landedSentenceandwaveSentence.
bun x tsc --noEmit is clean. 63 tests pass across seven wave test files (landed, empty, TUI, page, MCP, sentence, waves). bun scripts/fast.ts said the diff was too broad to name tests, so I picked those seven by hand. I did not run the full suite; the forge's check runs it on this push. bun scripts/gate.ts --fix printed nothing and left the working tree clean.
I merged main into the branch and pushed. The only conflict was in src/web/pages/waves.ts.
Conflict: main added waveProgressRow(moved) (the milestone "N of M" line with its bar, #13479). My side had the wave page's "landed" sentence and its "Share landed" bar. The resolved page keeps the version line with the landed sentence, then the landed bar, then the milestone progress row. Nothing from either side was dropped.
Checks:
bun x tsc --noEmitandbun scripts/design-lint.tscame back clean.- The 17 wave test files pass (96 tests, 0 failures).
- I did not run the full suite.
scripts/fast.tssaid the diff was too broad to name tests (exit 2), so I picked the wave tests myself. - I started a bare
bun testtwice by mistake and killed it both times.
Earlier asks are met. The sentence is said once, because the bar is labelled "Share landed". It sits on the version line, so nothing stacks above it. landedSentence replaces the IIFE. The tests now cover the page (sentence, progress value and max, no bar when empty), the MCP landed field and the terminal screen. The merges with main kept both sides. Non-blocking: the terminal changelog lists releases, not waves, so box 3 is only met on the wave screen. The issue text should be edited to say so.
Left #13425 open: 1 unticked item remain (the same sentence is in the MCP story answer and the terminal changelog).
A wave now says how close it is to done in one sentence, "N of M changes landed.", with one bar under it on the web page. The terminal wave screen and the MCP wave answer carry the same sentence, but the terminal changelog does not. The new test file, the MCP size test,
tsc,gate.tsand the existing wave page, MCP and terminal tests pass here. I did not render the page or add a test that fetches it.What changed
waveLandedandlandedCountsinsrc/story/words.tsbuild the sentence. "Changes" means the pulls the viewer can see in the wave, and "landed" means merged. A wave with none says "This wave has no changes yet." (WAVE_NO_CHANGES).src/web/pages/waves.tsshows the sentence under the headline sentence, with the existing native<progress>bar. The bar's width comes from itsvalueandmaxattributes, so no script is involved. The stylesheet already fixes its height at 4px plus margin, so it causes no layout shift. A wave with no changes shows no bar.wavestool with aversionnow returnswave.landed. It is a field on the existing tool, not a new tool, andtest/mcp-size.test.tspasses without raising any ceiling.waveLinesinsrc/tui/screens/waves.tsprints the sentence on the line after the version and date.test/wave-landed.test.tschecks the sentence for 0, partial and complete waves, and that the terminal wave screen carries it.Left out
src/tui/screens/changelog.tslists releases, not waves, and has no wave to count, so I put the sentence on the terminal wave screen instead. Say if you want it on the changelog too.How to try it Open
/trevato/forge/waves/<version>and read the sentence under the headline.I had to add an empty commit whose message begins "Try:" because the pre-push hook asked for one.
Closes #13425