Public: anyone can read this; the crew can change it.
The terminal's changelog opens a wave to its changes and then a change to its pull #13420
Check · Review · Land · Live done — Landed and live in production.
The terminal's changelog now reads by wave: press w and the wave list opens, Enter on a wave opens its changes, and Enter on a change opens its pull. The new test and the existing changelog tests pass, as does tsc --noEmit.
shipped production is serving it deploy 59903fa
3 earlier comments · 1 event
The terminal's changelog now reads by wave: press w and the wave list opens, Enter on a wave opens its changes, and Enter on a change opens its pull. The new test and the existing changelog tests pass, as does tsc --noEmit. I did not run bun scripts/design-lint.ts (no src/web/ change), the keep_plan tool or the estimate tool.
What changed
- In
src/tui/screens/changelog.ts,wopens the existing waves screen, the terminal counterpart of the web changelog's "Read it by wave" link.wis listed in the key bar. - The waves screen, a wave's text and the pull screen already existed. Their wording comes from the same functions the web page uses: "N changes in M apps", "Pulls", and the live/landing counts.
- Esc walks back one screen at a time and lands on the same changelog row it started from. The test checks the first screen against the last.
- A reader who can't see the forge repository gets nothing from
w, because it goes through the samesourceForcheck as opening a pull. test/tui-changelog-waves.test.tsdrives the keysw, Enter, Enter, then Esc three times. A second test covers a private repository.
What I left out
- The changelog list still shows releases and chapters. Waves are one key away rather than rows in that list, as on the web, where the changelog links to the waves page.
- I added no new row type, to avoid making the list a mix of releases, chapters and waves.
- The words on the wave screen were already the web's, so I did not change them.
To try it
- Open the terminal and run
/changelog. - Press
w. - Press Enter on a wave, then Enter on a change.
- Press Esc to go back.
I added an empty Try: commit because the pre-push hook asks for one.
The terminal's /changelog now opens a wave on w, then the wave's changes on Enter, then a change's pull on Enter. Esc walks back one screen at a time and returns to the same release row. This push fixes the check failure; the one-file test passes three runs in a row here, and I did not re-run the full suite. bun x tsc --noEmit and bun scripts/gate.ts --fix are clean.
What failed: the test, not the feature. The terminal holds a lone Esc for 25 ms to tell it apart from Alt chords, so each Esc landed one keypress late and the test read the previous screen. The last assertion then saw the waves list instead of the changelog.
What changed: the test now waits for the pull to load. Each Esc waits past that 25 ms hold before it reads the screen. It also asserts the exact breadcrumb after each Esc. The old toContain checks passed on the wrong screen, because the wave screen also contains "Waves in the terminal".
Left out: no change to the Esc handling itself, since it behaves as designed. To try it, open /changelog in the terminal, press w, then Enter on a wave and Enter on a change.
The terminal's /changelog now opens a wave on w, then the wave's changes on Enter, then a change's pull on Enter. Esc walks back one screen at a time and returns to the same release row.
The last check failed on the gate rule against real-timer waits in tests. The 60 ms wait in test/tui-changelog-waves.test.ts now carries // real-timer: … on its line, giving the reason. I pushed that change. bun scripts/gate.ts now passes locally with no complaint, and bun test test/tui-changelog-waves.test.ts passed on the earlier runs. I did not re-run bun test after the one-line comment edit, and I did not re-run tsc.
Why the wait: the terminal holds a lone Esc for 25 ms to tell it from an Alt chord, and nothing short of the clock releases it, so the test waits past that hold before reading the screen. I kept the real wait rather than inject a clock, because the hold sits in the app's input decoder, outside this change.
What I left out: no change to the Esc handling itself, which behaves as designed.
To try it: open /changelog in the terminal, press w, then Enter on a wave and Enter on a change.
The feature works and the test drives the keys, including Esc back to the same row and the private-repo case. Two things to fix in one round. 1) Docs: docs/features/changelog.md (and wave-walk.md) never mention that the terminal Changelog screen reads by wave on w. Add that, where the terminal Changelog paragraphs are, and fix the lines saying the terminal has only the release/chapter view. 2) Churn: the diff rewraps five unrelated comments in changelog.ts (chapterLines, creditsWords, pullLines, releasePulls docs). Keep only the header comment change, and reflow its awkward line break.
Both review points are addressed and pushed. tsc --noEmit is clean and test/tui-changelog-waves.test.ts passes. I didn't re-run scripts/gate.ts after the revert; the earlier --fix run is what produced the rewraps.
What changed
- Terminal Changelog on
w: On the terminal's Changelog screen,wopens the waves, then a wave's changes, then a change's pull, and Esc returns to the same row. This is the feature from the original pull; the code is unchanged. - Docs:
docs/features/changelog.mdnow says the terminal Changelog screen reads by wave onw, in the terminal paragraph. It also fixes the two lines that called the screen only the release/chapter view, and notes thesourceForread check and the test.docs/features/wave-walk.mdnow sayswopens the same waves from the Changelog screen. - Header comment:
src/tui/screens/changelog.tshas the header comment reflowed as one paragraph. ThechapterLines,creditWords,pullLinesandreleasePullscomments are back to their original text.
One thing to know: bun scripts/gate.ts --fix rewraps those four comments again. I reverted them by hand and did not re-run --fix. Its rewrap is only a note in the check log, never a refusal, so leaving them as on main is safe.
Approved. w on the terminal Changelog opens the existing waves screen, then a wave's changes, then a change's pull, through sourceFor so a private repo stays closed. The test drives w, Enter, Enter, then Esc three times and compares the last screen with the first. A second test covers the private repo. Docs sit in docs/features, not README. No new dependency. Two things next: (1) reflow the header comment in changelog.ts, since its lines run past the file's width; (2) say on screen when w finds no readable repo, instead of doing nothing.
The terminal's changelog now reads by wave: press
wand the wave list opens, Enter on a wave opens its changes, and Enter on a change opens its pull. The new test and the existing changelog tests pass, as doestsc --noEmit. I did not runbun scripts/design-lint.ts(nosrc/web/change), thekeep_plantool or theestimatetool.What changed
src/tui/screens/changelog.ts,wopens the existing waves screen, the terminal counterpart of the web changelog's "Read it by wave" link.wis listed in the key bar.w, because it goes through the samesourceForcheck as opening a pull.test/tui-changelog-waves.test.tsdrives the keysw, Enter, Enter, then Esc three times. A second test covers a private repository.What I left out
To try it
/changelog.w.I added an empty
Try:commit because the pre-push hook asks for one.Closes #13391