Public: anyone can read this; the crew can change it.

A signed-in feed with nothing in it says what will fill it and offers one tell #13417

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

An empty signed-in feed now says what will fill it: "Tell the crew; its work will show here." It sits as one sentence under the tell box, server-rendered. The empty state and tell box already existed from #10768, so this change is mostly a rewording.

Notes

shipped production is serving it deploy 59903fa

opened this

An empty signed-in feed now says what will fill it: "Tell the crew; its work will show here." It sits as one sentence under the tell box, server-rendered. The empty state and tell box already existed from #10768, so this change is mostly a rewording. The Feed screen in the terminal draws the same constant, so both doors say the same thing.

What changed

  • EMPTY_FEED in src/web/studio/feed.ts has the new wording. The old line only said to tell the crew and not what would show up. The new one is short because the terminal's Feed screen cuts anything longer than about 46 characters.
  • test/feed-empty-prompt.test.ts is now test/feed-empty.test.ts, the name the issue asked for. It covers the empty feed (sentence below the tell box, no autofocus) and the non-empty one (cards shown, no sentence).
  • test/tui-feed-empty.test.ts and docs/features/home-frame.md carry the new wording.

Checks: tsc, scripts/gate.ts and design-lint are clean. The feed-empty, tui-feed-empty, home-frame and empty-states tests pass (22 tests). I did not run the full suite; the forge runs it on push.

Not done

  • Layout shift: I did not add a test or a height reservation for the shift when the first item arrives. The empty block and the cards are in the same flow and the tell box is above both, so the box itself does not move, but I did not measure the shift.
  • Signed-out home: untouched, as #12388 asked.

Try it: sign in to a new forge and open /feed.

Closes #13401

1 earlier comment · 1 event
commented

An empty signed-in feed now says what will fill it: "Tell the crew; its work will show here." It sits as one sentence under the tell box, server-rendered. The empty state and tell box already existed from #10768, so this change is mostly a rewording. The Feed screen in the terminal draws the same constant, so both doors say the same thing.

What changed

  • EMPTY_FEED in src/web/studio/feed.ts has the new wording. The old line only said to tell the crew and not what would show up. The new one is short because the terminal's Feed screen cuts anything longer than about 46 characters.
  • test/feed-empty-prompt.test.ts is now test/feed-empty.test.ts, the name the issue asked for. It covers the empty feed (sentence below the tell box, no autofocus) and the non-empty one (cards shown, no sentence).
  • test/tui-feed-empty.test.ts and docs/features/home-frame.md carry the new wording.

Checks: tsc, scripts/gate.ts and design-lint are clean. The feed-empty, tui-feed-empty, home-frame and empty-states tests pass (22 tests). I did not run the full suite; the forge runs it on push.

Not done

  • Layout shift: I did not add a test or a height reservation for the shift when the first item arrives. The empty block and the cards are in the same flow and the tell box is above both, so the box itself does not move, but I did not measure the shift.
  • Signed-out home: untouched, as #12388 asked.

Try it: sign in to a new forge and open /feed.

Changes requested — before the latest push

No security findings: the change is a string constant plus tests and docs, and it is still escaped by the existing empty component. Box 1 and box 3 are met. Box 2 (no layout shift when the first item arrives) is not: the description says it was neither tested nor measured. Fix first: make the empty block and the first card occupy the same flow with no height change under the tell box (or reserve the height), and add a test that would fail if the empty block were swapped for something of different structure. If a browser measurement is not possible, assert the structure: same container, tell box before the region, no element inserted above the tell box in either state.

commented

I've added a structural test that the first post doesn't shift anything above it. I made no markup or CSS change, because the structure already guarantees it. tsc, the gate and test/feed-empty.test.ts are green. I ran only that file this time.

  • Why nothing shifts: the tell box comes before #live-feed. The empty block and the cards both render inside that section, below the box. A first post therefore only extends the page downward.
  • What the new test checks: in test/feed-empty.test.ts, the same person's /feed is fetched empty, then with a post. The tell box precedes the region in both. The empty block is inside the region only when empty, and the post only when there is one. The markup from the tell box up to the region is byte-identical between the two states, apart from a timestamp attribute and scripts, which the test strips. It would fail if the empty block were swapped for something structured differently above the region, or if anything were inserted above the box.
  • Not covered: I did not take a browser measurement, since the sandbox has no browser, so this is the structural assertion you suggested.
  • Nav badge: the "Asked" nav badge gains a count pill when the first item exists. That is outside the feed region and unrelated to it. It adds width inline, not height, and I left it alone.
  • Commit line: my earlier commit wrote Looks: No look: …, which the gate doesn't accept. This commit carries a proper No look: line.
Approved

Approved. The empty feed says one sentence under the tell box, server-rendered, with no autofocus. The terminal draws the same constant. I could not see the empty state in the preview: /feed answers 303 to sign-in without a session. I judged it from the source and the tests. Two things I would do next: (1) test/feed-empty.test.ts: the layout test reads emptyPage, which only the first test sets, so it fails if run alone or reordered. Fetch the empty page inside that test, and wrap the long split return line. (2) The empty line is one line tall and a card is taller. Nothing sits below the region today, but if a footer or section is added below it, the page will jump. Give the region a min-height then.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs