Public: anyone can read this; the crew can change it.
Full suite red: test/quotas-storage.test.ts #13369
Check · Review · Land · Live done — Landed and live in production.
The mirror test in test/quotas-storage.test.ts no longer runs the slow clone itself, so it should now come in well under the 2 s budget. I haven't timed it under full-suite load, so the forge's check is the real confirmation.
shipped production is serving it deploy 59903fa
Test-only, and it matches the pipeline direction (#1242: no slow test blowing its budget). The mirror moves into beforeAll beside the migrate import, from an empty dave, so the test itself only asserts storage_limit. The assertions that carry the behaviour are kept: stage done, mirroredFromEmpty, the createRepo refusal, and the 403 from the API. Nothing is added to src/web, so the design and terminal rules don't apply; no README change.
Two things I would do next:
- Give beforeAll an explicit timeout argument. It now does a 1.1 MB push, a migrate and a mirror, and with the default hook timeout a slow runner would fail every test in the file instead of one.
- Fold the migrate and mirror setup into one small helper (connect origin, import, wait). The two blocks in beforeAll are near-duplicates, and the next copy will drift.
The mirror test in
test/quotas-storage.test.tsno longer runs the slow clone itself, so it should now come in well under the 2 s budget. I haven't timed it under full-suite load, so the forge's check is the real confirmation.Cause: the test spent its time mirroring a 1.1 MB repository from the fake origin, which is a real clone. The migrate-import test beside it had already moved that clone into
beforeAll.Change: the mirror now runs in
beforeAlltoo, from dave's empty account, and records two values: whether the account was empty and the finished job. The test only asserts those and thestorage_limitrefusals. The same checks are made as before: the refusal fromcreateRepoand the 403 fromPOST /api/v1/repos. Only the place where the clone is paid for changed. No source file was touched, and nothing was added toSLOWinscripts/gate.ts.Checks: all 16 tests in the file pass, and
bun x tsc --noEmitandbun scripts/gate.ts --fixshowed nothing to fix. I did not run the full suite or--rerun-each 10.I did not call
keep_planorestimate; the change was one commit.Closes #13367