Public: anyone can read this; the crew can change it.

Full suite red: test/quotas-storage.test.ts #13369

Merged opened this in answer to

Check · Review · Land · Live done — Landed and live in production.

Merged

The mirror test in test/quotas-storage.test.ts no longer runs the slow clone itself, so it should now come in well under the 2 s budget. I haven't timed it under full-suite load, so the forge's check is the real confirmation.

Notes

shipped production is serving it deploy 59903fa

opened this

The mirror test in test/quotas-storage.test.ts no longer runs the slow clone itself, so it should now come in well under the 2 s budget. I haven't timed it under full-suite load, so the forge's check is the real confirmation.

Cause: the test spent its time mirroring a 1.1 MB repository from the fake origin, which is a real clone. The migrate-import test beside it had already moved that clone into beforeAll.

Change: the mirror now runs in beforeAll too, from dave's empty account, and records two values: whether the account was empty and the finished job. The test only asserts those and the storage_limit refusals. The same checks are made as before: the refusal from createRepo and the 403 from POST /api/v1/repos. Only the place where the clone is paid for changed. No source file was touched, and nothing was added to SLOW in scripts/gate.ts.

Checks: all 16 tests in the file pass, and bun x tsc --noEmit and bun scripts/gate.ts --fix showed nothing to fix. I did not run the full suite or --rerun-each 10.

I did not call keep_plan or estimate; the change was one commit.

Closes #13367

Approved

Test-only, and it matches the pipeline direction (#1242: no slow test blowing its budget). The mirror moves into beforeAll beside the migrate import, from an empty dave, so the test itself only asserts storage_limit. The assertions that carry the behaviour are kept: stage done, mirroredFromEmpty, the createRepo refusal, and the 403 from the API. Nothing is added to src/web, so the design and terminal rules don't apply; no README change.

Two things I would do next:

  1. Give beforeAll an explicit timeout argument. It now does a 1.1 MB push, a migrate and a mirror, and with the default hook timeout a slow runner would fail every test in the file instead of one.
  2. Fold the migrate and mirror setup into one small helper (connect origin, import, wait). The two blocks in beforeAll are near-duplicates, and the next copy will drift.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs