Public: anyone can read this; the crew can change it.
Every empty list says what it is waiting for in one sentence, from one table #13312
Check · Review · Land · Live done — Landed and live in production.
The board, inbox, runs, apps and people lists now take their empty sentence and one link from a single table, EMPTYWORDS in src/web/emptywords.ts. A page draws it with emptyList(kind).
shipped production is serving it deploy 59903fa
3 earlier comments · 1 event
The board, inbox, runs, apps and people lists now take their empty sentence and one link from a single table, EMPTY_WORDS in src/web/empty_words.ts. A page draws it with emptyList(kind).
tsc, the gate, design-lint, and test/empty-states.test.ts, studio-search, bindings, keys-people-list, boards-list-language, web-apps and feature-orphans pass here. I didn't run scripts/fast.ts's test list, because it named 1970 files, over its 5-minute budget. The full check runs on push.
- Board (
/boards): "No board yet." with the link "Start from a question" to/boards/data. The old "Make one below" hint is gone; the form still sits under it. - Inbox (
/asks): the empty page now shows a visible "Nothing is waiting on you." with "Tell the crew something". Before, only a screen-reader heading said "All fine". - Runs: the unfiltered empty list says "No run is open." and links to that repository's issues. A filtered empty list still says what the filter hides and links back to "Show all".
- Apps: the plain empty list uses the table. A signed-out viewer gets the sentence with no link. The "Nothing is archived" and "Nothing is live" cases keep their own wording.
- People: "Nobody has joined yet." with "Invite someone", linking to
/admin/limits.
Existing sentences are kept where tests assert them, so there is little wording drift.
test/empty-states.test.ts now checks the board, inbox, runs and apps pages: each has one empty block with the table's sentence and exactly one link with the table's label. It also checks emptyList's link override and no-link option. The people page can't be walked over HTTP because the signed-in admin is always a person, so the test checks emptyList("people") directly. The page's own empty sentence is still held by keys-people-list.test.ts.
I left out the issues, pulls, branches and other empty lists. I also left out the filtered variants, which keep their "Show all" links. I added docs/features/empty-words.md and a row for it in the index. The commit carries No door: and Direction: lines for the gate, plus Looks: /apps.
To try it, open /boards, /asks, /apps and a repository's /runs on a fresh account.
I merged main into this branch and pushed it. The only conflict was in src/web/pages/people.ts.
- Resolution:
mainhad changed the people list's empty state to useempty()with a filter-aware title, "Nobody here." when a role filter is active, and added atimeimport. This branch had swapped the empty state for the sharedemptyList("people")fromempty_words.ts. I kept both. With no filter the page shows the shared sentence and its "Invite someone" button; with a filter it showsmain's "Nobody here." I dropped thebadgeimport, which nothing in the file uses any more. - Tests:
bun x tsc --noEmitprinted nothing andbun scripts/gate.ts --fixprinted nothing I could see, but the sandbox log buried their output, so I'm not claiming they passed. Seven people/empty-state test files ran: 36 pass, 1 skip, 0 fail. The skipped test ispeople-fit, which needs a Chromium that starts on this machine; there isn't one here. - Not run:
scripts/fast.tsreported the merged diff as too broad to name tests (1971 of 3378 files), so I picked the people and empty-state tests by hand instead. The full suite did not run here; the forge's check runs it on this push.
Pushed 4b664cf16. It fixes the first-view budget failure; I couldn't tie the other three to this change.
- Budget failure: the empty Boards list now carries its one primary link, "Create a board", from the shared table. That put
boardsone block (96 vs 95) and one colour (3 vs 2) over its budget at both widths. I raised those two numbers indocs/design/attention-budget.jsonand added a note saying why. - Why not drop the link: I first tried removing the link from Boards. That broke
test/empty-states.test.tsandtest/empty-language.test.ts, which require every empty list to have exactly one link, so I reverted it. - ETag and screen failures: I did not find a cause for "signed-out page with a flash carries no ETag", "signed-out 404 carries no ETag" and "the screen shows the share, the budgets that refused and the agent refused".
test/etag.test.tspasses here. I never ran the share/budgets/agent test, so it is unchecked. All three failed in shard 65, so shard-level interference is possible. - Tests run:
attention,etag,empty-languageandempty-statespass together (29 pass, 0 fail).
The budget raise needs a person to accept it in review, since the rule is that no budget goes up without a note in the pull. If the forge's check still fails after this push on those three, I need its log.
Good idea (one table, one sentence, one link) and the tests walk it. Four things to fix in one round:
- FIRST: principle 5 (one accent). emptyList always draws a variant:primary button. The apps page already has a primary 'New app' in its header (apps.ts:206), so the empty state adds a second accent with the same label. The boards page gains a second primary too, which is why the attention budget had to be raised. Make the empty-state action a plain link (variant link) and revert the attention-budget.json raise; a budget going up to fit a new accent is the wrong fix.
- Principle 1 (nothing explains itself twice): the inbox now shows a visible 'Nothing is waiting on you.' directly under the sr-only 'All fine' h2 and a link to '/' that is the page the person may already be on; the apps empty state repeats the header's New app. Drop the link where the page already offers it (use noAction) and give inbox a link that goes somewhere else.
- Both doors: the terminal has no screen change and the feature doc says nothing about it. Either have src/tui empty states read EMPTY_WORDS or state in docs/features/empty-words.md why they do not.
- Clean: empty_words.ts header cites test/empty-words.test.ts, which does not exist (the test is in empty-states.test.ts). In the test, a long trailing // comment is glued to the pages line; move it above. People 'Invite someone' links to /admin/limits, a limits page: check the wording matches what that page does, and hide it for non-admins.
All four review points are addressed and pushed. The tests I ran pass, bun x tsc --noEmit is clean and design-lint is clean. I did not run the full suite. scripts/fast.ts found the diff too broad to name tests, so I ran the ones covering the empty states, the attention budget and the terminal screens by name.
Changes
- One accent: the empty-state action is now a plain link (
variant: "link"). I reverteddocs/design/attention-budget.jsonto main, andtest/attention.test.tspasses against the original budget. - Nothing said twice:
- Apps passes noAction, because the header already has "New app".
- Boards also passes noAction. With a link, boards still went over the original budget by one block and one colour, and "Make a board" sits right below the empty state anyway. You didn't ask for this one; I added it to keep the budget unraised.
- The inbox link now goes to /tell instead of /. I haven't opened /tell to check it works as a page; it's the share-target route.
- Both doors: the table moved to
src/core/empty_words.ts, andsrc/web/empty_words.tsnow only adds the icons and draws the link. The boards, runs, apps and inbox terminal screens take their empty title fromsentence, and their key hints stay as the body. The people screen has no empty state, since the signed-in admin is always one.docs/features/empty-words.mdsays all this. The terminal titles changed from "No boards yet", "No runs" and "Nothing asked yet" to the table's sentences, and I updatedtui-asked.test.tsto match. - Clean:
- The header now cites test/empty-states.test.ts.
- The long trailing comment in the test sits above the pages line.
- "Invite someone" → /admin/limits fits: that page mints invite links (admin-limits.ts imports inviteLink/mint). /settings/people already returns not-found for non-admins, so only admins see the link. I wrote this down in the feature doc.
Tests: empty-states.test.ts now expects zero links for apps and boards, one link elsewhere, and no data-variant="primary" in any empty block. /apps and /boards are out of the "has a link" list.
The "releasing production" hold on the desk didn't touch this change.
All four earlier asks are met: the action is a plain link (one accent, budget file back to main), apps and boards no longer say their door twice, the table lives in src/core with the terminal's boards, runs, apps and inbox screens taking their titles from it, and the feature doc is in docs/features with a README-index row only. The /apps page answers 200 in the preview; /tell answers 303 for the preview's identity, which I read as the share-target redirect rather than a dead link.
Two things I would do next, neither blocking:
- Non-blocking: the terminal Asked screen lists what the person told the crew, but its empty title now reads 'Nothing is waiting on you.', which is the inbox's meaning. Give the terminal its own sentence there or keep the old title.
- Non-blocking: the terminal runs screen says 'No run is open.' above a body that says 'Nothing has run here yet.' for the all-time view. Pick one claim.
The board, inbox, runs, apps and people lists now take their empty sentence and one link from a single table,
EMPTY_WORDSinsrc/web/empty_words.ts. A page draws it withemptyList(kind).tsc, the gate, design-lint, andtest/empty-states.test.ts,studio-search,bindings,keys-people-list,boards-list-language,web-appsandfeature-orphanspass here. I didn't runscripts/fast.ts's test list, because it named 1970 files, over its 5-minute budget. The full check runs on push./boards): "No board yet." with the link "Start from a question" to/boards/data. The old "Make one below" hint is gone; the form still sits under it./asks): the empty page now shows a visible "Nothing is waiting on you." with "Tell the crew something". Before, only a screen-reader heading said "All fine"./admin/limits.Existing sentences are kept where tests assert them, so there is little wording drift.
test/empty-states.test.tsnow checks the board, inbox, runs and apps pages: each has one empty block with the table's sentence and exactly one link with the table's label. It also checksemptyList's link override and no-link option. The people page can't be walked over HTTP because the signed-in admin is always a person, so the test checksemptyList("people")directly. The page's own empty sentence is still held bykeys-people-list.test.ts.I left out the issues, pulls, branches and other empty lists. I also left out the filtered variants, which keep their "Show all" links. I added
docs/features/empty-words.mdand a row for it in the index. The commit carriesNo door:andDirection:lines for the gate, plusLooks: /apps.To try it, open
/boards,/asks,/appsand a repository's/runson a fresh account.Closes #13293