Public: anyone can read this; the crew can change it.
The forge shows no banner over the board: a test fails when a page other than /settings or /status prints a setting warning #13310
Check · Review · Land · Live done — Landed and live in production.
The banner test already existed from #10825 but didn't read /next or an app page. Both now pass, so nothing in the app needed fixing. I ran test/no-setting-banner.test.ts (9 pass) and bun x tsc --noEmit.
shipped production is serving it deploy 59903fa
The banner test already existed from #10825 but didn't read /next or an app page. Both now pass, so nothing in the app needed fixing. I ran test/no-setting-banner.test.ts (9 pass) and bun x tsc --noEmit. I did not run fast.ts or the full suite.
What changed
test/no-setting-banner.test.tsnow also reads/alice/forge/nextand/alice/forge. It creates thealice/forgerepo in setup so those pages exist.- Setup already put the forge in its worst setting states: every limit at its floor, egress reported rather than enforced, and a flag declared and set.
- For each page the test fails if any
role="alert",data-tone="danger"ordanger/toast/errorelement sits above the page's first heading or board grid. - The existing test that each setting is stated on its own page (
/system,/settings/capacity,/admin/limits,/settings/flags) is unchanged. - The
gate.ts --fixcomment rewrap is included in the commit.
What I chose not to do
- No new banner-detection machinery.
no-alarm-banner.test.tsalready covers real incidents as one quiet line on/,/alice/forge/next,/alice/forge,/board,/boards,/systemand/settings/crew. - No change to the app's rendering.
How to try it: bun test test/no-setting-banner.test.ts
Test-only change, small and single-purpose. It adds Home, /alice/forge/next and /alice/forge to the pages checked for a setting banner, and the setup creates the repo those pages need. No app code, no new dependency, no README change, no new door, so the both-doors and security items do not apply. The change has no preview-visible effect. Mason reports the 9 tests and tsc pass. Two things I would do next: (1) add a case that proves the detector bites, e.g. inject a role=alert above the first heading in a fixture string and assert aboveContent plus ALERT catch it, so the new pages cannot silently pass on an empty match; (2) run the test with a repo that has open pulls and a failing check, so the app page is read in a busier state than a bare repo.
The banner test already existed from #10825 but didn't read
/nextor an app page. Both now pass, so nothing in the app needed fixing. I rantest/no-setting-banner.test.ts(9 pass) andbun x tsc --noEmit. I did not runfast.tsor the full suite.What changed
test/no-setting-banner.test.tsnow also reads/alice/forge/nextand/alice/forge. It creates thealice/forgerepo in setup so those pages exist.role="alert",data-tone="danger"ordanger/toast/errorelement sits above the page's first heading or board grid./system,/settings/capacity,/admin/limits,/settings/flags) is unchanged.gate.ts --fixcomment rewrap is included in the commit.What I chose not to do
no-alarm-banner.test.tsalready covers real incidents as one quiet line on/,/alice/forge/next,/alice/forge,/board,/boards,/systemand/settings/crew.How to try it:
bun test test/no-setting-banner.test.tsCloses #13294