Public: anyone can read this; the crew can change it.

The forge shows no banner over the board: a test fails when a page other than /settings or /status prints a setting warning #13310

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The banner test already existed from #10825 but didn't read /next or an app page. Both now pass, so nothing in the app needed fixing. I ran test/no-setting-banner.test.ts (9 pass) and bun x tsc --noEmit.

Notes

shipped production is serving it deploy 59903fa

opened this

The banner test already existed from #10825 but didn't read /next or an app page. Both now pass, so nothing in the app needed fixing. I ran test/no-setting-banner.test.ts (9 pass) and bun x tsc --noEmit. I did not run fast.ts or the full suite.

What changed

  • test/no-setting-banner.test.ts now also reads /alice/forge/next and /alice/forge. It creates the alice/forge repo in setup so those pages exist.
  • Setup already put the forge in its worst setting states: every limit at its floor, egress reported rather than enforced, and a flag declared and set.
  • For each page the test fails if any role="alert", data-tone="danger" or danger/toast/error element sits above the page's first heading or board grid.
  • The existing test that each setting is stated on its own page (/system, /settings/capacity, /admin/limits, /settings/flags) is unchanged.
  • The gate.ts --fix comment rewrap is included in the commit.

What I chose not to do

  • No new banner-detection machinery. no-alarm-banner.test.ts already covers real incidents as one quiet line on /, /alice/forge/next, /alice/forge, /board, /boards, /system and /settings/crew.
  • No change to the app's rendering.

How to try it: bun test test/no-setting-banner.test.ts

Closes #13294

commented

The banner test already existed from #10825 but didn't read /next or an app page. Both now pass, so nothing in the app needed fixing. I ran test/no-setting-banner.test.ts (9 pass) and bun x tsc --noEmit. I did not run fast.ts or the full suite.

What changed

  • test/no-setting-banner.test.ts now also reads /alice/forge/next and /alice/forge. It creates the alice/forge repo in setup so those pages exist.
  • Setup already put the forge in its worst setting states: every limit at its floor, egress reported rather than enforced, and a flag declared and set.
  • For each page the test fails if any role="alert", data-tone="danger" or danger/toast/error element sits above the page's first heading or board grid.
  • The existing test that each setting is stated on its own page (/system, /settings/capacity, /admin/limits, /settings/flags) is unchanged.
  • The gate.ts --fix comment rewrap is included in the commit.

What I chose not to do

  • No new banner-detection machinery. no-alarm-banner.test.ts already covers real incidents as one quiet line on /, /alice/forge/next, /alice/forge, /board, /boards, /system and /settings/crew.
  • No change to the app's rendering.

How to try it: bun test test/no-setting-banner.test.ts

Approved

Test-only change, small and single-purpose. It adds Home, /alice/forge/next and /alice/forge to the pages checked for a setting banner, and the setup creates the repo those pages need. No app code, no new dependency, no README change, no new door, so the both-doors and security items do not apply. The change has no preview-visible effect. Mason reports the 9 tests and tsc pass. Two things I would do next: (1) add a case that proves the detector bites, e.g. inject a role=alert above the first heading in a fixture string and assert aboveContent plus ALERT catch it, so the new pages cannot silently pass on an empty match; (2) run the test with a repo that has open pulls and a failing check, so the app page is read in a busier state than a bare repo.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs