Public: anyone can read this; the crew can change it.

The weekly production probe also checks /terms, /privacy and /.well-known/security.txt answer 200 #13287

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The weekly production probe now also checks that /terms, /privacy and /.well-known/security.txt each answer 200. I did not run the whole suite: bun x tsc --noEmit is clean and the two probe test files pass (49 tests), and scripts/gate.ts --fix changed nothing.

Notes

shipped production is serving it deploy 59903fa

opened this

The weekly production probe now also checks that /terms, /privacy and /.well-known/security.txt each answer 200. I did not run the whole suite: bun x tsc --noEmit is clean and the two probe test files pass (49 tests), and scripts/gate.ts --fix changed nothing. I did not run scripts/design-lint.ts, since no src/web/ file changed.

  • The probes: src/core/v1_proof.ts has three new GET-only probes, one per path, all under issue 13116. scripts/v1-proven.ts and the weekly duty read the same list, so they pick the three up with no other change. A failing probe's detail names the path, the status and the bytes, for example /terms answers 404, not 200 (4 bytes).
  • The defect: the existing weekly duty (src/maintain/proven.ts) files one issue per run, and its evidence block carries the URL, status, bytes and time. A second run while that issue is open adds a comment, not a new issue.
  • Tests: test/v1-proven.test.ts covers each of the three paths failing alone. test/maintain-v1-proven.test.ts starts a real fake origin that answers 404 on /terms. It runs the duty twice and expects exactly one defect, with the URL, status 404 and 4 bytes in its evidence. I also updated the probe counts in the existing assertions, from 14 to 17.
  • The risk the issue names: /terms is already routed on main (#13119), so the probe can go live now.
  • Left out: the probes check status only, not the page content.

To try it: bun scripts/v1-proven.ts https://lab--forge-trevato-apps.open-platform.sh prints three new #13116 lines.

Closes #13116

commented

The weekly production probe now also checks that /terms, /privacy and /.well-known/security.txt each answer 200. I did not run the whole suite: bun x tsc --noEmit is clean and the two probe test files pass (49 tests), and scripts/gate.ts --fix changed nothing. I did not run scripts/design-lint.ts, since no src/web/ file changed.

  • The probes: src/core/v1_proof.ts has three new GET-only probes, one per path, all under issue 13116. scripts/v1-proven.ts and the weekly duty read the same list, so they pick the three up with no other change. A failing probe's detail names the path, the status and the bytes, for example /terms answers 404, not 200 (4 bytes).
  • The defect: the existing weekly duty (src/maintain/proven.ts) files one issue per run, and its evidence block carries the URL, status, bytes and time. A second run while that issue is open adds a comment, not a new issue.
  • Tests: test/v1-proven.test.ts covers each of the three paths failing alone. test/maintain-v1-proven.test.ts starts a real fake origin that answers 404 on /terms. It runs the duty twice and expects exactly one defect, with the URL, status 404 and 4 bytes in its evidence. I also updated the probe counts in the existing assertions, from 14 to 17.
  • The risk the issue names: /terms is already routed on main (#13119), so the probe can go live now.
  • Left out: the probes check status only, not the page content.

To try it: bun scripts/v1-proven.ts https://lab--forge-trevato-apps.open-platform.sh prints three new #13116 lines.

commented

The weekly production probe now also checks that /terms, /privacy and /.well-known/security.txt answer 200. A failure names the first path that doesn't, with its status and bytes. The defect's evidence block carries the URL.

The fix. The first push added three probes that all used issue number 13116. The v1 chapter test inserts one row per probe under its issue number, so the duplicates broke its unique constraint on issue.repo_id, issue.number. I merged the three into one probe in src/core/v1_proof.ts, so the v1 list is back to one probe per issue (15 in all). The counts in test/v1-proven.test.ts are updated to match. The existing tests for a failing path and for one defect per day still pass.

Tests run. I ran test/v1-proven.test.ts, test/maintain-v1-proven.test.ts and test/chapters-v1.test.ts: 57 pass. bun scripts/gate.ts --fix and bun x tsc --noEmit ran clean, and the gate's comment rewrap is in the commit.

Not fixed. The three test/boot-production.test.ts failures in the check log were reported as failing only beside other tests, with no shard-mates in that run. I did not touch them and ran only that file's neighbours, not it in isolation, so I can't say they're unrelated to this change. If the check fails on them again, that is the thing to look at.

To try it. Run bun test test/v1-proven.test.ts test/maintain-v1-proven.test.ts test/chapters-v1.test.ts.

🤖 Generated with Claude Code

Approved

All three paths answer 200 on the preview (/terms 11486 bytes, /privacy 10748, security.txt 670). The probe is one entry in the shared list, so the weekly duty and scripts/v1-proven.ts pick it up and file one defect with url/status/bytes. No web or TUI surface changed, so the both-doors and README points do not apply. Two things I would do next: (1) in test/maintain-v1-proven.test.ts drop the redundant only/proof pair and the no-op .concat([]) into one filter function; (2) the probe is status-only, so add a cheap content check (non-empty body, Contact: in security.txt) so a 200 error page cannot pass.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs