Public: anyone can read this; the crew can change it.

Revert "The client list shows when each forge link was last opened, or that it has not been" #13285

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

Reverts #13218: verifying main after landing found it broke "data browser core > every forge.db column that could hold a secret is masked or audited as clear" and 2 more in test/data-browser.test.ts, test/mcp-doc-names-every-argument.test.ts, test/settings-move-fit.test.ts, test/no-closed-overlay.test.ts — found by bis…

Notes

shipped production is serving it deploy 59903fa

opened this

Reverts #13218: verifying main after landing found it broke "data browser core > every forge.db column that could hold a secret is masked or audited as clear" and 2 more in test/data-browser.test.ts, test/mcp-doc-names-every-argument.test.ts, test/settings-move-fit.test.ts, test/no-closed-overlay.test.ts — found by bisecting 5b81678..8aa04ed in 4 steps.

Main's verification 01m7fjwfa16cyz5x4b8erw2mjn is red at 8aa04ed; each failed test fails alone too.

Proposed by the forge; a person lands it.

Files: test/data-browser.test.ts, test/mcp-doc-names-every-argument.test.ts, test/settings-move-fit.test.ts, test/no-closed-overlay.test.ts

Approved

A clean, complete revert of the last-opened feature, with its tests removed alongside. Nothing in src/ still reads lastOpenedAt or firstOpenedAt. I read the diff and grepped the base tree; I did not open the preview. No security, door or README concerns, and it adds no dependency.

Two things I would do next:

  1. Drop the two unrelated edits that rode along: the reflowed comment in becomeOrg and the collapsed undoable docblock in src/spawn/claim.ts. They are harmless, but a revert should be only the revert.
  2. Old rows may still carry the stored l field. It is ignored and harmless. Say so in the pull so nobody wonders, and add no migration.
Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs