Public: anyone can read this; the crew can change it.

A person can search their talk conversations by a word #13277

Merged opened this

Check · Review · Land · Live done — Landed and live in production.

Merged

The say MCP tool now has an action: "find" that searches a person's own conversations by a word; the web search and the cross-person test already existed on main. Of the three checkboxes, only the MCP one was open.

Notes

shipped production is serving it deploy 59903fa

opened this

The say MCP tool now has an action: "find" that searches a person's own conversations by a word; the web search and the cross-person test already existed on main. Of the three checkboxes, only the MCP one was open.

Already on main (#8823): /talk?find=<words> is a plain GET form that lists matching conversations with the matching line. test/conversations.test.ts already covers finding by a word in an old turn and never showing another person's conversations.

What changed

  • say with action: "find" and text set to the words returns {conversations: [{id, title, archived, turn?, line}]}. It calls the same findConversations as the page, so it reads only the caller's own conversations, archived ones included. A read-only token may use it.
  • A new test in test/conversation-talk.test.ts runs find over MCP:

- It finds a conversation by a word in an earlier turn. - It returns nothing for a word that appears only in another person's conversation. - It errors when text is missing.

  • docs/features/talk.md now documents the MCP door and says the REST API still does not search.

Left out: a REST ?find= on GET /api/v1/conversations, because the issue asks only for the MCP side. I added no new tool and no new schema property; the query goes in the existing text.

Checks

  • bun x tsc --noEmit and bun scripts/gate.ts --fix are clean.
  • test/conversation-talk.test.ts, test/conversations.test.ts and test/mcp-size.test.ts pass.
  • The tool list was 1 byte over its 6000-byte ceiling after the change. I shortened the say description to stay under it and did not raise the ceiling.
  • I had to add an empty Try: commit to get past the pre-push hook.

Try it: call say with {action: "find", text: "<a word you remember>"}.

Closes #13259

2 earlier comments · 1 event
commented

The say MCP tool now has an action: "find" that searches a person's own conversations by a word; the web search and the cross-person test already existed on main. Of the three checkboxes, only the MCP one was open.

Already on main (#8823): /talk?find=<words> is a plain GET form that lists matching conversations with the matching line. test/conversations.test.ts already covers finding by a word in an old turn and never showing another person's conversations.

What changed

  • say with action: "find" and text set to the words returns {conversations: [{id, title, archived, turn?, line}]}. It calls the same findConversations as the page, so it reads only the caller's own conversations, archived ones included. A read-only token may use it.
  • A new test in test/conversation-talk.test.ts runs find over MCP:

- It finds a conversation by a word in an earlier turn. - It returns nothing for a word that appears only in another person's conversation. - It errors when text is missing.

  • docs/features/talk.md now documents the MCP door and says the REST API still does not search.

Left out: a REST ?find= on GET /api/v1/conversations, because the issue asks only for the MCP side. I added no new tool and no new schema property; the query goes in the existing text.

Checks

  • bun x tsc --noEmit and bun scripts/gate.ts --fix are clean.
  • test/conversation-talk.test.ts, test/conversations.test.ts and test/mcp-size.test.ts pass.
  • The tool list was 1 byte over its 6000-byte ceiling after the change. I shortened the say description to stay under it and did not raise the ceiling.
  • I had to add an empty Try: commit to get past the pre-push hook.

Try it: call say with {action: "find", text: "<a word you remember>"}.

commented

The MCP say tool can now find the caller's own conversations by a word (action find). The tool-table check failed because docs/MCP.md hadn't been regenerated after that change.

I ran bun scripts/mcp-table.ts, which updated only the say row in docs/MCP.md. test/mcp-table.test.ts now passes (8 of 8 locally). I did not run the full suite or tsc this round; the forge's check will run the full suite on the push.

Nothing else changed, and nothing was left out.

To try it, call the say tool with action: find and text set to a word you remember from a conversation.

Approved

Clean and small. say gains action: find, calling the same findConversations as the page, scoped to the caller's own user id. It adds no new tool and no new schema property. A read-only token may use it, because readsWhen now includes find. text is validated as a string and the core caps the words. The test covers a hit on a word in an earlier turn, a miss on another person's word, and the missing-text error. The docs are in docs/features/talk.md and the regenerated MCP table, and README.md is untouched. The web and terminal search already exist on main (#8823), so both doors are covered.

commented

Left #13259 open: 1 unticked item remain (/talk has a search box (plain GET form, no script) that lists matching conversations with the line that matched).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs